)]}'
{"test/unit/common/test_bufferedhttp.py":[{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"07ee3dbe969a085a82f98ef3aab1b1a4c94d511c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                            \u0027content-length\u0027: 7,"},{"line_number":83,"context_line":"                            \u0027x-header\u0027: \u0027value\u0027},"},{"line_number":84,"context_line":"                        query_string\u003d\u0027omg\u0026no\u003d%7f\u0027)"},{"line_number":85,"context_line":"                    conn.send(\u0027REQUEST\\r\\n\u0027)"},{"line_number":86,"context_line":"                    resp \u003d conn.getresponse()"},{"line_number":87,"context_line":"                    body \u003d resp.read()"},{"line_number":88,"context_line":"                    # Initializing buffer data and reading it with different"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_d053e637","line":85,"updated":"2015-11-24 01:36:54.000000000","message":"so its not jumping out at me why this was removed so instead of thinking I\u0027ll just ask :)  Why was this removed?","commit_id":"cc7b1358d150ec449ad1603e4f33859d261fdf3d"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"f802a702bcff82b28f1ea0687a075bf7a05a1af2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    set_readline_buffer()"},{"line_number":95,"context_line":"                    body_boundread_less \u003d resp.read(6)"},{"line_number":96,"context_line":"                    set_readline_buffer()"},{"line_number":97,"context_line":"                    body_boundread_great \u003d resp.read(11)"},{"line_number":98,"context_line":"                    conn.close()"},{"line_number":99,"context_line":"                    self.assertEqual(resp.status, 200)"},{"line_number":100,"context_line":"                    self.assertEqual(resp.reason, \u0027OK\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_5a48c587","line":97,"updated":"2015-12-01 02:43:18.000000000","message":"To cover all edge cases, do you want to add some reads of \u003c 6?\n\n  set_readline_buffer()\n  body_boundread_tiny \u003d resp.read(1)\n  body_boundread_small \u003d resp.read(3)\n\n...\n\n  self.assertEqual(body_boundread_tiny, \u0027B\u0027)\n  self.assertEqual(body_boundread_small, \u0027UFF\u0027)","commit_id":"7bf87d603b77b4fe13a2d678362eab253b1ffb81"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"0640715a1a0e98df198a75c7381109234dbf72cd","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                            self.fail("},{"line_number":132,"context_line":"                                \u0027Exception %r for device\u003d%r path\u003d%r header\u003d%r\u0027"},{"line_number":133,"context_line":"                                % (e, dev, path, header))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":137,"context_line":"    unittest.main()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_94cc58bc","side":"PARENT","line":134,"updated":"2015-12-02 15:36:59.000000000","message":"A very nitpick. Was this line deletion suggested by pep8 check?","commit_id":"42b0bc04601e3e376849954c0ff3ea883c537291"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"110d4cc7b9e250465b149c5d5ae2fc4abf224636","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import unittest"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":"from eventlet import spawn, Timeout, listen"},{"line_number":21,"context_line":"from swift.common import bufferedhttp"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b7724aac","line":20,"updated":"2015-12-03 15:45:45.000000000","message":"Third party libraries imports, swift libraries imports and stdlib imports should be kept separate. \n\nhttp://docs.openstack.org/developer/hacking/#real-world-import-order-examples","commit_id":"2ccc22c047afd44740928e0bc67336fe32a092d8"},{"author":{"_account_id":14867,"name":"Jaivish Kothari(janonymous)","email":"janonymous.codevulture@gmail.com","username":"Janonymous"},"change_message_id":"110d4cc7b9e250465b149c5d5ae2fc4abf224636","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    body_boundread_great \u003d resp.read(11)"},{"line_number":98,"context_line":"                    set_readline_buffer()"},{"line_number":99,"context_line":"                    body_boundread_tiny \u003d resp.read(1)"},{"line_number":100,"context_line":"                    body_boundread_small \u003d resp.read(3)"},{"line_number":101,"context_line":"                    conn.close()"},{"line_number":102,"context_line":"                    self.assertEqual(resp.status, 200)"},{"line_number":103,"context_line":"                    self.assertEqual(resp.reason, \u0027OK\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_b75eca74","line":100,"updated":"2015-12-03 15:45:45.000000000","message":"I have a small question: Is it really testing something? I think you are calling read on a simple string by attaching it to (resp.variable) not through actual resp received from conn.getresponse() , Please correct me if i am interpreting it wrong, i wanted to understand this.","commit_id":"2ccc22c047afd44740928e0bc67336fe32a092d8"},{"author":{"_account_id":12193,"name":"Hisashi Osanai","email":"osanai.hisashi@jp.fujitsu.com","username":"ho"},"change_message_id":"f65c16c7d2d517ec6465795e7253513fd8066dcb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import unittest"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from eventlet import listen, spawn, Timeout"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from swift.common import bufferedhttp"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_27131668","line":20,"updated":"2015-12-07 08:38:10.000000000","message":"I think an order of import statements looks like:\n\nimport socket\nimport unittest\n\nfrom eventlet import listen, spawn, Timeout\nimport mock\n\nthere is no blank line b/w socket and unittest and eventlet is first than mock as third party lib.","commit_id":"6dc6b264faa695c583fbfd93615c807c224e0b0b"}]}