)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6de0cbbc93d2a20257530f9942537626445c0089","unresolved":false,"context_lines":[{"line_number":12,"context_line":"everywhere."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Hopefully, this lets us avoid code that, for example, works in the"},{"line_number":15,"context_line":"object server but fails in the replicator."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia30d069c5ac89f4bfbe52233d03d96738144b614"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_99c1fb56","line":15,"updated":"2015-11-26 11:30:07.000000000","message":"I feel I may be asking a dumb question, but why the reference to object server and replicator here, when the changes are in the updater?","commit_id":"0be365dcf01a44a5b093dc34bc8e90182cd0badd"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0406f36e48581c25b5f87a17e1078083fae96c90","unresolved":false,"context_lines":[{"line_number":12,"context_line":"everywhere."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Hopefully, this lets us avoid code that, for example, works in the"},{"line_number":15,"context_line":"object server but fails in the replicator."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia30d069c5ac89f4bfbe52233d03d96738144b614"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_4be1e1fd","line":15,"in_reply_to":"9a8ffd7b_99c1fb56","updated":"2015-11-30 23:19:23.000000000","message":"Eh, probably because I\u0027m bad at writing words. (Code too, but there\u0027s not much of that in the commit message.)","commit_id":"0be365dcf01a44a5b093dc34bc8e90182cd0badd"}],"swift/container/updater.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6de0cbbc93d2a20257530f9942537626445c0089","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def run_once(self, *args, **kwargs):"},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        Run the updater once."},{"line_number":179,"context_line":"        \"\"\""},{"line_number":180,"context_line":"        patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":181,"context_line":"        self.logger.info(_(\u0027Begin container update single threaded sweep\u0027))"},{"line_number":182,"context_line":"        begin \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d9bf83a8","line":179,"updated":"2015-11-26 11:30:07.000000000","message":"what about this one?\n\nI\u0027m not sure why this call is here but not in the run_once method of the object updater - should there be symmetry? I can see why it *may* not be necessary here since no new process is being forked, but at same time I haven\u0027t yet worked out where the eventlet patching does occur in this path.","commit_id":"0be365dcf01a44a5b093dc34bc8e90182cd0badd"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"0406f36e48581c25b5f87a17e1078083fae96c90","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def run_once(self, *args, **kwargs):"},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        Run the updater once."},{"line_number":179,"context_line":"        \"\"\""},{"line_number":180,"context_line":"        patcher.monkey_patch(all\u003dFalse, socket\u003dTrue)"},{"line_number":181,"context_line":"        self.logger.info(_(\u0027Begin container update single threaded sweep\u0027))"},{"line_number":182,"context_line":"        begin \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_0b1d190f","line":179,"in_reply_to":"9a8ffd7b_d9bf83a8","updated":"2015-11-30 23:19:23.000000000","message":"I missed one. Will fix.","commit_id":"0be365dcf01a44a5b093dc34bc8e90182cd0badd"}],"swift/obj/updater.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6de0cbbc93d2a20257530f9942537626445c0089","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                time.sleep(self.interval - elapsed)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def run_once(self, *args, **kwargs):"},{"line_number":121,"context_line":"        \"\"\"Run the updater once.\"\"\""},{"line_number":122,"context_line":"        self.logger.info(_(\u0027Begin object update single threaded sweep\u0027))"},{"line_number":123,"context_line":"        begin \u003d time.time()"},{"line_number":124,"context_line":"        self.successes \u003d 0"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_193f4b25","line":121,"updated":"2015-11-26 11:30:07.000000000","message":"hmmm, no monkey_patch here cf. the container updater","commit_id":"0be365dcf01a44a5b093dc34bc8e90182cd0badd"}]}
