)]}'
{"swift/common/middleware/decrypter.py":[{"author":{"_account_id":18820,"name":"Peter Chng","email":"pchng@ca.ibm.com","username":"pchng"},"change_message_id":"d67a11ae20118f7bb37478abe84d4a4f095b962a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                        pass"},{"line_number":105,"context_line":"        if crypto_meta is None:"},{"line_number":106,"context_line":"            # it\u0027s not an error to have been passed an unencrypted value"},{"line_number":107,"context_line":"            # TODO: Log here?"},{"line_number":108,"context_line":"            return value"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            self._check_cipher(crypto_meta.get(\u0027cipher\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f11daac","line":107,"updated":"2015-11-16 17:04:27.000000000","message":"Unsure whether this is log-worthy. \nPreviously, when crypto-meta was sysmeta, the absence of crypto-meta for a user-meta value was logged.","commit_id":"c02020d6b369f3dfa33248807c676ba76e771b19"},{"author":{"_account_id":18820,"name":"Peter Chng","email":"pchng@ca.ibm.com","username":"pchng"},"change_message_id":"87220ba10b4117a3653d6e5855feba53ffb3679b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                        pass"},{"line_number":104,"context_line":"        if crypto_meta is None:"},{"line_number":105,"context_line":"            # it\u0027s not an error to have been passed an unencrypted value"},{"line_number":106,"context_line":"            # TODO: Log here?"},{"line_number":107,"context_line":"            return value"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            self._check_cipher(crypto_meta.get(\u0027cipher\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_3d54b11f","line":106,"updated":"2015-11-17 15:49:43.000000000","message":"Unsure whether this is log-worthy. Previously, when crypto-meta was sysmeta, the absence of crypto-meta for a user-meta value was logged.","commit_id":"180f7445b5b5d46491c41e8961847670db58f6ff"}],"swift/common/middleware/encrypter.py":[{"author":{"_account_id":18820,"name":"Peter Chng","email":"pchng@ca.ibm.com","username":"pchng"},"change_message_id":"87220ba10b4117a3653d6e5855feba53ffb3679b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                # in sync."},{"line_number":173,"context_line":"                req.headers[name], crypto_meta \u003d encrypt_header_val("},{"line_number":174,"context_line":"                    self.crypto, val, keys[self.server_type],"},{"line_number":175,"context_line":"                    append_crypto_meta\u003dTrue)"},{"line_number":176,"context_line":"                self.logger.debug(\"encrypted user meta: %s: %s using %s\""},{"line_number":177,"context_line":"                                  % (name, req.headers[name], crypto_meta))"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_204c886f","line":175,"updated":"2015-11-17 15:49:43.000000000","message":"This re-uses the functionality that\u0027s applied for the Content-Length header.\nOne concern I had was whether an attacker could inject their own crypto-meta to cause problems, i.e. putting in a bad cipher or IV.","commit_id":"180f7445b5b5d46491c41e8961847670db58f6ff"}]}