)]}'
{"swift/common/swob.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"adb1621f1ca8a3deee371415b8240579d4c1d564","unresolved":false,"context_lines":[{"line_number":1223,"context_line":"        self.content_range \u003d None"},{"line_number":1224,"context_line":"        return content_size, content_type"},{"line_number":1225,"context_line":""},{"line_number":1226,"context_line":"    def _check_requests_for_error(self, etag):"},{"line_number":1227,"context_line":"        if etag and self.request.if_none_match and \\"},{"line_number":1228,"context_line":"                etag in self.request.if_none_match:"},{"line_number":1229,"context_line":"            self.status \u003d 304"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_595ac92b","line":1226,"updated":"2015-11-23 22:21:06.000000000","message":"Try writing a doc string for this method (what the method does, side effects, and explanation of params and return value) and see what you think.\n\nI think passing in the self.conditional_etag is redundant.\n\nI think it might be clearer if if returns a status int on error and None otherwise.\n\nThe side effect of setting the status state, but then still having to return should_return_empty_body_error seems brain-split to me.","commit_id":"d90b4c416615e8ecdd71fa27a654affa3ec40313"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"07df06082f73961f7f54156cc724296c9003416c","unresolved":false,"context_lines":[{"line_number":1226,"context_line":"        return content_size, content_type"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"    def _get_not_modified_status(self):"},{"line_number":1229,"context_line":"        \"\"\"Checks requests if it contains error"},{"line_number":1230,"context_line":"        :returns: error status code if requests contain error"},{"line_number":1231,"context_line":"                  None otherwise"},{"line_number":1232,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a3c09a3_fadc6e48","line":1229,"range":{"start_line":1229,"start_character":11,"end_line":1229,"end_character":47},"updated":"2017-01-13 05:30:09.000000000","message":"I understand the change of the name to get_not_modified_status, thats cool. But the doc string should say a little more about it, as really it doesn\u0027t have anything to do with the name.\n\nLooking more at the method, it is really not just getting a 304, its really doing the conditional response on an if-match/if-modified.\n\nMaybe it should be something like:\n\n  def _get_conditional_response_status(self):\n  \u0027\u0027\u0027Checks for a conditional response from an if_match or if_modified\n  request. If so returns the correct status code (304 or 412)\n  :returns: conditaional response status (304 or 412) or None\n  \u0027\u0027\u0027\n\nOr at least clean up the doc string.","commit_id":"cd3a5e27f7df0df6f74548ef1b061de8e493314e"}]}