)]}'
{"swift/common/middleware/bulk.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2984b32ca2d8220ba35072967dca21f022b73fee","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise HTTPBadRequest(\u0027Invalid request: no content sent.\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        while data_remaining:"},{"line_number":197,"context_line":"            if len(objs_to_delete) \u003e self.max_deletes_per_request:"},{"line_number":198,"context_line":"                raise HTTPRequestEntityTooLarge("},{"line_number":199,"context_line":"                    \u0027Maximum Bulk Deletes: %d per request\u0027 %"},{"line_number":200,"context_line":"                    self.max_deletes_per_request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8ms%3D","side":"PARENT","line":197,"updated":"2013-03-19 21:08:22.000000000","message":"Might replace \u003e with \u003e\u003d instead, don\u0027t you think?","commit_id":"4360744767f46c6dcbe8e85df6d8a0984ddd55a5"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"2f397441878cd27ab45886146ae709f2aed3902d","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise HTTPBadRequest(\u0027Invalid request: no content sent.\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        while data_remaining:"},{"line_number":197,"context_line":"            if len(objs_to_delete) \u003e self.max_deletes_per_request:"},{"line_number":198,"context_line":"                raise HTTPRequestEntityTooLarge("},{"line_number":199,"context_line":"                    \u0027Maximum Bulk Deletes: %d per request\u0027 %"},{"line_number":200,"context_line":"                    self.max_deletes_per_request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8h0%3D","side":"PARENT","line":197,"in_reply_to":"AAAAOH%2F%2F8ms%3D","updated":"2013-03-19 21:56:17.000000000","message":"not the way the code\u0027s written (the unit tests fail with this change). also i have the other if below so this keeps them together","commit_id":"4360744767f46c6dcbe8e85df6d8a0984ddd55a5"}],"test/unit/common/middleware/test_bulk.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2984b32ca2d8220ba35072967dca21f022b73fee","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            self.assertEquals(results, [\u00271\u0027, \u00272\u0027, \u00273\u0027])"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        with patch.object(self.bulk, \u0027max_deletes_per_request\u0027, 9):"},{"line_number":465,"context_line":"            with patch.object(bulk, \u0027MAX_PATH_LENGTH\u0027, 1):"},{"line_number":466,"context_line":"                req_body \u003d \u0027\\n\u0027.join([str(i) for i in xrange(10)])"},{"line_number":467,"context_line":"                req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027, body\u003dreq_body)"},{"line_number":468,"context_line":"                self.assertRaises(HTTPException, self.bulk.get_objs_to_delete, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8m4%3D","line":465,"updated":"2013-03-19 21:08:22.000000000","message":"Is this should be bulk or self.bulk?","commit_id":"1b150749f7a47f40f346213ea901fd439838c478"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"2f397441878cd27ab45886146ae709f2aed3902d","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            self.assertEquals(results, [\u00271\u0027, \u00272\u0027, \u00273\u0027])"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        with patch.object(self.bulk, \u0027max_deletes_per_request\u0027, 9):"},{"line_number":465,"context_line":"            with patch.object(bulk, \u0027MAX_PATH_LENGTH\u0027, 1):"},{"line_number":466,"context_line":"                req_body \u003d \u0027\\n\u0027.join([str(i) for i in xrange(10)])"},{"line_number":467,"context_line":"                req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027, body\u003dreq_body)"},{"line_number":468,"context_line":"                self.assertRaises(HTTPException, self.bulk.get_objs_to_delete, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8hw%3D","line":465,"in_reply_to":"AAAAOH%2F%2F8m4%3D","updated":"2013-03-19 21:56:17.000000000","message":"bulk- its a mod lvl variable","commit_id":"1b150749f7a47f40f346213ea901fd439838c478"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2984b32ca2d8220ba35072967dca21f022b73fee","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            with patch.object(bulk, \u0027MAX_PATH_LENGTH\u0027, 1):"},{"line_number":466,"context_line":"                req_body \u003d \u0027\\n\u0027.join([str(i) for i in xrange(10)])"},{"line_number":467,"context_line":"                req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027, body\u003dreq_body)"},{"line_number":468,"context_line":"                self.assertRaises(HTTPException, self.bulk.get_objs_to_delete, req)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def test_bulk_delete_works_extra_newlines_extra_quoting(self):"},{"line_number":471,"context_line":"        req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8mc%3D","line":468,"updated":"2013-03-19 21:08:22.000000000","message":"Dunno if this is feasible, but is it possible to check that HTTPException when thrown has status\u003d413 or something?","commit_id":"1b150749f7a47f40f346213ea901fd439838c478"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"2f397441878cd27ab45886146ae709f2aed3902d","unresolved":false,"context_lines":[{"line_number":465,"context_line":"            with patch.object(bulk, \u0027MAX_PATH_LENGTH\u0027, 1):"},{"line_number":466,"context_line":"                req_body \u003d \u0027\\n\u0027.join([str(i) for i in xrange(10)])"},{"line_number":467,"context_line":"                req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027, body\u003dreq_body)"},{"line_number":468,"context_line":"                self.assertRaises(HTTPException, self.bulk.get_objs_to_delete, req)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"    def test_bulk_delete_works_extra_newlines_extra_quoting(self):"},{"line_number":471,"context_line":"        req \u003d Request.blank(\u0027/delete_works/AUTH_Acc\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8hU%3D","line":468,"in_reply_to":"AAAAOH%2F%2F8mc%3D","updated":"2013-03-19 21:56:17.000000000","message":"its possible but maybe not needed? its a pretty specific test but i can change it to a try: except HTTPException if you like","commit_id":"1b150749f7a47f40f346213ea901fd439838c478"}]}