)]}'
{"swift/common/request_helpers.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b06eeff806d0159b56134192f7248d86063f4889","unresolved":false,"context_lines":[{"line_number":319,"context_line":"                    agent\u003d(\u0027%(orig)s \u0027 + self.ua_suffix),"},{"line_number":320,"context_line":"                    swift_source\u003dself.swift_source)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"                seg_req_rangeval \u003d None"},{"line_number":323,"context_line":"                if first_byte !\u003d 0 or not go_to_end:"},{"line_number":324,"context_line":"                    seg_req_rangeval \u003d \"%s-%s\" % ("},{"line_number":325,"context_line":"                        first_byte, \u0027\u0027 if go_to_end else last_byte)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b1a50fb6","line":322,"updated":"2015-11-26 01:45:25.000000000","message":"Why default this to None? Why not \"0-%d\" % (seg_size - 1)? Then down below, we could always say new_range_str +\u003d \",\" + seg_req_rangeval, right?","commit_id":"c28709f8f264f4426364b67a2a2755311111c1e4"}],"swift/common/swob.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b06eeff806d0159b56134192f7248d86063f4889","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            if end is not None:"},{"line_number":549,"context_line":"                string +\u003d str(end)"},{"line_number":550,"context_line":"            if i \u003c len(self.ranges) - 1:"},{"line_number":551,"context_line":"                string +\u003d \u0027,\u0027"},{"line_number":552,"context_line":"        return string"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def ranges_for_length(self, length):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_91756b99","line":551,"updated":"2015-11-26 01:45:25.000000000","message":"This feels like exactly the sort of thing that \u0027,\u0027.join(...) is for...","commit_id":"c28709f8f264f4426364b67a2a2755311111c1e4"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"a59ee9ad81a130a629c35a6f1ce39ebf7768225d","unresolved":false,"context_lines":[{"line_number":548,"context_line":"            if end is not None:"},{"line_number":549,"context_line":"                string +\u003d str(end)"},{"line_number":550,"context_line":"            if i \u003c len(self.ranges) - 1:"},{"line_number":551,"context_line":"                string +\u003d \u0027,\u0027"},{"line_number":552,"context_line":"        return string"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"    def ranges_for_length(self, length):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8946c84d","line":551,"in_reply_to":"9a8ffd7b_91756b99","updated":"2015-12-01 15:22:27.000000000","message":"I had something similar in mind, but in this case I prefer the current codebase, easier to read imo. Otherwise we might end with something like this:\n\n \u0027,\u0027.join([s + \"-\" + e for (s,e) in [(s if s else \u0027\u0027,e if e else \u0027\u0027) for (s,e) in ranges]])","commit_id":"c28709f8f264f4426364b67a2a2755311111c1e4"}],"test/unit/common/middleware/test_slo.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"a59ee9ad81a130a629c35a6f1ce39ebf7768225d","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"             {\u0027name\u0027: \u0027/gettest/d_20\u0027, \u0027hash\u0027: md5hex(\"d\" * 20),"},{"line_number":1327,"context_line":"              \u0027content_type\u0027: \u0027text/plain\u0027, \u0027bytes\u0027: \u002720\u0027},"},{"line_number":1328,"context_line":"             {\u0027name\u0027: \u0027/gettest/d_20\u0027, \u0027hash\u0027: md5hex(\"d\" * 20),"},{"line_number":1329,"context_line":"              \u0027content_type\u0027: \u0027text/plain\u0027, \u0027bytes\u0027: \u002720\u0027}])"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"        self.app.register("},{"line_number":1332,"context_line":"            \u0027GET\u0027, \u0027/v1/AUTH_test/gettest/manifest-aabbccdd\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_493a209a","line":1329,"updated":"2015-12-01 15:22:27.000000000","message":"That looks quite long - do we really need 8 segments to tests this? In my tests 3 segments were enough - or am I missing something here?","commit_id":"c28709f8f264f4426364b67a2a2755311111c1e4"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b06eeff806d0159b56134192f7248d86063f4889","unresolved":false,"context_lines":[{"line_number":1328,"context_line":"             {\u0027name\u0027: \u0027/gettest/d_20\u0027, \u0027hash\u0027: md5hex(\"d\" * 20),"},{"line_number":1329,"context_line":"              \u0027content_type\u0027: \u0027text/plain\u0027, \u0027bytes\u0027: \u002720\u0027}])"},{"line_number":1330,"context_line":""},{"line_number":1331,"context_line":"        self.app.register("},{"line_number":1332,"context_line":"            \u0027GET\u0027, \u0027/v1/AUTH_test/gettest/manifest-aabbccdd\u0027,"},{"line_number":1333,"context_line":"            swob.HTTPOk, {\u0027Content-Type\u0027: \u0027application/json\u0027,"},{"line_number":1334,"context_line":"                          \u0027X-Static-Large-Object\u0027: \u0027true\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_91d1eb59","line":1331,"updated":"2015-11-26 01:45:25.000000000","message":"What, you don\u0027t think setUp() is long enough yet? :P","commit_id":"c28709f8f264f4426364b67a2a2755311111c1e4"}]}