)]}'
{"id":"openstack%2Fswift~25317","triplet_id":"openstack%2Fswift~master~I7d0533a0aaf189ac452abbd983469acb064fdca4","project":"openstack/swift","branch":"master","topic":"bug/1159960","hashtags":[],"change_id":"I7d0533a0aaf189ac452abbd983469acb064fdca4","subject":"Add crossdomain.xml middleware","status":"MERGED","created":"2013-03-25 18:49:13.000000000","updated":"2013-04-27 08:56:20.000000000","submitted":"2013-04-27 08:56:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bb61958cabb08b2d2b282a3ada6dcb2257fb38a6","_number":25317,"virtual_id_number":25317,"owner":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":1,"date":"2013-04-23 13:15:04.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2013-04-27 08:56:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"all":[{"value":0,"date":"2013-04-23 12:59:10.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},{"value":2,"date":"2013-04-27 05:08:26.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-04-27 08:12:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":0,"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},{"value":0,"date":"2013-04-27 05:08:26.000000000","_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-04-27 08:12:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-25 19:13:31.000000000","updated_by":{"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},"reviewer":{"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},"state":"REVIEWER"},{"updated":"2013-03-27 10:06:46.000000000","updated_by":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"reviewer":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"state":"REVIEWER"},{"updated":"2013-04-23 13:15:04.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-04-27 05:08:26.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2013-04-27 08:12:06.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2013-04-27 08:56:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f5c9114512656bdbf77fea92b2d085aa5654d6f2","author":{"_account_id":904,"name":"Adrian Smith","email":"adrian@17od.com","username":"adriansmith"},"date":"2013-03-25 19:13:31.000000000","message":"Patch Set 1:\n\nHi Donagh. crossdomain.xml has a lot of similarities to CORs. When I originally submitted CORS middleware it was (rightly) pointed out that it should be configurable on/off per tenant. I\u0027d suggest a similar approach for crossdomain.xml.","accounts_in_message":[],"_revision_number":1},{"id":"b57f039fbbeef2da9b3d7b7f3e18fea34d2184e2","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-25 19:13:37.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/79885\n","accounts_in_message":[],"_revision_number":1},{"id":"f59991d205b52f0edfa779c509cd16fc3a13ec27","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-25 19:13:37.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThe middleware right now will respond with that XML document for *any* request to /crossdomain.xml, regardless of HTTP verb. Could you make it only do that for GET requests, please?\n\nIn particular, I\u0027m concerned that a request like \"HEAD /crossdomain.xml\" will receive a response with a nonempty body, and RFC2616 doesn\u0027t allow HEAD responses to have bodies.","accounts_in_message":[],"_revision_number":1},{"id":"056713ca809164b38451a18d7346fc11d5cda59f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-25 19:34:08.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25317/1/check/gate-swift-pep8/1968 : SUCCESS\n- http://logs.openstack.org/25317/1/check/gate-swift-docs/1799 : SUCCESS\n- http://logs.openstack.org/25317/1/check/gate-swift-python26/2047 : SUCCESS\n- http://logs.openstack.org/25317/1/check/gate-swift-python26-rhel6/23 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/1/check/gate-swift-python27/2049 : FAILURE\n- http://logs.openstack.org/25317/1/check/gate-tempest-devstack-vm-full/10391 : SUCCESS\n- http://logs.openstack.org/25317/1/check/gate-tempest-devstack-vm-quantum/15920 : SUCCESS\n- http://logs.openstack.org/25317/1/check/gate-tempest-devstack-vm-postgres-full/10107 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"b856f84adeb1cac1314f953b930ba2cecb092529","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-03-25 19:38:04.000000000","message":"Patch Set 1:\n\nRe: CORS: I believe the difference between crossdomain.xml and CORS is that in CORS, the preflight request is directed at a *resource* (i.e, https://endpoint//v1/\u003caccount\u003e/\u003ccontainer\u003e[\u003cobject\u003e]) whereas crossdomain.xml is blunt -- it\u0027s directed at the endpoint.\n\nHowever, I\u0027m open to correction.\n\nRe: GET/HEAD. Good point. Will refactor.","accounts_in_message":[],"_revision_number":1},{"id":"9aae981345ef97acf8148789f8ab460e1e48a3e1","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-03-26 09:29:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"89b115d54b5c815b00cd609bf3e267dd5a398b41","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-26 09:52:28.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/80010\n","accounts_in_message":[],"_revision_number":2},{"id":"57591bdf9409a3c028b86af754ead5d765fa5602","author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"date":"2013-03-26 09:55:14.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"36e1c828758aa44000e9e45db30af7aa1ca401a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 10:06:22.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25317/2/check/gate-swift-pep8/1974 : SUCCESS\n- http://logs.openstack.org/25317/2/check/gate-swift-docs/1804 : SUCCESS\n- http://logs.openstack.org/25317/2/check/gate-swift-python26/2052 : FAILURE\n- http://logs.openstack.org/25317/2/check/gate-swift-python26-rhel6/28 : FAILURE (non-voting)\n- http://logs.openstack.org/25317/2/check/gate-swift-python27/2054 : SUCCESS\n- http://logs.openstack.org/25317/2/check/gate-tempest-devstack-vm-full/10475 : SUCCESS\n- http://logs.openstack.org/25317/2/check/gate-tempest-devstack-vm-quantum/16020 : SUCCESS\n- http://logs.openstack.org/25317/2/check/gate-tempest-devstack-vm-postgres-full/10191 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"f5e6e74864ed264d4a10dafac2984efcae839812","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-03-26 10:49:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"08b63dca2075bc940ddcb8dee032f2b7a2f72340","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-26 11:12:05.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/80020\n","accounts_in_message":[],"_revision_number":3},{"id":"c56ad55722d569756b0cfca960dbb29b462711a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-26 11:27:03.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25317/3/check/gate-swift-pep8/1977 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-swift-docs/1807 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-swift-python26/2055 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-swift-python26-rhel6/30 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/3/check/gate-swift-python27/2057 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-tempest-devstack-vm-full/10484 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-tempest-devstack-vm-quantum/16031 : SUCCESS\n- http://logs.openstack.org/25317/3/check/gate-tempest-devstack-vm-postgres-full/10200 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"f0dd1995cba2890ea2b51f8ce4cc91a624b890bc","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-03-26 16:58:55.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nAlright, code looks reasonable to me.\n\nI don\u0027t know if it\u0027s required to answer HEAD or OPTIONS requests for /crossdomain.xml, but if it is, you\u0027ll need to add that support in. (I seriously have no idea. Please tell me if you think it\u0027s necessary or not. I have no idea what Flash or Silverlight do with this thing.)\n\nHowever, this does need some documentation. Could you update etc/proxy-server.conf.sample and doc/source/misc.rst with entries for this new middleware?\n\nThanks.","accounts_in_message":[],"_revision_number":3},{"id":"eba339a5c326be39bd82d139a73cef054199f350","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-03-26 18:28:34.000000000","message":"Patch Set 3:\n\nWrt documentation, different middleware seem to do it differently. However, I agree I picked the least-effort route. I\u0027ll do a proper job.\n\nWrt CORS, OPTIONS, my knowledge is a bit sparse. I\u0027m not actually the original author. We have it in production and I\u0027m submitting it largely to make our life easier but also in the hope someone finds it useful. I\u0027ll dig a little deeper and include justification and usage in the documentation.\n\nHowever, my mental model is that rossdomain.xml  is an early solution designed specifically for Flash to handle the cross-domain problem. Others picked it up and used the same mechanism. CORS came later, and is specific to HTML5. We can\u0027t simply rely on CORS since there are lots of legacy browsers out there.","accounts_in_message":[],"_revision_number":3},{"id":"16445ff69a0e2f148dc410bdaa9a9d04ddf05fe9","author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"date":"2013-03-27 10:06:46.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"238500d293725db99d7f5970f7ca79e6cde485d4","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-02 14:53:15.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"de5e335faec3f8c4f8553234ed05560973beaf53","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-02 14:54:23.000000000","message":"Patch Set 4:\n\nAdded crossdomain.rst as documentation; otherwise no other changes.","accounts_in_message":[],"_revision_number":4},{"id":"af0d3b45ab05d378e00d49d1c0e3ed041a97acf1","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-02 15:17:11.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/81123\n","accounts_in_message":[],"_revision_number":4},{"id":"86309bf2449e2878861c399e8b758f67bf4f2bd3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-02 15:34:17.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25317/4/check/gate-swift-pep8/2036 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-swift-docs/1866 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-swift-python26/2114 : FAILURE\n- http://logs.openstack.org/25317/4/check/gate-swift-python26-rhel6/70 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/4/check/gate-swift-python27/2116 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-full/11254 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-quantum/16933 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-postgres-full/10970 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"4b180cdfdf446b44d7728e92d9fcbe287f84a96b","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-04-04 23:11:19.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"ce71e9f629e4ce60b3210af4ceda29c8618c5bd1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-04 23:52:19.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25317/4/check/gate-swift-pep8/2074 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-swift-docs/1902 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-swift-python26/2150 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-swift-python26-rhel6/97 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/4/check/gate-swift-python27/2152 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-full/11673 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-quantum/17407 : SUCCESS\n- http://logs.openstack.org/25317/4/check/gate-tempest-devstack-vm-postgres-full/11388 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"ad8c978f29891e89723c9e7b1123ca7b710814b8","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-04-05 00:08:50.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nNeeds an entry in setup.py to make the paste-deploy stuff work.\n\nI added this in with the rest of the filter_factory stuff:\n\n            \u0027crossdomain\u003dswift.common.middleware.crossdomain:\u0027\n            \u0027filter_factory\u0027,\n\nand then it worked as expected.\n\nSo yeah, fix that, and maybe some of these typos if you feel like it, and I think it\u0027ll be good.","accounts_in_message":[],"_revision_number":4},{"id":"e6b9d5e21306a4d1cfce08c991ab00e9fd036377","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-05 10:00:54.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"bc76977d720e0934ea8f28b2623c155a9a690acd","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-05 10:06:17.000000000","message":"Patch Set 5:\n\nFixed typos.\nFixed past-deploy.","accounts_in_message":[],"_revision_number":5},{"id":"521cddd5be8c410eba3fc46db27d1804a195a227","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-05 10:24:13.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/81681\n","accounts_in_message":[],"_revision_number":5},{"id":"09d6cc257701375ce220195a4ec156e41f94216c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-05 10:40:54.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25317/5/check/gate-swift-pep8/2077 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-swift-docs/1905 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-swift-python26/2153 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-swift-python26-rhel6/100 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/5/check/gate-swift-python27/2155 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-tempest-devstack-vm-full/11704 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-tempest-devstack-vm-quantum/17456 : SUCCESS\n- http://logs.openstack.org/25317/5/check/gate-tempest-devstack-vm-postgres-full/11419 : FAILURE\n","accounts_in_message":[],"_revision_number":5},{"id":"6297030564c8e21bff623c1a3dfd8e292b9f8f24","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-12 08:13:38.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"1d82de0b3eae633f67ee4606b7a099365cf6873b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-12 08:36:55.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/82780\n","accounts_in_message":[],"_revision_number":6},{"id":"982103334e0351bfd41a786862e82058ee4428f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-12 08:56:40.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25317/6/check/gate-swift-pep8/2122 : SUCCESS\n- http://docs-draft.openstack.org/25317/6/check/gate-swift-docs/1950/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-swift-python26/2198 : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-swift-python26-rhel6/139 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/6/check/gate-swift-python27/2200 : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-tempest-devstack-vm-full/12441 : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-tempest-devstack-vm-quantum/18286 : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-tempest-devstack-vm-postgres-full/12156 : SUCCESS\n- http://logs.openstack.org/25317/6/check/gate-grenade-devstack-vm/396 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"e0b851f7105e43b1d77e7cc632aaf9ddf194d282","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-04-23 00:15:24.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"62c44c3c13606d0b5cf9b87e72363ab715963cc4","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-04-23 06:11:52.000000000","message":"Patch Set 6: (1 inline comment)\n\nit may be useful to add the secure\u003dtrue/false option (it can be a middleware setting)","accounts_in_message":[],"_revision_number":6},{"id":"e16570fe7935881f6a0166d665ecaa4a8c38ad76","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-23 12:49:20.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"cae79d9edb09014ee73abf1a275aa6c6d3753654","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-23 12:52:47.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"dbcecf7d2ba669fc94345c3dd7dac8ab3b11e81a","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-04-23 12:52:53.000000000","message":"Patch Set 8:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":8},{"id":"0eab5a1b5401cac8aaa69d69cfaad491c9eafc86","author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"date":"2013-04-23 12:59:10.000000000","message":"Patch Set 8:\n\nChmouel\u0027s comment made me realise that I was hardcoding something useful for a large site with unknown clients and unknown CNAME aliases for the endpoint.\n\nI\u0027ve allowed you to specify your own policy. This makes it more useful for private or dedicated deployments. I should have done this from the beginning.\n\nUpdated middleware, test and documentation.","accounts_in_message":[],"_revision_number":8},{"id":"86bed173d20dd27470ccaead705bce5c931a96ca","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-23 13:15:04.000000000","message":"Patch Set 8: Works for me\n\nSmokeStack Results (patch set 8):\n\tXenServer 5.6 (F18 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/84164\n","accounts_in_message":[],"_revision_number":8},{"id":"a5180abc087bd99eda16c41442742efd0f6f2a37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-23 13:36:45.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25317/8/check/gate-swift-pep8/2182 : SUCCESS\n- http://docs-draft.openstack.org/25317/8/check/gate-swift-docs/2010/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-swift-python26/2258 : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-swift-python26-rhel6/184 : SUCCESS (non-voting)\n- http://logs.openstack.org/25317/8/check/gate-swift-python27/2260 : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-tempest-devstack-vm-full/13314 : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-tempest-devstack-vm-quantum/19242 : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-tempest-devstack-vm-postgres-full/13029 : SUCCESS\n- http://logs.openstack.org/25317/8/check/gate-grenade-devstack-vm/1195 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"7c61ef289efef22809c976430f3eff0a9cc6bc1d","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-04-27 05:08:26.000000000","message":"Patch Set 8: Looks good to me (core reviewer)\n\n(1 inline comment)\n\nOne tiny typo in a comment, but otherwise LGTM. I won\u0027t hold up the review over a comment typo.","accounts_in_message":[],"_revision_number":8},{"id":"b0e61025ed94fa643d7376257a839ffbecba507c","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2013-04-27 08:12:06.000000000","message":"Patch Set 8: Looks good to me (core reviewer); Approved\n\ncool we can now have some xml in our swift configuration file ;)","accounts_in_message":[],"_revision_number":8},{"id":"fe42f87be6de05e498fdc5ae942950ad84919431","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-27 08:12:08.000000000","message":"Patch Set 8: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":8},{"id":"67a8f16699cf74c16603b4b2e27832e0004d794b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-27 08:56:19.000000000","message":"Patch Set 8: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/25317/8/gate/gate-swift-docs/2055/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-swift-pep8/2227 : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-swift-python26/2303 : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-swift-python27/2305 : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-tempest-devstack-vm-full/13775 : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-tempest-devstack-vm-quantum/19756 : SUCCESS\n- http://logs.openstack.org/25317/8/gate/gate-tempest-devstack-vm-postgres-full/13490 : FAILURE (non-voting)\n- http://logs.openstack.org/25317/8/gate/gate-grenade-devstack-vm/1618 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"c43a2cfc04113c149c6f32458397563f5e3741bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-27 08:56:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"eb4b29d243150d2f348d163ecc2fb552675891bf","revisions":{"6ea317afbee6440496849f670203295a8201311f":{"kind":"REWORK","_number":1,"created":"2013-03-25 18:49:13.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/1"}}},"commit":{"parents":[{"commit":"a979c8007bf7376541c932c3e91d5ba1a95f4481","subject":"Add support for Hash Prefix","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a979c8007bf7376541c932c3e91d5ba1a95f4481"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running on web pages served elsewhere cannot interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6ea317afbee6440496849f670203295a8201311f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6ea317afbee6440496849f670203295a8201311f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a979c8007bf7376541c932c3e91d5ba1a95f4481","is_merged_in_target_branch":true,"change_id":"I63b10d0b7d6dd3f74e0f10bb41b5f240fa03578a","change_number":24858,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"e9cef046d8359e8e209be28406fe7b4281729761":{"kind":"REWORK","_number":2,"created":"2013-03-26 09:29:07.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/2"}}},"commit":{"parents":[{"commit":"a979c8007bf7376541c932c3e91d5ba1a95f4481","subject":"Add support for Hash Prefix","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a979c8007bf7376541c932c3e91d5ba1a95f4481"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-26 09:28:13.000000000","tz":0},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e9cef046d8359e8e209be28406fe7b4281729761"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e9cef046d8359e8e209be28406fe7b4281729761"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a979c8007bf7376541c932c3e91d5ba1a95f4481","is_merged_in_target_branch":true,"change_id":"I63b10d0b7d6dd3f74e0f10bb41b5f240fa03578a","change_number":24858,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"45afe1aad9a8ab011761434cf16773e1659fbbde":{"kind":"REWORK","_number":3,"created":"2013-03-26 10:49:39.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/3"}}},"commit":{"parents":[{"commit":"a979c8007bf7376541c932c3e91d5ba1a95f4481","subject":"Add support for Hash Prefix","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a979c8007bf7376541c932c3e91d5ba1a95f4481"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-26 10:49:36.000000000","tz":0},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/45afe1aad9a8ab011761434cf16773e1659fbbde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/45afe1aad9a8ab011761434cf16773e1659fbbde"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a979c8007bf7376541c932c3e91d5ba1a95f4481","is_merged_in_target_branch":true,"change_id":"I63b10d0b7d6dd3f74e0f10bb41b5f240fa03578a","change_number":24858,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"0e5cef2fb1a5f17376f79dc4c22a10a8d94be7a0":{"kind":"REWORK","_number":4,"created":"2013-04-02 14:53:15.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/4"}}},"commit":{"parents":[{"commit":"ba5a0b0fe15fe129ed6df8cca2c2baac0a31bdde","subject":"Merge \"Change logger name to module itself instead of root\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ba5a0b0fe15fe129ed6df8cca2c2baac0a31bdde"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-04-02 14:53:20.000000000","tz":60},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0e5cef2fb1a5f17376f79dc4c22a10a8d94be7a0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0e5cef2fb1a5f17376f79dc4c22a10a8d94be7a0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"ba5a0b0fe15fe129ed6df8cca2c2baac0a31bdde","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"fbbea66f9150b4cfe2a54cfd177718e0c34e59cc":{"kind":"REWORK","_number":5,"created":"2013-04-05 10:00:54.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/5"}}},"commit":{"parents":[{"commit":"48a94f39ddfa183c876b87dd27b84354977ee4fb","subject":"Merge \"Allow a configurable set of TempURL methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/48a94f39ddfa183c876b87dd27b84354977ee4fb"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-04-05 10:00:57.000000000","tz":60},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fbbea66f9150b4cfe2a54cfd177718e0c34e59cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fbbea66f9150b4cfe2a54cfd177718e0c34e59cc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"48a94f39ddfa183c876b87dd27b84354977ee4fb","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"f409267b2c15aea6781efc888182e5e5de3a1188":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2013-04-12 08:13:38.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/6"}}},"commit":{"parents":[{"commit":"4ae0feb60d091d0271bf461cba13482cb3d7a261","subject":"Merge \"Account Quota Correction\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ae0feb60d091d0271bf461cba13482cb3d7a261"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-04-12 08:13:42.000000000","tz":60},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f409267b2c15aea6781efc888182e5e5de3a1188"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f409267b2c15aea6781efc888182e5e5de3a1188"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4ae0feb60d091d0271bf461cba13482cb3d7a261","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"21c2d9e5c7df519b515ea3a06ca7321c77ba20d9":{"kind":"REWORK","_number":7,"created":"2013-04-23 12:49:20.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/7"}}},"commit":{"parents":[{"commit":"7f534fac389877e32c593e5c78edfaeca8e68420","subject":"fix dict duplicated key remove duplicated key from swift-bench bin; and also add .idea to gitignore","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7f534fac389877e32c593e5c78edfaeca8e68420"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-04-23 12:49:18.000000000","tz":60},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/21c2d9e5c7df519b515ea3a06ca7321c77ba20d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/21c2d9e5c7df519b515ea3a06ca7321c77ba20d9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"7f534fac389877e32c593e5c78edfaeca8e68420","is_merged_in_target_branch":true,"change_id":"I31360489716d03324b8d2bb1c51e282393069c13","change_number":27237,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"eb4b29d243150d2f348d163ecc2fb552675891bf":{"kind":"REWORK","_number":8,"created":"2013-04-23 12:52:47.000000000","uploader":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"ref":"refs/changes/17/25317/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/17/25317/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/17/25317/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/17/25317/8"}}},"commit":{"parents":[{"commit":"7f534fac389877e32c593e5c78edfaeca8e68420","subject":"fix dict duplicated key remove duplicated key from swift-bench bin; and also add .idea to gitignore","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7f534fac389877e32c593e5c78edfaeca8e68420"}]}],"author":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-03-25 18:48:25.000000000","tz":0},"committer":{"name":"Donagh McCabe","email":"donagh.mccabe@hp.com","date":"2013-04-23 12:52:34.000000000","tz":60},"subject":"Add crossdomain.xml middleware","message":"Add crossdomain.xml middleware\n\nAllows client-side technologies such as Flash, Java and Silverlight running\non web pages served elsewhere to interact with the Swift API.\n\nBug #1159960\n\nChange-Id: I7d0533a0aaf189ac452abbd983469acb064fdca4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/eb4b29d243150d2f348d163ecc2fb552675891bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/eb4b29d243150d2f348d163ecc2fb552675891bf"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"7f534fac389877e32c593e5c78edfaeca8e68420","is_merged_in_target_branch":true,"change_id":"I31360489716d03324b8d2bb1c51e282393069c13","change_number":27237,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}