)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"de92ee65b5d139dc1938956830b65377da11e7b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix full_listing in internal_client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The internal_client is used in swift-dispersion-report, and in case one has more"},{"line_number":10,"context_line":"than 10.000 containers or objects these are not queried."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds support to the internal_client to iterate over all"},{"line_number":13,"context_line":"containers/objects if the listing exceeds the default of 10.000 entries and the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_c0f4f5f1","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":11},"updated":"2015-12-22 12:05:02.000000000","message":"Which does the word \"10.000\" mean \"ten\" or \"ten thousand\" ?\nIf it means \"ten thousand\", I think \"10,000\" is better.","commit_id":"f6dc2d774edea5e6f06c55b19b12ab1e9873d53e"}],"swift/common/internal_client.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b81fc54b8eb5f47417b854c2e5bcd7550f26a70a","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                                            marker\u003dmarker)[1]"},{"line_number":758,"context_line":"                if listing:"},{"line_number":759,"context_line":"                    body_data[1].extend(listing)"},{"line_number":760,"context_line":"            return body_data"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        if headers is None:"},{"line_number":763,"context_line":"            headers \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_6fb4a6d0","line":760,"updated":"2015-12-18 01:45:59.000000000","message":"My only worry here is if internal client it used on a very large container (say one yet to be sharded) then this list could get very long and take up a _lot_ of memory.\n\nSo would rather dispersion report to query in CONTAINER_LISTING_LIMIT chunks.\n\nThough this might just have to be something to be wary about when using full_listing. But thought I\u0027d mention it.","commit_id":"f6dc2d774edea5e6f06c55b19b12ab1e9873d53e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6209063c64022e39171bdd7d8ada2492ba4b5f69","unresolved":false,"context_lines":[{"line_number":747,"context_line":"        url \u003d self.url"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        if full_listing:"},{"line_number":750,"context_line":"            body_data \u003d self.base_request(method, container, name, prefix,"},{"line_number":751,"context_line":"                                          headers, proxy, timeout\u003dtimeout,"},{"line_number":752,"context_line":"                                          marker\u003dmarker)"},{"line_number":753,"context_line":"            listing \u003d body_data[1]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_c89129f3","line":750,"updated":"2016-03-23 21:02:57.000000000","message":"the return value from base_request is very strange but the first value of the tuple is about to get populated (See https://review.openstack.org/#/c/270961/14/swift/common/internal_client.py)\n\nI would prefer to see:\n\n  info, body_data \u003d self.base_request(...\n\nand then not have the [1] index after body_data in rest of this clause.","commit_id":"c76a7aa470a9a2878159ede534774dca47bcd712"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6209063c64022e39171bdd7d8ada2492ba4b5f69","unresolved":false,"context_lines":[{"line_number":758,"context_line":"                                            marker\u003dmarker)[1]"},{"line_number":759,"context_line":"                if listing:"},{"line_number":760,"context_line":"                    body_data[1].extend(listing)"},{"line_number":761,"context_line":"            return body_data"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"        if headers is None:"},{"line_number":764,"context_line":"            headers \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_c87f69a9","line":761,"updated":"2016-03-23 21:02:57.000000000","message":"as comment above, return info, body_data\n\nif nothing else it is less confusing when looking at the return value at line 818","commit_id":"c76a7aa470a9a2878159ede534774dca47bcd712"}],"test/unit/common/test_internal_client.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"e7bc7928754712021ab3bd1112a90b9e7235ecab","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                FakeConn(body1), FakeConn(body2), FakeConn(body3)]"},{"line_number":371,"context_line":"            sc \u003d internal_client.SimpleClient(\u0027http://0.0.0.0/\u0027)"},{"line_number":372,"context_line":"            _, resp_body \u003d sc.base_request(\u0027GET\u0027, full_listing\u003dTrue)"},{"line_number":373,"context_line":"            self.assertEqual(body1 + body2, resp_body)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def test_make_request_method_path_headers(self):"},{"line_number":376,"context_line":"        class InternalClient(internal_client.InternalClient):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_61a16ca3","line":373,"updated":"2016-03-22 15:41:23.000000000","message":"nit: assert can be outside of mock","commit_id":"c76a7aa470a9a2878159ede534774dca47bcd712"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6209063c64022e39171bdd7d8ada2492ba4b5f69","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                FakeConn(body1), FakeConn(body2), FakeConn(body3)]"},{"line_number":371,"context_line":"            sc \u003d internal_client.SimpleClient(\u0027http://0.0.0.0/\u0027)"},{"line_number":372,"context_line":"            _, resp_body \u003d sc.base_request(\u0027GET\u0027, full_listing\u003dTrue)"},{"line_number":373,"context_line":"            self.assertEqual(body1 + body2, resp_body)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def test_make_request_method_path_headers(self):"},{"line_number":376,"context_line":"        class InternalClient(internal_client.InternalClient):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_2eb70df6","line":373,"in_reply_to":"fa0719c6_61a16ca3","updated":"2016-03-23 21:02:57.000000000","message":"Nothing verifies that the correct marker is sent - so i can remove marker from base_request calls and test still passes.","commit_id":"c76a7aa470a9a2878159ede534774dca47bcd712"}]}