)]}'
{"swift/common/middleware/keystoneauth.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"bbcafd7603c10f438ff140d5261d6fcb2c3bd4f4","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                                                              \u0027swiftoperator\u0027],"},{"line_number":181,"context_line":"                                              service_roles\u003d[]))"},{"line_number":182,"context_line":"        self.reseller_admin_role \u003d conf.get(\u0027reseller_admin_role\u0027,"},{"line_number":183,"context_line":"                                            \u0027ResellerAdmin\u0027).lower()"},{"line_number":184,"context_line":"        config_overrides \u003d conf.get(\u0027allow_overrides\u0027, \u0027t\u0027).lower()"},{"line_number":185,"context_line":"        self.allow_overrides \u003d swift_utils.config_true_value(config_overrides)"},{"line_number":186,"context_line":"        self.default_domain_id \u003d conf.get(\u0027default_domain_id\u0027, \u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a57f1b5_f215f848","line":183,"updated":"2016-02-10 18:31:07.000000000","message":"I think we should log a warning if the conf option is found to be set. Something like:\n\n  config_is_admin \u003d conf.get(\u0027is_admin\u0027, \"false\").lower()\n  if swift_utils.config_true_value(config_is_admin):\n     self.logger.warning(\"The \u0027is_admin\u0027 option for keystoneauth is no longer supported. Remove the \u0027is_admin\u0027 option from your keystoneauth config\")","commit_id":"c57423c6d8fc18835749c32b47e0371891b21bec"}],"test/unit/common/middleware/test_keystoneauth.py":[{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"6a50282cbdaf049f35119f853ccbc9488bcec648","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity)"},{"line_number":648,"context_line":"        self.assertTrue(req.environ.get(\u0027swift_owner\u0027))"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def _check_authorize_for_tenant_owner_match(self, exception\u003dNone):"},{"line_number":651,"context_line":"        identity \u003d self._get_identity(user_name\u003d\u0027same_name\u0027,"},{"line_number":652,"context_line":"                                      tenant_name\u003d\u0027same_name\u0027)"},{"line_number":653,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity, exception\u003dexception)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_a1137db7","line":650,"updated":"2015-12-16 10:39:04.000000000","message":"BTW: If you remove test_authorize_fails_as_owner_for_tenant_owner_match(), you should have removed _check_authorize_for_tenant_owner_match(). However, as mentioned below, I think you should keep (or incorporate)","commit_id":"c1b650857a9273ef25a4802f138939a62d88b8f0"},{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"bcce3a2f533d20b24c7b92e1d3fa7db52d903ef5","unresolved":false,"context_lines":[{"line_number":653,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity, exception\u003dexception)"},{"line_number":654,"context_line":"        expected \u003d bool(exception is None)"},{"line_number":655,"context_line":"        self.assertEqual(bool(req.environ.get(\u0027swift_owner\u0027)), expected)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def test_authorize_succeeds_for_container_sync(self):"},{"line_number":658,"context_line":"        env \u003d {\u0027swift_sync_key\u0027: \u0027foo\u0027, \u0027REMOTE_ADDR\u0027: \u0027127.0.0.1\u0027}"},{"line_number":659,"context_line":"        headers \u003d {\u0027x-container-sync-key\u0027: \u0027foo\u0027, \u0027x-timestamp\u0027: \u00271\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_216a2db4","line":656,"updated":"2015-12-16 10:35:27.000000000","message":"I agree -- remove test_authorize_succeeds_as_owner_for_tenant_owner_match().\n\nHowever, you should rewrite/rename test_authorize_fails_as_owner_for_tenant_owner_match() by removing original line 662 (since you no longer get this from the conf file).","commit_id":"c1b650857a9273ef25a4802f138939a62d88b8f0"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"182fb91e1dd701afc12fec1bc63aa4191631398c","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity)"},{"line_number":648,"context_line":"        self.assertTrue(req.environ.get(\u0027swift_owner\u0027))"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"    def test_authorize_fails_same_user_and_tenant(self):"},{"line_number":651,"context_line":"        identity \u003d self._get_identity(user_name\u003d\u0027same_name\u0027,"},{"line_number":652,"context_line":"                                      tenant_name\u003d\u0027same_name\u0027)"},{"line_number":653,"context_line":"        req \u003d self._check_authenticate(identity\u003didentity,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a57f1b5_9a05967b","line":650,"updated":"2016-02-11 10:53:12.000000000","message":"Hmmm, this test passes on master. In the future, when \u0027future us\u0027 has forgotten that is_admin ever existed, this test will look strange (why test this one combination?). However, I *do* think there is value in testing that the is_admin behaviour no longer works.\n\nSo could you add a comment that this test is checking that the removed is_admin feature no longer works, and perhaps include:\n\n  self.test_auth.is_admin \u003d True","commit_id":"b74f52f2a4d05495c671a525f9dbb3da4c5d7578"}]}