)]}'
{"bin/swift-drive-audit":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"61e0c9d0b5471db9d61afcab3c9efe320dc2dc2d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        comment_fstab(mount_point)"},{"line_number":202,"context_line":"                        unmounts +\u003d 1"},{"line_number":203,"context_line":"                    else:"},{"line_number":204,"context_line":"                        logger.error(\"Detected %s with %d errors \""},{"line_number":205,"context_line":"                                     \"(Skip failed device unmounting)\" %"},{"line_number":206,"context_line":"                                     (mount_point, count))"},{"line_number":207,"context_line":"                    recon_errors[mount_point] \u003d count"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a5ae5dd_55cbc11e","line":204,"updated":"2016-02-09 20:21:44.000000000","message":"I\u0027d prefer this to be info level, just the same as if the device does get unmounted. It\u0027s not an error to have chosen unmount_failed_device\u003dFalse.","commit_id":"eb1964ef0e8b2551d92cc38f46942f6e47b1db0b"},{"author":{"_account_id":18639,"name":"Marek Kaleta","email":"mk@m1k.cz","username":"mara"},"change_message_id":"564ca77c79cdb9a85e298b5ff6b2cbd06e3d387c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        unmounts +\u003d 1"},{"line_number":203,"context_line":"                    else:"},{"line_number":204,"context_line":"                        logger.error(\"Detected %s with %d errors \""},{"line_number":205,"context_line":"                                     \"(Skip failed device unmounting)\" %"},{"line_number":206,"context_line":"                                     (mount_point, count))"},{"line_number":207,"context_line":"                    recon_errors[mount_point] \u003d count"},{"line_number":208,"context_line":"                    total_errors +\u003d count"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fa69d971_77597a8d","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":69},"updated":"2016-01-06 08:55:23.000000000","message":"I think better formulation would be \"(Device not unmounted, not configured to unmount failed device)\"","commit_id":"eb1964ef0e8b2551d92cc38f46942f6e47b1db0b"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"52637c10094b1d080e3e75b3ff02a4a3bc33a86f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        unmounts +\u003d 1"},{"line_number":203,"context_line":"                    else:"},{"line_number":204,"context_line":"                        logger.error(\"Detected %s with %d errors \""},{"line_number":205,"context_line":"                                     \"(Skip failed device unmounting)\" %"},{"line_number":206,"context_line":"                                     (mount_point, count))"},{"line_number":207,"context_line":"                    recon_errors[mount_point] \u003d count"},{"line_number":208,"context_line":"                    total_errors +\u003d count"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a57f1b5_20e76f12","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":69},"in_reply_to":"5a5ae5dd_552f41f6","updated":"2016-02-11 22:11:32.000000000","message":"Done","commit_id":"eb1964ef0e8b2551d92cc38f46942f6e47b1db0b"},{"author":{"_account_id":16896,"name":"Ondřej Nový","email":"novy@ondrej.org","username":"onovy"},"change_message_id":"52637c10094b1d080e3e75b3ff02a4a3bc33a86f","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        unmounts +\u003d 1"},{"line_number":203,"context_line":"                    else:"},{"line_number":204,"context_line":"                        logger.error(\"Detected %s with %d errors \""},{"line_number":205,"context_line":"                                     \"(Skip failed device unmounting)\" %"},{"line_number":206,"context_line":"                                     (mount_point, count))"},{"line_number":207,"context_line":"                    recon_errors[mount_point] \u003d count"},{"line_number":208,"context_line":"                    total_errors +\u003d count"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a57f1b5_60e007fb","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":69},"in_reply_to":"fa69d971_77597a8d","updated":"2016-02-11 22:11:32.000000000","message":"Done","commit_id":"eb1964ef0e8b2551d92cc38f46942f6e47b1db0b"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"61e0c9d0b5471db9d61afcab3c9efe320dc2dc2d","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                        unmounts +\u003d 1"},{"line_number":203,"context_line":"                    else:"},{"line_number":204,"context_line":"                        logger.error(\"Detected %s with %d errors \""},{"line_number":205,"context_line":"                                     \"(Skip failed device unmounting)\" %"},{"line_number":206,"context_line":"                                     (mount_point, count))"},{"line_number":207,"context_line":"                    recon_errors[mount_point] \u003d count"},{"line_number":208,"context_line":"                    total_errors +\u003d count"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a5ae5dd_552f41f6","line":205,"range":{"start_line":205,"start_character":38,"end_line":205,"end_character":69},"in_reply_to":"fa69d971_77597a8d","updated":"2016-02-09 20:21:44.000000000","message":"I agree the second part of the message could be worded better. This could be interpreted as \"skip because unmounting the device failed\".\n\nFor me \"Detected %s with %d errors. (Device not unmounted.)\" would be sufficient.","commit_id":"eb1964ef0e8b2551d92cc38f46942f6e47b1db0b"}]}
