)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"09b2efdd32cb5e7006fc221d1a87ab481dd5b501","unresolved":false,"context_lines":[{"line_number":13,"context_line":"TestObjectVersioning and TestObjectVersioningUTF8 would run them."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Additionally, if versioned_writes was explicitly included in the"},{"line_number":16,"context_line":"proxy-server\u0027s pipeline and allow_versioned_writes was disabled (or not"},{"line_number":17,"context_line":"set), the functional tests would fail with a 412."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Now, all three will use the same logic to check whether versioning is"},{"line_number":20,"context_line":"enabled. Specifically, they will all try to set an X-Versions-Location"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a18252c_1ad47445","line":17,"range":{"start_line":16,"start_character":63,"end_line":17,"end_character":4},"updated":"2016-04-13 08:49:13.000000000","message":"Seems like the functional tests would fail *only when allow_versioned_writes explicitly disabled*. Once I set versioned_writes in the pipline and comment out allow_versioned_writes, all three tests works well (run and result in ok)\n\nI know the statement is too complicated but looking at my refacor patch[1][2], if no configure for \"allow_versioned_writes\" (included just commented out), the middleware will handle the request as if old style versioned writes.\n\n1: https://review.openstack.org/#/c/209315/8/swift/common/middleware/versioned_writes.py@488\n2: https://review.openstack.org/#/c/209315/8/swift/common/middleware/versioned_writes.py@517","commit_id":"69b6d13b197d7bfefcdacd8b3f0c7904dc8f005f"}],"test/functional/tests.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"83e368ce7cf94340828d1422c9ff9f81635783f2","unresolved":false,"context_lines":[{"line_number":3298,"context_line":"        if not cls.container.create("},{"line_number":3299,"context_line":"                hdrs\u003d{\u0027X-Versions-Location\u0027: cls.versions_container.name,"},{"line_number":3300,"context_line":"                      \u0027X-Storage-Policy\u0027: version_policy[\u0027name\u0027]}):"},{"line_number":3301,"context_line":"            raise ResponseError(cls.conn.response)"},{"line_number":3302,"context_line":""},{"line_number":3303,"context_line":"        container_info \u003d cls.container.info()"},{"line_number":3304,"context_line":"        # if versioning is off, then X-Versions-Location won\u0027t persist"}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_5b97b139","line":3301,"updated":"2016-02-17 18:09:47.000000000","message":"tests are failing here when \u0027allow_versioned_writes \u003d false\u0027","commit_id":"e3e2b83154bfbc0c0c449e9c57f89c72c5462b81"}]}