)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f6a3ac3f9b6429ff14637e5d8319080b89da3e60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fail early if the memcache address is invalid."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In cases when the memcache address is invalid, we should fail early."},{"line_number":10,"context_line":"This patch addresses the cases when the IPv6 addresses are not"},{"line_number":11,"context_line":"enclosed in \"[]\". It does not, however, fix the case of an invalid"},{"line_number":12,"context_line":"hostname. These improvements could also be added to the _get_addr()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_087ce670","line":9,"updated":"2016-01-09 00:29:46.000000000","message":"+10000000","commit_id":"92ebc140a401598680e8e9fb6d0692cac903c646"}],"swift/common/memcached.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f6a3ac3f9b6429ff14637e5d8319080b89da3e60","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.host, self.port \u003d self._get_addr(server)"},{"line_number":126,"context_line":"        self._connect_timeout \u003d connect_timeout"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _get_addr(self, server):"},{"line_number":129,"context_line":"        port \u003d DEFAULT_MEMCACHED_PORT"},{"line_number":130,"context_line":"        # IPv6 addresses must be between \u0027[]\u0027"},{"line_number":131,"context_line":"        if server.startswith(\u0027[\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_88b9b630","line":128,"updated":"2016-01-09 00:29:46.000000000","message":"I think this is pretty obviously a pure function at this point - you should extract it while your at it IMHO","commit_id":"92ebc140a401598680e8e9fb6d0692cac903c646"}],"test/unit/common/test_memcached.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f6a3ac3f9b6429ff14637e5d8319080b89da3e60","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        with self.assertRaises(ValueError):"},{"line_number":232,"context_line":"            # IPv6 address with missing [] is invalid"},{"line_number":233,"context_line":"            server_socket \u003d \u0027%s:%s\u0027 % (\u0027::1\u0027, 11211)"},{"line_number":234,"context_line":"            memcache_client \u003d memcached.MemcacheRing([server_socket])"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_get_conns_hostname(self):"},{"line_number":237,"context_line":"        with patch(\u0027swift.common.memcached.socket.getaddrinfo\u0027) as addrinfo:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_28a8cada","line":234,"updated":"2016-01-09 00:29:46.000000000","message":"assigned but not used","commit_id":"92ebc140a401598680e8e9fb6d0692cac903c646"}]}