)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":13297,"name":"Alan Erwin","email":"alan.erwin@rackspace.com","username":"aerwin3"},"change_message_id":"08bfa9c8add81bbe7559f2fb21356074940d5a0a","unresolved":false,"context_lines":[{"line_number":477,"context_line":"                if isinstance(info[key], six.text_type):"},{"line_number":478,"context_line":"                    info[key] \u003d info[key].encode(\"utf-8\")"},{"line_number":479,"context_line":"                if isinstance(info[key], dict):"},{"line_number":480,"context_line":"                    for subkey, value in info.get(key, {}).items():"},{"line_number":481,"context_line":"                        if isinstance(value, six.text_type):"},{"line_number":482,"context_line":"                            info[key][subkey] \u003d value.encode(\"utf-8\")"},{"line_number":483,"context_line":"            env[env_key] \u003d info"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_f356b7cc","line":480,"updated":"2016-01-25 19:06:42.000000000","message":"Is there a reason for using .get on the info? By doing the isinstance on info[key] the result is required to be a dict and to exist. Why not just be info[key].items()?","commit_id":"e7bbe606dd19d398842e3b69526df8e213385a57"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"5dbdf4a775053e28fa9d6807c470c854413a20ba","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    def test_get_info_cache_returns_values_as_strings(self):"},{"line_number":685,"context_line":"        app \u003d mock.MagicMock()"},{"line_number":686,"context_line":"        app.memcache \u003d mock.MagicMock()"},{"line_number":687,"context_line":"        app.memcache.get \u003d mock.MagicMock("},{"line_number":688,"context_line":"            return_value\u003d{u\u0027foo\u0027: u\u0027\\u2603\u0027, u\u0027meta\u0027: {u\u0027bar\u0027: u\u0027\\u2603\u0027}})"},{"line_number":689,"context_line":"        env \u003d {}"},{"line_number":690,"context_line":"        r \u003d _get_info_cache(app, env, \u0027account\u0027, \u0027container\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_5577709f","line":687,"range":{"start_line":687,"start_character":27,"end_line":687,"end_character":41},"updated":"2016-01-25 17:04:09.000000000","message":"nit: if you wanted, you could also do this as\n\n app.memcache.get.return_value \u003d { ... }","commit_id":"c79ba811d22eccb052d4299ced1ddc20f82c04b4"}]}