)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"ffa759705a3689102184d90ed0463f2ff8742864","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            print(\u0027    %s\u0027 % format_device(dev))"},{"line_number":195,"context_line":"        if input(\u0027Are you sure you want to \u0027 + input_msg +"},{"line_number":196,"context_line":"                 \u0027 these %s devices? (y/N) \u0027 % len(devs)) !\u003d \u0027y\u0027:"},{"line_number":197,"context_line":"            print(\u0027Aborting device \u0027 + print_msg)"},{"line_number":198,"context_line":"            exit(EXIT_ERROR)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_399dfa59","line":197,"updated":"2016-02-26 17:12:43.000000000","message":"not a big fan of these broken up msgs. How about providing the whole input msg when calling check_devs and in the case of the print_msg maybe we can come up with one single message instead of two very close ones (e.g., \"Aborting device modifications\" and \"Aborting device removals\") or again, maybe just provide the full msg when calling the function","commit_id":"6f5f2c22ecc67193355c4194925c93f0197fccbf"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"ffa759705a3689102184d90ed0463f2ff8742864","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                       format_device(dev)))"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def calculate_change_value(change_value, change, v_name, v_name_port):"},{"line_number":272,"context_line":"    ip \u003d \u0027\u0027"},{"line_number":273,"context_line":"    if change_value and change_value[0].isdigit():"},{"line_number":274,"context_line":"        i \u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_7950225f","line":271,"updated":"2016-02-26 17:12:43.000000000","message":"since we are in refactoring mode... :P\nhow about add some comments to make it easier to understand what\u0027s going on with this function. Both the function and its parameters have vague naming.","commit_id":"6f5f2c22ecc67193355c4194925c93f0197fccbf"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6676ba68af84bf5826a8536565de1d8ae7d79259","unresolved":false,"context_lines":[{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        devs, opts \u003d _parse_remove_values(argv[3:])"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        input_question \u003d \u0027Are you sure you want to update the remove for these \u0027 \\"},{"line_number":761,"context_line":"                         \u0027%s devices? (y/N) \u0027 % len(devs)"},{"line_number":762,"context_line":"        abort_msg \u003d \u0027Aborting device removals\u0027"},{"line_number":763,"context_line":"        check_devs(devs, input_question, opts, abort_msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_f2e9c3b8","line":760,"updated":"2016-07-25 13:52:39.000000000","message":"the question has been messed up","commit_id":"cf961de005782d4a2ed35f53c030f5d927569ecb"}]}