)]}'
{"test/unit/obj/test_server.py":[{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"628f5ed0c98b43edf48823e97f88eb22058b4956","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        del req.headers[\u0027Content-Length\u0027]"},{"line_number":661,"context_line":"        resp \u003d self.object_controller.PUT(req)"},{"line_number":662,"context_line":"        self.assertEquals(resp.status_int, 411)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def test_PUT_zero_content_length(self):"},{"line_number":665,"context_line":"        req \u003d Request.blank(\u0027/sda1/p/a/c/o\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027},"},{"line_number":666,"context_line":"                headers\u003d{\u0027X-Timestamp\u0027: normalize_timestamp(time()),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2F0Jg%3D","line":663,"updated":"2013-04-22 13:27:30.000000000","message":"This test does not test for the case of zero_content_length. It tests for having a content_length different than the body length - which indeed leads to 499 response. \n\nI am not sure what you wanted to test here, but if it is the case of an emapty body, maybe you should do req.body \u003d \u0027\u0027\n\nOtherwise, if you wanted to test against a body length different than teh content_length indicated, please change the test name to reflect this.","commit_id":"a6ecf7af7223ba4b8cd7cf54cc1285855a61af7c"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"fd6ad23b52a04dd370031ade78ab5fc88dcbd60a","unresolved":false,"context_lines":[{"line_number":660,"context_line":"        del req.headers[\u0027Content-Length\u0027]"},{"line_number":661,"context_line":"        resp \u003d self.object_controller.PUT(req)"},{"line_number":662,"context_line":"        self.assertEquals(resp.status_int, 411)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def test_PUT_zero_content_length(self):"},{"line_number":665,"context_line":"        req \u003d Request.blank(\u0027/sda1/p/a/c/o\u0027, environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027PUT\u0027},"},{"line_number":666,"context_line":"                headers\u003d{\u0027X-Timestamp\u0027: normalize_timestamp(time()),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fz68%3D","line":663,"in_reply_to":"AAAAOn%2F%2F0Jg%3D","updated":"2013-04-23 10:59:42.000000000","message":"We have a test called \"test_short_body()\" (test/unit/obj/test_server.py:TestObjectController.test_short_ body), which handles the case of a body length not matching the specified content-length.\n\nThe specific code path that I want to check is to ensure that a mismatched content-length header that is specified as zero is handled properly (see Sam\u0027s comment on https://review.openstack.org/27141, patch set 1).\n\nI will add the suffix, \"_mismatched\" to the test name, and will add an explicit content-length:0 with empty body for good measure.","commit_id":"a6ecf7af7223ba4b8cd7cf54cc1285855a61af7c"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"933e347b4d9f7d9ee52e474e22b331ae0d05742b","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        req.body \u003d \u0027VERIFY\u0027"},{"line_number":678,"context_line":"        req.headers[\u0027Content-Length\u0027] \u003d \u00270\u0027"},{"line_number":679,"context_line":"        resp \u003d self.object_controller.PUT(req)"},{"line_number":680,"context_line":"        self.assertEquals(resp.status_int, 499)"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"    def test_PUT_common(self):"},{"line_number":683,"context_line":"        timestamp \u003d normalize_timestamp(time())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FuVQ%3D","line":680,"updated":"2013-04-26 02:45:18.000000000","message":"That makes no sense.  499 is ClientDisconnect.  This wouldn\u0027t even happen.","commit_id":"960f01b4ba502c01f3433abe37fa95b1e60450f4"}]}