)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"3b0036211e3c8338ea43b45da318281151f78be2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved autocreate testing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"increase testing coverage"},{"line_number":10,"context_line":"make some of the test more accurate"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ide2e0fcb89d5905e70d3111f7ac57b1cff23a99c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2Fwqc%3D","line":9,"updated":"2013-04-24 13:32:08.000000000","message":"Given 70 character lines in git logs, this could probably fit on one line.\n\nAnd can you explain more about the nature of the changes to give some guidance on the unit tests, since it appears there is not much documentation on how they work?","commit_id":"2ee23fb425db7973cc8096b104060bb622706458"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":4499,"context_line":"            test_status_map((200, 404, 404, 404), 404)"},{"line_number":4500,"context_line":"            test_status_map((200, 404, 404, 500), 404)"},{"line_number":4501,"context_line":"            test_status_map((200, 500, 500, 500), 503)"},{"line_number":4502,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":4503,"context_line":"            test_status_map((404, 404, 404), 404)"},{"line_number":4504,"context_line":"            self.app.account_autocreate \u003d True"},{"line_number":4505,"context_line":"            test_status_map((404, 404, 404), 404)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwAQ%3D","line":4502,"updated":"2013-04-24 21:15:20.000000000","message":"This redundant since it should be False by default right? Maybe instead an assert that it is False?","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":4527,"context_line":"                res \u003d controller.POST(req)"},{"line_number":4528,"context_line":"                expected \u003d str(expected)"},{"line_number":4529,"context_line":"                self.assertEquals(res.status[:len(expected)], expected)"},{"line_number":4530,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":4531,"context_line":"            test_status_map((200, 201, 201, 201), 201, missing_container\u003dTrue)"},{"line_number":4532,"context_line":"            test_status_map((200, 201, 201, 500), 201, missing_container\u003dTrue)"},{"line_number":4533,"context_line":"            test_status_map((200, 204, 404, 404), 404, missing_container\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FwAA%3D","line":4530,"updated":"2013-04-24 21:15:20.000000000","message":"Same as above? Just assert False?","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":4532,"context_line":"            test_status_map((200, 201, 201, 500), 201, missing_container\u003dTrue)"},{"line_number":4533,"context_line":"            test_status_map((200, 204, 404, 404), 404, missing_container\u003dTrue)"},{"line_number":4534,"context_line":"            test_status_map((200, 204, 500, 404), 503, missing_container\u003dTrue)"},{"line_number":4535,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":4536,"context_line":"            test_status_map((404, 404, 404), 404, missing_container\u003dTrue)"},{"line_number":4537,"context_line":"            self.app.account_autocreate \u003d True"},{"line_number":4538,"context_line":"            test_status_map((404, 404, 404, 201, 201, 201, 200, 200, 200), 200,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fv%2F8%3D","line":4535,"updated":"2013-04-24 21:15:20.000000000","message":"Same as above? Just assert False?","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":4697,"context_line":"                                   (200, 404, 404, 404), 404)"},{"line_number":4698,"context_line":"            self.assert_status_map(controller.DELETE,"},{"line_number":4699,"context_line":"                                   (200, 204, 503, 404), 503)"},{"line_number":4700,"context_line":"            self.app.account_autocreate \u003d False"},{"line_number":4701,"context_line":"            self.assert_status_map(controller.DELETE,"},{"line_number":4702,"context_line":"                                   (404, 404, 404), 404)"},{"line_number":4703,"context_line":"            self.app.account_autocreate \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fv%2F4%3D","line":4700,"updated":"2013-04-24 21:15:20.000000000","message":"Same as above? Just assert False?","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":5296,"context_line":"    def test_GET(self):"},{"line_number":5297,"context_line":"        with save_globals():"},{"line_number":5298,"context_line":"            controller \u003d proxy_server.AccountController(self.app, \u0027account\u0027)"},{"line_number":5299,"context_line":"            # GET returns after the first succesful call to an Account Server"},{"line_number":5300,"context_line":"            self.assert_status_map(controller.GET, (200,), 200)"},{"line_number":5301,"context_line":"            self.assert_status_map(controller.GET, (503, 200), 200)"},{"line_number":5302,"context_line":"            self.assert_status_map(controller.GET, (503, 503, 200), 200)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fv%2Fs%3D","line":5299,"updated":"2013-04-24 21:15:20.000000000","message":"Completely trivial. successful","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":5317,"context_line":""},{"line_number":5318,"context_line":"    def test_GET_autocreate(self):"},{"line_number":5319,"context_line":"        with save_globals():"},{"line_number":5320,"context_line":"            # When autocreate is True, if none of the nodes respond 2xx"},{"line_number":5321,"context_line":"            # And quorum of the nodes responded 404,"},{"line_number":5322,"context_line":"            # ALL nodes are asked to create the account"},{"line_number":5323,"context_line":"            # If succesful, the GET request is repeated."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fv%2Fg%3D","line":5320,"updated":"2013-04-24 21:15:20.000000000","message":"A little confusing since autocreate isn\u0027t True, yet.","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"4b4c53cbaffde1d557d3964807649f75d12c4eac","unresolved":false,"context_lines":[{"line_number":5320,"context_line":"            # When autocreate is True, if none of the nodes respond 2xx"},{"line_number":5321,"context_line":"            # And quorum of the nodes responded 404,"},{"line_number":5322,"context_line":"            # ALL nodes are asked to create the account"},{"line_number":5323,"context_line":"            # If succesful, the GET request is repeated."},{"line_number":5324,"context_line":"            controller \u003d proxy_server.AccountController(self.app, \u0027account\u0027)"},{"line_number":5325,"context_line":"            self.app.memcache \u003d FakeMemcacheReturnsNone()"},{"line_number":5326,"context_line":"            # Repeat the test for autocreate \u003d False and 404 by all"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fv%2Fo%3D","line":5323,"updated":"2013-04-24 21:15:20.000000000","message":"Completely trivial. successful","commit_id":"fbee2febb9d94a0b21df295e9c48ba5815282851"}]}