)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2b5022f2840c22a115b21dc7dea171b8d10dd244","unresolved":false,"context_lines":[{"line_number":10,"context_line":"len(list) to checking the boolean value of the list."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This change will be more obvious and more readable,"},{"line_number":13,"context_line":"and is probably cheaper than computing a set intersection, too."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia2864524cfe138f81d82bc37799cf56c1d0482ce"},{"line_number":16,"context_line":"Closes-Bug: #1538518"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_a3a1c495","line":13,"updated":"2016-02-08 18:33:10.000000000","message":"what, where now?","commit_id":"0d192290261ff5f4727b38caef1bb2a0ba5f1e84"}],"swift/common/middleware/domain_remap.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2b5022f2840c22a115b21dc7dea171b8d10dd244","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                      body\u003d\u0027Bad domain in host header\u0027,"},{"line_number":101,"context_line":"                                      content_type\u003d\u0027text/plain\u0027)"},{"line_number":102,"context_line":"                return resp(env, start_response)"},{"line_number":103,"context_line":"            if self.reseller_prefixes:"},{"line_number":104,"context_line":"                if \u0027_\u0027 not in account and \u0027-\u0027 in account:"},{"line_number":105,"context_line":"                    account \u003d account.replace(\u0027-\u0027, \u0027_\u0027, 1)"},{"line_number":106,"context_line":"                account_reseller_prefix \u003d account.split(\u0027_\u0027, 1)[0].lower()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_78661bbc","line":103,"updated":"2016-02-08 18:33:10.000000000","message":"probably legit","commit_id":"0d192290261ff5f4727b38caef1bb2a0ba5f1e84"}],"swift/common/storage_policy.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2b5022f2840c22a115b21dc7dea171b8d10dd244","unresolved":false,"context_lines":[{"line_number":674,"context_line":"        # If a 0 policy wasn\u0027t explicitly given, or nothing was"},{"line_number":675,"context_line":"        # provided, create the 0 policy now"},{"line_number":676,"context_line":"        if 0 not in self.by_index:"},{"line_number":677,"context_line":"            if self:"},{"line_number":678,"context_line":"                raise PolicyError(\u0027You must specify a storage policy \u0027"},{"line_number":679,"context_line":"                                  \u0027section for policy index 0 in order \u0027"},{"line_number":680,"context_line":"                                  \u0027to define multiple policies\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_d8a38ffe","line":677,"updated":"2016-02-08 18:33:10.000000000","message":"does py2.7 know to fall back to __len__ if __nonzero__ is not defined?\n\n*so* spooky\n\n    In [2]: class A(object):\n       ...:     def __init__(self, size):\n       ...:         self.size \u003d size\n       ...:     def __len__(self):\n       ...:         return self.size\n       ...:     \n\n    In [3]: a \u003d A(0)\n\n    In [4]: bool(a)\n    Out[4]: False\n\n    In [5]: a \u003d A(1)\n\n    In [6]: bool(a)\n    Out[6]: True\n\nActually - gah, this is just way harder to read like this - even if we implemented __nonzero__ to be explicit this just looks like a bug.  Even though StoragePolicyCollection mostly acts like a collection - in it\u0027s own methods it\u0027s weird to see self evaluate False.\n\nI think maybe \"if self.by_index\" would avoid the \"using len for emptiness\" rule - but still be clear w/o spooky magic.\n\nAlthough honestly, the goal should really be to find the clearest way to say \"if the legacy policy is not defined - unless there are no other policies defined - raise an error - otherwise add it\".","commit_id":"0d192290261ff5f4727b38caef1bb2a0ba5f1e84"}],"swift/common/utils.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"2b5022f2840c22a115b21dc7dea171b8d10dd244","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        prefix \u003d append_underscore(prefix)"},{"line_number":325,"context_line":"        if prefix not in reseller_prefixes:"},{"line_number":326,"context_line":"            reseller_prefixes.append(prefix)"},{"line_number":327,"context_line":"    if not reseller_prefixes:"},{"line_number":328,"context_line":"        reseller_prefixes.append(\u0027\u0027)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    # Get prefix-using config options"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_180847d9","line":327,"updated":"2016-02-08 18:33:10.000000000","message":"probably legit","commit_id":"0d192290261ff5f4727b38caef1bb2a0ba5f1e84"}]}