)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"0512be564ab5227ea21a669266cef64ebac8430a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With the container quota middleware on, if you made a request similar to the"},{"line_number":10,"context_line":"following one you\u0027d get a 500 response."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"curl -i -X PUT -H \u0027X-Auth-Token: token\u0027"},{"line_number":13,"context_line":"http://127.0.0.1:8080/v1/AUTH_testhttp://something/something_else"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2FYwQ%3D","line":11,"updated":"2013-05-11 20:42:27.000000000","message":"In this URL the container is an empty string - the problem is not with it being a \"double url\" - and the text in the comment is therefore misleading. \nSame problem can happen with just:\ncurl -i -X PUT -H \u0027X-Auth-Token: token\u0027\nhttp://127.0.0.1:8080/v1/AUTH_test//x","commit_id":"adca12743e3a00c62f2547c046ff1c5a4712b021"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"0512be564ab5227ea21a669266cef64ebac8430a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"curl -i -X PUT -H \u0027X-Auth-Token: token\u0027"},{"line_number":13,"context_line":"http://127.0.0.1:8080/v1/AUTH_testhttp://something/something_else"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(Note the double url.)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This was due to a mismatch in how split_path() was called in the middleware and"},{"line_number":18,"context_line":"in the get_container_info()."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2FYwI%3D","line":15,"updated":"2013-05-11 20:42:27.000000000","message":"Should be: Note the empty segment path where teh container name should be","commit_id":"adca12743e3a00c62f2547c046ff1c5a4712b021"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"0512be564ab5227ea21a669266cef64ebac8430a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"http://127.0.0.1:8080/v1/AUTH_testhttp://something/something_else"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(Note the double url.)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This was due to a mismatch in how split_path() was called in the middleware and"},{"line_number":18,"context_line":"in the get_container_info()."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2FYwU%3D","line":16,"updated":"2013-05-11 20:42:27.000000000","message":"This is not why you encounter 500\nYou encounter 500 since the middleware did not test for empty containers","commit_id":"adca12743e3a00c62f2547c046ff1c5a4712b021"}],"swift/common/middleware/container_quotas.py":[{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"0512be564ab5227ea21a669266cef64ebac8430a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        except ValueError:"},{"line_number":69,"context_line":"            return self.app"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        # verify new quota headers are properly formatted"},{"line_number":72,"context_line":"        if container and not obj and req.method in (\u0027PUT\u0027, \u0027POST\u0027):"},{"line_number":73,"context_line":"            val \u003d req.headers.get(\u0027X-Container-Meta-Quota-Bytes\u0027)"},{"line_number":74,"context_line":"            if val and not val.isdigit():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FYvQ%3D","line":71,"updated":"2013-05-11 20:42:27.000000000","message":"The if container is no longer needed. \n\nShould be \nif not obj and req.method in (\u0027PUT\u0027, \u0027POST\u0027):","commit_id":"adca12743e3a00c62f2547c046ff1c5a4712b021"}]}