)]}'
{"go/objectserver/update.go":[{"author":{"_account_id":14711,"name":"Nadeem Syed","email":"snadeem.hameed@gmail.com","username":"nadeem.syed"},"change_message_id":"b43d11877ff32c1b5da5a868323aa5892e268ff3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"\tfailures :\u003d 0"},{"line_number":124,"context_line":"\tfor index :\u003d range hosts {"},{"line_number":125,"context_line":"\t\tif !server.sendContainerUpdate(hosts[index], devices[index], request.Method, partition, vars[\"account\"], vars[\"container\"], vars[\"obj\"], requestHeaders) {"},{"line_number":126,"context_line":"\t\t\tserver.logger.Err(fmt.Sprintf(\"ERROR container update failed with %s/%s (saving for async update later)\", hosts[index], devices[index]))"},{"line_number":127,"context_line":"\t\t\tfailures++"},{"line_number":128,"context_line":"\t\t}"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"9aed3d3a_bf4cdcc8","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":3},"updated":"2016-02-29 22:22:29.000000000","message":"It would be better to use:\nhummingbird.GetLogger(request).LogError\nwhich adds transactionID to the logs.","commit_id":"3c95df5191b752343af34e3215e4a9e50bf6ecb8"},{"author":{"_account_id":14711,"name":"Nadeem Syed","email":"snadeem.hameed@gmail.com","username":"nadeem.syed"},"change_message_id":"b43d11877ff32c1b5da5a868323aa5892e268ff3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\tfailures :\u003d 0"},{"line_number":160,"context_line":"\tfor index :\u003d range hosts {"},{"line_number":161,"context_line":"\t\tif !server.sendContainerUpdate(hosts[index], devices[index], request.Method, partition, deleteAtAccount, container, obj, requestHeaders) {"},{"line_number":162,"context_line":"\t\t\tserver.logger.Err(fmt.Sprintf(\"ERROR container update failed with %s/%s (saving for async update later)\", hosts[index], devices[index]))"},{"line_number":163,"context_line":"\t\t\tfailures++"},{"line_number":164,"context_line":"\t\t}"},{"line_number":165,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"9aed3d3a_1fd4e8ba","line":162,"range":{"start_line":162,"start_character":3,"end_line":162,"end_character":9},"updated":"2016-02-29 22:22:29.000000000","message":"It would be better to use:\nhummingbird.GetLogger(request).LogError\nwhich adds transactionID to the logs.","commit_id":"3c95df5191b752343af34e3215e4a9e50bf6ecb8"},{"author":{"_account_id":14711,"name":"Nadeem Syed","email":"snadeem.hameed@gmail.com","username":"nadeem.syed"},"change_message_id":"376aa0e3ddd01f3244eb340e84bac5c49fed6c6c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"\tfailures :\u003d 0"},{"line_number":124,"context_line":"\tfor index :\u003d range hosts {"},{"line_number":125,"context_line":"\t\tif !server.sendContainerUpdate(hosts[index], devices[index], request.Method, partition, vars[\"account\"], vars[\"container\"], vars[\"obj\"], requestHeaders) {"},{"line_number":126,"context_line":"\t\t\thummingbird.GetLogger(request).LogError(fmt.Sprintf(\"ERROR container update failed with %s/%s (saving for async update later)\", hosts[index], devices[index]))"},{"line_number":127,"context_line":"\t\t\tfailures++"},{"line_number":128,"context_line":"\t\t}"},{"line_number":129,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"7af24918_9ddd4673","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":3},"updated":"2016-03-01 17:21:53.000000000","message":"Nit: You may not need fmt.Sprintf here as LogError already take care of that.","commit_id":"a9280581abba41facd3797cd85a0c2ebfaf3721b"},{"author":{"_account_id":14711,"name":"Nadeem Syed","email":"snadeem.hameed@gmail.com","username":"nadeem.syed"},"change_message_id":"376aa0e3ddd01f3244eb340e84bac5c49fed6c6c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"\tfailures :\u003d 0"},{"line_number":160,"context_line":"\tfor index :\u003d range hosts {"},{"line_number":161,"context_line":"\t\tif !server.sendContainerUpdate(hosts[index], devices[index], request.Method, partition, deleteAtAccount, container, obj, requestHeaders) {"},{"line_number":162,"context_line":"\t\t\thummingbird.GetLogger(request).LogError(fmt.Sprintf(\"ERROR container update failed with %s/%s (saving for async update later)\", hosts[index], devices[index]))"},{"line_number":163,"context_line":"\t\t\tfailures++"},{"line_number":164,"context_line":"\t\t}"},{"line_number":165,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"7af24918_1dd01653","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":3},"updated":"2016-03-01 17:21:53.000000000","message":"Nit: You may not need fmt.Sprintf here as LogError already take care of that.","commit_id":"a9280581abba41facd3797cd85a0c2ebfaf3721b"}]}