)]}'
{"REVIEW_GUIDELINES.md":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"1ec17e545ca8c440c825be0ea157eaf3f9c704a3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"why a change is being made you may have to ask for more details before you"},{"line_number":125,"context_line":"can successfully review it."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Also Commit Messages should follow the OpenStack Commit Message guidelines,"},{"line_number":128,"context_line":"including references to relevant impact tags or bug numbers.  You should hand"},{"line_number":129,"context_line":"out links the OpenStack Commit Message guidelines *liberally* via comments"},{"line_number":130,"context_line":"when fixing commit messages during review."}],"source_content_type":"text/x-markdown","patch_set":1,"id":"7af24918_d7b28d05","line":127,"updated":"2016-03-03 09:17:27.000000000","message":"How about adding a link to the guidelines. Or my favourite commit message related link: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nSomething like: http://paste.openstack.org/show/489099/","commit_id":"8e1f5cbb6c6b972c1d4d45476f19c2a739b6ba8d"},{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"124b30ad901f6c295eb85c52c1dfc386c19c6354","unresolved":false,"context_lines":[{"line_number":124,"context_line":"why a change is being made you may have to ask for more details before you"},{"line_number":125,"context_line":"can successfully review it."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Also Commit Messages should follow the OpenStack Commit Message guidelines,"},{"line_number":128,"context_line":"including references to relevant impact tags or bug numbers.  You should hand"},{"line_number":129,"context_line":"out links the OpenStack Commit Message guidelines *liberally* via comments"},{"line_number":130,"context_line":"when fixing commit messages during review."}],"source_content_type":"text/x-markdown","patch_set":1,"id":"7af24918_01d4a8ba","line":127,"range":{"start_line":127,"start_character":39,"end_line":127,"end_character":74},"updated":"2016-03-03 11:40:17.000000000","message":"Is this the guideline you have in mind? https://wiki.openstack.org/wiki/GitCommitMessages\n?\n\nUpdate: just saw Matt\u0027s comment -- I agree with his version (sorter, more to the point)","commit_id":"8e1f5cbb6c6b972c1d4d45476f19c2a739b6ba8d"},{"author":{"_account_id":860,"name":"Donagh McCabe","email":"donagh.mccabe@gmail.com","username":"donagh-mccabe"},"change_message_id":"124b30ad901f6c295eb85c52c1dfc386c19c6354","unresolved":false,"context_lines":[{"line_number":149,"context_line":"the tests stubs you provide."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Be *very* careful about asking an author to add a test for a \"small change\""},{"line_number":152,"context_line":"before attempting to do so yourself.  It\u0027s quite possible there is a lack of"},{"line_number":153,"context_line":"existing test infrastructure needed to develop a concise and clear test - the"},{"line_number":154,"context_line":"author of a small change may not be the best person to introduce a large"},{"line_number":155,"context_line":"amount of new test infrastructure.  Also, most of the time remember it\u0027s"},{"line_number":156,"context_line":"*harder* to write the test than the change - if the author is unable to"}],"source_content_type":"text/x-markdown","patch_set":1,"id":"7af24918_2c071b19","line":153,"range":{"start_line":152,"start_character":38,"end_line":153,"end_character":72},"updated":"2016-03-03 11:40:17.000000000","message":"Thanks.","commit_id":"8e1f5cbb6c6b972c1d4d45476f19c2a739b6ba8d"}],"REVIEW_GUIDELINES.rst":[{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b560bb5b233e7874783fedf9b2d18926f4c8d055","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Commit Messages"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Read the commit message throughly before you begin the review."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Commit messages must answer the \"why\" and the \"what for\" - more so"},{"line_number":135,"context_line":"than the \"how\" or \"what it does\".  Commonly this will take the form of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_6ecdbcb6","line":132,"updated":"2016-04-25 17:45:13.000000000","message":"typo: change \u0027throughly\u0027 to \u0027thoroughly\u0027","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"149053dcde5f218dc9850168fd4d43b952a5968e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"Commit Messages"},{"line_number":130,"context_line":"---------------"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"Read the commit message throughly before you begin the review."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Commit messages must answer the \"why\" and the \"what for\" - more so"},{"line_number":135,"context_line":"than the \"how\" or \"what it does\".  Commonly this will take the form of"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_e9e0a698","line":132,"in_reply_to":"1a122d0e_6ecdbcb6","updated":"2016-04-25 19:17:43.000000000","message":"Done","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b560bb5b233e7874783fedf9b2d18926f4c8d055","unresolved":false,"context_lines":[{"line_number":206,"context_line":"branches are exercised in tests."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"When you\u0027re done with your review an artifact of your effort will be"},{"line_number":209,"context_line":"observable in the piles of code and scripts and diffs your wrote while"},{"line_number":210,"context_line":"reviewing.  You should make sure to capture those artifacts in a paste"},{"line_number":211,"context_line":"or gist and include them in your review comments so that others may"},{"line_number":212,"context_line":"reference them."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_0ebfe8fb","line":209,"updated":"2016-04-25 17:45:13.000000000","message":"your -\u003e you","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"149053dcde5f218dc9850168fd4d43b952a5968e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"branches are exercised in tests."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"When you\u0027re done with your review an artifact of your effort will be"},{"line_number":209,"context_line":"observable in the piles of code and scripts and diffs your wrote while"},{"line_number":210,"context_line":"reviewing.  You should make sure to capture those artifacts in a paste"},{"line_number":211,"context_line":"or gist and include them in your review comments so that others may"},{"line_number":212,"context_line":"reference them."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_49eefa8b","line":209,"in_reply_to":"1a122d0e_0ebfe8fb","updated":"2016-04-25 19:17:43.000000000","message":"Done","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b560bb5b233e7874783fedf9b2d18926f4c8d055","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"Always point out typos or grammar mistakes when you see them in"},{"line_number":242,"context_line":"review, but also consider that if you were able to recognize the"},{"line_number":243,"context_line":"intent of the statement - documentation with tpyos may be easier to"},{"line_number":244,"context_line":"iterate and improve on than nothing."},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"If a change does not have adequate documentation it may not be suitable to"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_ee50acd6","line":243,"updated":"2016-04-25 17:45:13.000000000","message":"Was \u0027tpyos\u0027 done intentionally for effect? If not, \u0027tpyos\u0027 -\u003e \u0027typos\u0027","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b560bb5b233e7874783fedf9b2d18926f4c8d055","unresolved":false,"context_lines":[{"line_number":269,"context_line":"and find a test that specifically covers that condition and mention it"},{"line_number":270,"context_line":"in the comment so others can find it more quickly.  Of if you can find"},{"line_number":271,"context_line":"no such test, add one to demonstrate the failure, and include a diff"},{"line_number":272,"context_line":"in a comment.  Hopefully you can say \"I *thought* this would would"},{"line_number":273,"context_line":"blow up, so I wrote this test, but it seems fine.\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"But if your initial reaction is \"I don\u0027t understand this\" or \"How does"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_6e5bfcf6","line":272,"updated":"2016-04-25 17:45:13.000000000","message":"duplicate of \u0027would\u0027","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"149053dcde5f218dc9850168fd4d43b952a5968e","unresolved":false,"context_lines":[{"line_number":269,"context_line":"and find a test that specifically covers that condition and mention it"},{"line_number":270,"context_line":"in the comment so others can find it more quickly.  Of if you can find"},{"line_number":271,"context_line":"no such test, add one to demonstrate the failure, and include a diff"},{"line_number":272,"context_line":"in a comment.  Hopefully you can say \"I *thought* this would would"},{"line_number":273,"context_line":"blow up, so I wrote this test, but it seems fine.\""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"But if your initial reaction is \"I don\u0027t understand this\" or \"How does"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_29f1fe6a","line":272,"in_reply_to":"1a122d0e_6e5bfcf6","updated":"2016-04-25 19:17:43.000000000","message":"Done","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"b560bb5b233e7874783fedf9b2d18926f4c8d055","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"But it\u0027s *exactly the same* as your \"+1\""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"It means the change has been throughly and positively reviewed.  The"},{"line_number":368,"context_line":"only reason it\u0027s different is to help identify changes which have"},{"line_number":369,"context_line":"received multiple competent and positive reviews.  If you consistently"},{"line_number":370,"context_line":"provide competent reviews you run a *VERY* high risk of being"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_2e2f443f","line":367,"updated":"2016-04-25 17:45:13.000000000","message":"typo: throughly -\u003e thoroughly","commit_id":"114659f25c085acf05f756390077828e714d3530"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"149053dcde5f218dc9850168fd4d43b952a5968e","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"But it\u0027s *exactly the same* as your \"+1\""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"It means the change has been throughly and positively reviewed.  The"},{"line_number":368,"context_line":"only reason it\u0027s different is to help identify changes which have"},{"line_number":369,"context_line":"received multiple competent and positive reviews.  If you consistently"},{"line_number":370,"context_line":"provide competent reviews you run a *VERY* high risk of being"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_a9fd0e3d","line":367,"in_reply_to":"1a122d0e_2e2f443f","updated":"2016-04-25 19:17:43.000000000","message":"Done","commit_id":"114659f25c085acf05f756390077828e714d3530"}],"doc/source/first_contribution_swift.rst":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"49b7a305bf0af5739a321a7a6c9e81ff0e7a7783","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      insist that these patches are merged with the intention of"},{"line_number":271,"context_line":"      fixing the code at a later date."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"   You should comment inline to praise code that is obvious. You should"},{"line_number":274,"context_line":"   comment inline to highlight code that is unintelligible."},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"   Readability is often subjective. For example, instead of a comment that says,"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5aef4532_433adace","line":273,"updated":"2016-03-07 08:06:43.000000000","message":"should not? typo?","commit_id":"7700895a1e68917057ac7c81d81ac88963c38e6e"}]}