)]}'
{"swift/common/utils.py":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"dc302668afc620e49b626cdfa22b7f673feb9a63","unresolved":false,"context_lines":[{"line_number":3517,"context_line":"            swift_bytes \u003d value"},{"line_number":3518,"context_line":"        else:"},{"line_number":3519,"context_line":"            content_type +\u003d \u0027; %s\u003d%s\u0027 % (key, value)"},{"line_number":3520,"context_line":"    return content_type, swift_bytes"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"def clean_content_type(value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_87d31338","side":"PARENT","line":3520,"updated":"2016-03-08 05:27:45.000000000","message":"interesting that this method ended up defined twice.  I guess we had made the change both on master and on crypto?","commit_id":"0386fe466885a467d303f9f03c1de668bfdfb6fa"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"25a27548d3c710cc03d422db006e160c9bca5752","unresolved":false,"context_lines":[{"line_number":3517,"context_line":"            swift_bytes \u003d value"},{"line_number":3518,"context_line":"        else:"},{"line_number":3519,"context_line":"            content_type +\u003d \u0027; %s\u003d%s\u0027 % (key, value)"},{"line_number":3520,"context_line":"    return content_type, swift_bytes"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":""},{"line_number":3523,"context_line":"def clean_content_type(value):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b2a481a6","side":"PARENT","line":3520,"in_reply_to":"5aef4532_87d31338","updated":"2016-03-08 12:00:10.000000000","message":"Yes, I had replicated the same method on fast-post patch, except there the space after the \u0027;\u0027 separating content-type params was omitted","commit_id":"0386fe466885a467d303f9f03c1de668bfdfb6fa"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"dc302668afc620e49b626cdfa22b7f673feb9a63","unresolved":false,"context_lines":[{"line_number":3501,"context_line":"        left, right \u003d value.rsplit(\u0027;\u0027, 1)"},{"line_number":3502,"context_line":"        if right.lstrip().startswith(\u0027swift_bytes\u003d\u0027):"},{"line_number":3503,"context_line":"            return left"},{"line_number":3504,"context_line":"    return value"},{"line_number":3505,"context_line":""},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"def quote(value, safe\u003d\u0027/\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_a7b9efeb","line":3504,"updated":"2016-03-08 05:27:45.000000000","message":"this was different on the feature branch before.  I guess this is what was causing the tempest test to fail?","commit_id":"6731dd6da8b3723c8dd821b6b4ba40271b4ecb74"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"25a27548d3c710cc03d422db006e160c9bca5752","unresolved":false,"context_lines":[{"line_number":3501,"context_line":"        left, right \u003d value.rsplit(\u0027;\u0027, 1)"},{"line_number":3502,"context_line":"        if right.lstrip().startswith(\u0027swift_bytes\u003d\u0027):"},{"line_number":3503,"context_line":"            return left"},{"line_number":3504,"context_line":"    return value"},{"line_number":3505,"context_line":""},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"def quote(value, safe\u003d\u0027/\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b2f92183","line":3504,"in_reply_to":"5aef4532_a7b9efeb","updated":"2016-03-08 12:00:10.000000000","message":"on the feature branch I had delegated to extract_swift_bytes. But the version of extract_swift_bytes on master omits spaces between content-type params, and that caused a tempest job to fail.\n\nSince we don;t currently care about content-type encryption I just reverted to match master.\n\nI think we will need to fix this method when encrypting content-type because it removes all params after swift_bytes, not just swift_bytes","commit_id":"6731dd6da8b3723c8dd821b6b4ba40271b4ecb74"}]}