)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"58ec9e16b145261cd31985fed5c2b65abe987b9a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # update 3/7/2016 by pxwang: in CPython2.7, this nuke_from_orbit() does not have any impact"},{"line_number":99,"context_line":"        # a sock.shutdown(socket.SHUT_RDWR) call is never made, and so OS never shutdowns the socket"},{"line_number":100,"context_line":"        # the call could be made in the close() method of the class HTTPConnection in the standard Python"},{"line_number":101,"context_line":"        # library httplib.py"},{"line_number":102,"context_line":"    except Exception:"},{"line_number":103,"context_line":"        pass"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_fee42b0e","line":101,"updated":"2016-03-08 00:40:22.000000000","message":"What does this mean about this patch (the update). Does this mean it needs to be reworked, and so maybe it should be WIP for now?\n\nIf you working on it now, then it\u0027s fine however. There are also pep8 issues you need to solve here. (Line wrapping and an extra newline is required. I\u0027d fix it, but this update has confused simple ole me).","commit_id":"cb5ff8bd4776b22a867b1a019455a816df38da6d"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"58ec9e16b145261cd31985fed5c2b65abe987b9a","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        for conn in conns:"},{"line_number":420,"context_line":"           if (hasattr(conn, \u0027done\u0027)) and conn.done:"},{"line_number":421,"context_line":"                conns.remove(conn)"},{"line_number":422,"context_line":"                close_swift_conn(conn)"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return statuses, reasons, bodies, etags"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_1ec5978d","line":422,"updated":"2016-03-08 00:40:22.000000000","message":"What about closing connections on EC PUT\u0027s? They have a putter object which also has a connection.  Although you probably only want to close the connections where after the durable has been written.\n\nAlso do POSTs connections in pypy also cause issues?\n\nJust some thoughts.  I haven\u0027t played with Swift and pypy, so these are just some initial questions so I can better review this change :)","commit_id":"cb5ff8bd4776b22a867b1a019455a816df38da6d"}]}