)]}'
{"test/functional/swift_test_client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"16ab2ad9fac3505b90e505701e2346e477310e46","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                              headers\u003dheaders, data\u003ddata)"},{"line_number":309,"context_line":"            raise RequestError(\u0027Unable to complete http request: %s. \u0027"},{"line_number":310,"context_line":"                               \u0027Failure: Content-Length header exists in \u0027"},{"line_number":311,"context_line":"                               \u0027Response 204\u0027 % request)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        if self.response:"},{"line_number":314,"context_line":"            return self.response.status"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_b55f3ce4","line":311,"updated":"2016-04-05 20:05:48.000000000","message":"I don\u0027t love this change here in the test client infrastructure - I think the client should return the response from the app and leave it to the tests to make this kind of validation and assertions.\n\nI think there should be an explicit functest with an explicit assertion to document and validate the problem and the fix.","commit_id":"9044ba55d180433f4748f5043e4918e411889818"}],"test/unit/common/test_swob.py":[{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"04097c9b0e7f1fd0ba1252ec1f7d6b0417d6a6a4","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self.assertEqual(\u0027Swift realm\u003d\"%s\"\u0027 % quoted_hacker,"},{"line_number":702,"context_line":"                         resp.headers[\u0027Www-Authenticate\u0027])"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"    def test_204_no_content_not_in_headers(self):"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        def test_app(environ, start_response):"},{"line_number":707,"context_line":"            start_response(\u0027204 No Content\u0027, {\u0027Content-Length\u0027: \u00270\u0027})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_d3de4f3e","line":704,"updated":"2016-03-14 18:07:53.000000000","message":"Minor nit on this name -- 204 No Content would still be in the headers. Maybe `test_204_content_type_not_in_headers`?","commit_id":"ac54b5749ba0b56087eda9b9e9d96f3a7cfcffa0"},{"author":{"_account_id":5600,"name":"Brian Cline","email":"bcline@softlayer.com","username":"briancline"},"change_message_id":"04097c9b0e7f1fd0ba1252ec1f7d6b0417d6a6a4","unresolved":false,"context_lines":[{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        req \u003d swift.common.swob.Request.blank(\u0027/\u0027)"},{"line_number":711,"context_line":"        resp \u003d req.get_response(test_app)"},{"line_number":712,"context_line":"        self.assertFalse(\u0027Content-Length\u0027 in resp.headers)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def test_not_401(self):"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_73781b90","line":712,"updated":"2016-03-14 18:07:53.000000000","message":"You could probably use this here instead:\n\n    self.assertNotIn(\u0027Content-Length\u0027, resp.headers)","commit_id":"ac54b5749ba0b56087eda9b9e9d96f3a7cfcffa0"}]}