)]}'
{"test/unit/common/test_db_replicator.py":[{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"e3cafc08d4dd970a789aca8ec714612d14bbc3fc","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            db_replicator.renamer \u003d mock_renamer_error"},{"line_number":422,"context_line":"            replicator._replicate_object(\u00270\u0027, \u0027file\u0027, \u0027node_id\u0027)"},{"line_number":423,"context_line":"        finally:"},{"line_number":424,"context_line":"            replicator.brokerclass.db_file \u003d was_db_file"},{"line_number":425,"context_line":"            db_replicator.renamer \u003d was_renamer"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_replicate_object_delete_because_deleted(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F%2FWg%3D","side":"PARENT","line":424,"updated":"2013-05-15 13:22:25.000000000","message":"Why not just add a line here to restore get_repl_missing_table to False?","commit_id":"884b7bb8f8cd4e20be2bac221adde6c162a2bf89"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"185e061807a1895196f12784656c447785bdbe21","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            db_replicator.renamer \u003d mock_renamer_error"},{"line_number":422,"context_line":"            replicator._replicate_object(\u00270\u0027, \u0027file\u0027, \u0027node_id\u0027)"},{"line_number":423,"context_line":"        finally:"},{"line_number":424,"context_line":"            replicator.brokerclass.db_file \u003d was_db_file"},{"line_number":425,"context_line":"            db_replicator.renamer \u003d was_renamer"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_replicate_object_delete_because_deleted(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F%2B%2Bc%3D","side":"PARENT","line":424,"in_reply_to":"AAAAO3%2F%2F%2FVo%3D","updated":"2013-05-15 15:45:09.000000000","message":"Your fix doesn\u0027t prevent the fact that changes of attributes of TestReplicator.brokerclass will be available through tests. Any way, the fake_broker_creator creates only one private copy of FakeBroker for TestReplicator, not individual copy per instance of TestReplicator class.","commit_id":"884b7bb8f8cd4e20be2bac221adde6c162a2bf89"},{"author":{"_account_id":6529,"name":"Vladimir Vechkanov","email":"vvechkanov@mirantis.com","username":"vvechkanov"},"change_message_id":"b529e7212a0d26099b97e07fdff820e848fd22c6","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            db_replicator.renamer \u003d mock_renamer_error"},{"line_number":422,"context_line":"            replicator._replicate_object(\u00270\u0027, \u0027file\u0027, \u0027node_id\u0027)"},{"line_number":423,"context_line":"        finally:"},{"line_number":424,"context_line":"            replicator.brokerclass.db_file \u003d was_db_file"},{"line_number":425,"context_line":"            db_replicator.renamer \u003d was_renamer"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_replicate_object_delete_because_deleted(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F%2FVo%3D","side":"PARENT","line":424,"in_reply_to":"AAAAO3%2F%2F%2FWg%3D","updated":"2013-05-15 13:26:22.000000000","message":"It is possible but it will not protect from the next such mistakes.","commit_id":"884b7bb8f8cd4e20be2bac221adde6c162a2bf89"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"55b15d96975859fea435c4ad59bc1062c061930f","unresolved":false,"context_lines":[{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    def test_replicate_object_quarantine(self):"},{"line_number":416,"context_line":"        replicator \u003d TestReplicator({})"},{"line_number":417,"context_line":"        self._patch(patch.object, replicator.brokerclass, \u0027db_file\u0027,"},{"line_number":418,"context_line":"                    \u0027/a/b/c/d/e/hey\u0027)"},{"line_number":419,"context_line":"        self._patch(patch.object, replicator.brokerclass,"},{"line_number":420,"context_line":"                    \u0027get_repl_missing_table\u0027, True)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F2ys%3D","line":417,"updated":"2013-05-21 15:50:06.000000000","message":"This seems like a trade off between the extra mechanism added at lines 196 - 206 vs. just using two more with statements nesting everything. Unless other tests are going to also use it, perhaps we could just do the nesting for now?","commit_id":"6d3bcd7e3445d264a37696d1ac26e0e24eb0ccaf"}]}