)]}'
{"swift/obj/replicator.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1cf20d8a929b447c612943b5a12cbf15ea396a51","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027--timeout\u003d%s\u0027 % self.rsync_io_timeout,"},{"line_number":228,"context_line":"            \u0027--contimeout\u003d%s\u0027 % self.rsync_io_timeout,"},{"line_number":229,"context_line":"            \u0027--bwlimit\u003d%s\u0027 % self.rsync_bwlimit,"},{"line_number":230,"context_line":"            \u0027--exclude\u003d.*.%s\u0027 % \u0027\u0027.join(\u0027[0-9a-zA-Z]\u0027 for i in range(6))"},{"line_number":231,"context_line":"        ]"},{"line_number":232,"context_line":"        if self.rsync_compress and \\"},{"line_number":233,"context_line":"                job[\u0027region\u0027] !\u003d node[\u0027region\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_271192ad","line":230,"updated":"2016-04-11 09:51:41.000000000","message":"In the auditor the pattern used to match rsync temp files for cleaning up include \u0027_\u0027 but not here. I have tried and failed so far to find the stdlib mkstemp source (which I think rsync uses to generate the temp file names) to verify what character set is used - do we have a reference for the set of characters to be expected?.\n\nThat said, I have never seen an \u0027_\u0027 while playing with this and the auditor patch.\n\nhttps://github.com/openstack/swift/blob/1d03803a85ca50272071725518c7110e1b2dacb1/swift/obj/auditor.py#L36-L36","commit_id":"f87a5487b5224f77261d82a1087d31820c29e8f8"}]}