)]}'
{"swift/common/ring/builder.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"8bb32661b61f30929f9db9d4c62dd1ad5c985e70","unresolved":false,"context_lines":[{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        :param search_values: a dictionary with search values to filter"},{"line_number":1007,"context_line":"                              devices, supported parameters are id,"},{"line_number":1008,"context_line":"                              region, zone, ip, port, device, weight,"},{"line_number":1009,"context_line":"                              meta"},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"        :returns: list of device dicts"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F%2FAg%3D","line":1008,"updated":"2013-05-17 05:09:46.000000000","message":"I think this doc is missing replication_ip and replication_port?","commit_id":"98badc399c0c7c26bdfcf2eefe678152d037f7b6"}],"test/unit/common/ring/test_builder.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"8bb32661b61f30929f9db9d4c62dd1ad5c985e70","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        for d in devs:"},{"line_number":728,"context_line":"            rb.add_dev(d)"},{"line_number":729,"context_line":"        rb.rebalance()"},{"line_number":730,"context_line":"        res \u003d rb.search_devs({\u0027region\u0027: 0})"},{"line_number":731,"context_line":"        self.assertEquals(res, [devs[0], devs[1]])"},{"line_number":732,"context_line":"        res \u003d rb.search_devs({\u0027region\u0027: 1})"},{"line_number":733,"context_line":"        self.assertEquals(res, [devs[2], devs[3]])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F%2B%2Bw%3D","line":730,"updated":"2013-05-17 05:09:46.000000000","message":"I think we\u0027re losing test coverage of the parsing code, here.\n\nCan you move the parsing code into swift.common.ring.utils or something and copy these old tests to exercise swift.common.ring.utils.parse_search_value()?","commit_id":"98badc399c0c7c26bdfcf2eefe678152d037f7b6"}],"test/unit/common/test_utils.py":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"c6843a0695b1b70800a8cbb79a77f2f995d8a1fd","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                utils.tpool_reraise,"},{"line_number":1324,"context_line":"                MagicMock(side_effect\u003dBaseException(\u0027test3\u0027)))"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"    def test_search_devs(self):"},{"line_number":1327,"context_line":"        res \u003d utils.parse_search_value(\u0027r0\u0027)"},{"line_number":1328,"context_line":"        self.assertEqual(res, {\u0027region\u0027: 0})"},{"line_number":1329,"context_line":"        res \u003d utils.parse_search_value(\u0027r1\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F6Lw%3D","line":1326,"updated":"2013-05-20 15:34:56.000000000","message":"The method actually under test is parse_search_value(), not search_devs(), but the utility function exists only to serve search_devs(), so it doesn\u0027t seem like that big of a deal.  Just pointing it out in case it was unintentional and bothers you too ;)\n\nI don\u0027t think this should hold up the merge, though.","commit_id":"b33a7761ea466c659e40b8ad249a225f979a2221"},{"author":{"_account_id":1531,"name":"Ilya Kharin","email":"akscram@gmail.com","username":"akscram"},"change_message_id":"85cc952e3d2a0ec817d89a58721906b79044bb1d","unresolved":false,"context_lines":[{"line_number":1323,"context_line":"                utils.tpool_reraise,"},{"line_number":1324,"context_line":"                MagicMock(side_effect\u003dBaseException(\u0027test3\u0027)))"},{"line_number":1325,"context_line":""},{"line_number":1326,"context_line":"    def test_search_devs(self):"},{"line_number":1327,"context_line":"        res \u003d utils.parse_search_value(\u0027r0\u0027)"},{"line_number":1328,"context_line":"        self.assertEqual(res, {\u0027region\u0027: 0})"},{"line_number":1329,"context_line":"        res \u003d utils.parse_search_value(\u0027r1\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F5GA%3D","line":1326,"in_reply_to":"AAAAPH%2F%2F6Lw%3D","updated":"2013-05-21 08:19:54.000000000","message":"Yeah, right, I forgot to fix it when copying.","commit_id":"b33a7761ea466c659e40b8ad249a225f979a2221"}]}