)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"66d78006d3d8839d1df2095b0200062aabcc3157","unresolved":false,"context_lines":[{"line_number":941,"context_line":"            except StopIteration:"},{"line_number":942,"context_line":"                req.environ[\u0027swift.non_client_disconnect\u0027] \u003d True"},{"line_number":943,"context_line":"            finally:"},{"line_number":944,"context_line":"                pass"},{"line_number":945,"context_line":"                if part_iter:"},{"line_number":946,"context_line":"                    part_iter.close()"},{"line_number":947,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_912db500","line":944,"updated":"2016-04-06 16:30:38.000000000","message":"i think this line should be removed","commit_id":"a979b9e7af6806133383fcd45c14ede3e9260df6"}],"test/unit/proxy/test_server.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"66d78006d3d8839d1df2095b0200062aabcc3157","unresolved":false,"context_lines":[{"line_number":5827,"context_line":"        exp \u003d \u0027HTTP/1.1 201\u0027"},{"line_number":5828,"context_line":"        self.assertEqual(headers[:len(exp)], exp)"},{"line_number":5829,"context_line":""},{"line_number":5830,"context_line":"        with mock.patch.object(_test_servers[0], \u0027client_timeout\u0027, new\u003d.1):"},{"line_number":5831,"context_line":"            # get object"},{"line_number":5832,"context_line":"            fd.write(\u0027GET /v1/a/ec-discon/test HTTP/1.1\\r\\n\u0027"},{"line_number":5833,"context_line":"                     \u0027Host: localhost\\r\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_718f412a","line":5830,"updated":"2016-04-06 16:30:38.000000000","message":"I\u0027m a little worried the proxy app t/o the test at 100ms here - remember all these \"servers\" are greened in the same linux process during unittests - the object servers even hit disk - on the gate vm\u0027s 100ms isn\u0027t much time I feel?","commit_id":"a979b9e7af6806133383fcd45c14ede3e9260df6"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"66d78006d3d8839d1df2095b0200062aabcc3157","unresolved":false,"context_lines":[{"line_number":5851,"context_line":"        self.assertEqual("},{"line_number":5852,"context_line":"            _test_servers[0].logger.get_lines_for_level(\u0027warning\u0027),"},{"line_number":5853,"context_line":"            expected)"},{"line_number":5854,"context_line":"        sleep(.2)"},{"line_number":5855,"context_line":"        self.assertFalse(_test_servers[0].logger.get_lines_for_level(\u0027error\u0027))"},{"line_number":5856,"context_line":""},{"line_number":5857,"context_line":"    @unpatch_policies"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_11cd2566","line":5854,"updated":"2016-04-06 16:30:38.000000000","message":"As if sleeping 200ms wasn\u0027t bad enough in the first place - same argument as above but the other direction!\n\nI\u0027m worried 100ms difference might not be enough time for ensure we\u0027ve yielded back to the proxy app and it\u0027s had ample time to disconnect and log the backend connections (assuming it was going to).","commit_id":"a979b9e7af6806133383fcd45c14ede3e9260df6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"aeaaf7b3b96c0aad03c94fa92645715c74ac7c33","unresolved":false,"context_lines":[{"line_number":5864,"context_line":"        self.assertEqual("},{"line_number":5865,"context_line":"            _test_servers[0].logger.get_lines_for_level(\u0027warning\u0027),"},{"line_number":5866,"context_line":"            expected)"},{"line_number":5867,"context_line":"        # check that no coro was left waiting to write"},{"line_number":5868,"context_line":"        self.assertTrue(timeouts)  # sanity - WrappedTimeout did get called"},{"line_number":5869,"context_line":"        missing_exits \u003d filter(lambda tb: tb is not None, timeouts.values())"},{"line_number":5870,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_51580f56","line":5867,"updated":"2016-04-07 11:57:33.000000000","message":"Insert sleep(6) here (with the fixes reverted) to see the assert at line 5876 fail","commit_id":"d09ef0da62b64067b04a980c643f77526a9078ac"}]}