)]}'
{"swift/common/middleware/versioned_writes.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"d664e5eae19c1baf3d653792723b655e0e3e6200","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        if source_resp.content_length is None or \\"},{"line_number":278,"context_line":"                source_resp.content_length \u003e MAX_FILE_SIZE:"},{"line_number":279,"context_line":"            close_if_possible(source_resp.app_iter)"},{"line_number":280,"context_line":"            raise HTTPRequestEntityTooLarge(request\u003dreq)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        return source_resp"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5f92ada0","line":280,"updated":"2016-05-12 11:39:27.000000000","message":"why raise and not return? Since there is no error handling for this, where _get_source_object is called?","commit_id":"ce5a3d10487d6de78222cf49255139095596304b"}],"test/unit/common/middleware/test_versioned_writes.py":[{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"bd8583b40cfba592bb6ed22dc87d4fae191cb3e3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            headers[0] \u003d h"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        body_iter \u003d app(req.environ, start_response)"},{"line_number":87,"context_line":"        body \u003d \u0027\u0027"},{"line_number":88,"context_line":"        caught_exc \u003d None"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            for chunk in body_iter:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2c491530","side":"PARENT","line":87,"updated":"2017-06-15 21:14:39.000000000","message":"It seems that body might be undeclared if we get in an expected exception.\nNote: it\u0027s not used for now","commit_id":"6181351a656b68e6163398a891c9efa4e308b459"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"15c96fbb1d659e5ff0976fe8fec70a133c838ffb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            headers[0] \u003d h"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        body_iter \u003d app(req.environ, start_response)"},{"line_number":87,"context_line":"        body \u003d \u0027\u0027"},{"line_number":88,"context_line":"        caught_exc \u003d None"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            for chunk in body_iter:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_a72e5e8f","side":"PARENT","line":87,"in_reply_to":"7f231b9d_2c491530","updated":"2017-06-15 21:34:21.000000000","message":"Good catch. Probably better to just drop the unused test code?","commit_id":"6181351a656b68e6163398a891c9efa4e308b459"}]}