)]}'
{"test/unit/common/middleware/test_keymaster.py":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"2ca06838647dbbc5cca842a67ec194d07e7c3f6c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertListEqual(sorted(expected_keys), sorted(keys.keys()),"},{"line_number":73,"context_line":"                                 \u0027%s %s got keys %r, but expected %r\u0027"},{"line_number":74,"context_line":"                                 % (method, path, keys.keys(), expected_keys))"},{"line_number":75,"context_line":"            if put_keys is not None:"},{"line_number":76,"context_line":"                # check all key sets were consistent for this path"},{"line_number":77,"context_line":"                self.assertDictEqual(put_keys, keys)"},{"line_number":78,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_08174955","line":75,"updated":"2016-04-21 16:46:17.000000000","message":"I know this is not part of this review, but I just realized that put_keys is always set to None.  So, this check is never made.  Maybe put_Keys was going to be an function parameter, but is no longer needed?","commit_id":"22a2fe0874133d7921b9759f6d2781e05a6129cd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"835b10ff3a0c4e72f410b9a7efd321a3fda485b4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertListEqual(sorted(expected_keys), sorted(keys.keys()),"},{"line_number":73,"context_line":"                                 \u0027%s %s got keys %r, but expected %r\u0027"},{"line_number":74,"context_line":"                                 % (method, path, keys.keys(), expected_keys))"},{"line_number":75,"context_line":"            if put_keys is not None:"},{"line_number":76,"context_line":"                # check all key sets were consistent for this path"},{"line_number":77,"context_line":"                self.assertDictEqual(put_keys, keys)"},{"line_number":78,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1402c06f","line":75,"in_reply_to":"1a122d0e_08174955","updated":"2016-04-21 17:45:06.000000000","message":"lol. I deleted put_keys, then realised it IS set at line 79, then all subsequent keys in the loop are compared with it.\n\nAt least, that\u0027s what I think I saw the code doing??","commit_id":"22a2fe0874133d7921b9759f6d2781e05a6129cd"}]}