)]}'
{"go/objectserver/replicator.go":[{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"2df64c4b8f488a1a2cae2fbad9f7e001cf296ec1","unresolved":false,"context_lines":[{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"func (r *Replicator) beginReplication(dev *hummingbird.Device, partition string, hashes bool, rChan chan ReplicationData) {"},{"line_number":185,"context_line":"\tvar user_agent \u003d fmt.Sprintf(\"replicator:%d\", r.bindPort)"},{"line_number":186,"context_line":"\trc, err :\u003d NewRepConn(dev.ReplicationIp, dev.ReplicationPort, dev.Device, partition, user_agent)"},{"line_number":187,"context_line":"\tif err !\u003d nil {"},{"line_number":188,"context_line":"\t\tr.LogError(\"[beginReplication] error creating new request: %v\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"1a122d0e_e958d458","line":185,"range":{"start_line":185,"start_character":5,"end_line":185,"end_character":15},"updated":"2016-04-22 21:27:21.000000000","message":"was talking to barton and what about using (\"replicator:%d\", dev.Id)","commit_id":"8fecc196b057a1ae13bca911c72ed269a17825e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"766deeb89aa25b86483de94c8f0c0bd7791018d3","unresolved":false,"context_lines":[{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"func (r *Replicator) beginReplication(dev *hummingbird.Device, partition string, hashes bool, rChan chan ReplicationData) {"},{"line_number":185,"context_line":"\tvar user_agent \u003d fmt.Sprintf(\"replicator:%d\", r.bindPort)"},{"line_number":186,"context_line":"\trc, err :\u003d NewRepConn(dev.ReplicationIp, dev.ReplicationPort, dev.Device, partition, user_agent)"},{"line_number":187,"context_line":"\tif err !\u003d nil {"},{"line_number":188,"context_line":"\t\tr.LogError(\"[beginReplication] error creating new request: %v\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"1a122d0e_b0911c49","line":185,"in_reply_to":"1a122d0e_e958d458","updated":"2016-04-22 22:28:57.000000000","message":"sure i dig it","commit_id":"8fecc196b057a1ae13bca911c72ed269a17825e3"},{"author":{"_account_id":995,"name":"David Goetz","email":"david.goetz@rackspace.com","username":"david-goetz"},"change_message_id":"2df64c4b8f488a1a2cae2fbad9f7e001cf296ec1","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"func (r *Replicator) beginReplication(dev *hummingbird.Device, partition string, hashes bool, rChan chan ReplicationData) {"},{"line_number":185,"context_line":"\tvar user_agent \u003d fmt.Sprintf(\"replicator:%d\", r.bindPort)"},{"line_number":186,"context_line":"\trc, err :\u003d NewRepConn(dev.ReplicationIp, dev.ReplicationPort, dev.Device, partition, user_agent)"},{"line_number":187,"context_line":"\tif err !\u003d nil {"},{"line_number":188,"context_line":"\t\tr.LogError(\"[beginReplication] error creating new request: %v\", err)"},{"line_number":189,"context_line":"\t\trChan \u003c- ReplicationData{dev: dev, conn: nil, hashes: nil, err: err}"}],"source_content_type":"text/x-go","patch_set":1,"id":"1a122d0e_ed59ff36","line":186,"updated":"2016-04-22 21:27:21.000000000","message":"except- why don\u0027t we just pass the dev into NewRepConn instead of dev.blah, dev.blahblah, etc ? lets just pass the dev and take care of it in the other func. right?","commit_id":"8fecc196b057a1ae13bca911c72ed269a17825e3"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"766deeb89aa25b86483de94c8f0c0bd7791018d3","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"func (r *Replicator) beginReplication(dev *hummingbird.Device, partition string, hashes bool, rChan chan ReplicationData) {"},{"line_number":185,"context_line":"\tvar user_agent \u003d fmt.Sprintf(\"replicator:%d\", r.bindPort)"},{"line_number":186,"context_line":"\trc, err :\u003d NewRepConn(dev.ReplicationIp, dev.ReplicationPort, dev.Device, partition, user_agent)"},{"line_number":187,"context_line":"\tif err !\u003d nil {"},{"line_number":188,"context_line":"\t\tr.LogError(\"[beginReplication] error creating new request: %v\", err)"},{"line_number":189,"context_line":"\t\trChan \u003c- ReplicationData{dev: dev, conn: nil, hashes: nil, err: err}"}],"source_content_type":"text/x-go","patch_set":1,"id":"1a122d0e_d08e5826","line":186,"in_reply_to":"1a122d0e_ed59ff36","updated":"2016-04-22 22:28:57.000000000","message":"didn\u0027t even think about it - makes sense to me","commit_id":"8fecc196b057a1ae13bca911c72ed269a17825e3"}]}