)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"5cc76635fc569d444016f6cc4d78d883e0ad0ff0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return func"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def get_account_memcache_key(account):"},{"line_number":106,"context_line":"    return _get_cache_key(account, None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_eb5b4484","line":105,"updated":"2016-05-16 17:35:49.000000000","message":"why not get rid of these two methods? they don\u0027t really add any value and they are not used anywhere in the code besides tests. I\u0027d suggest making _get_cache_key public.","commit_id":"10ede3d5edf74a7b5fdea1a6353c17b4c2ee169d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"abc75f9414f758d8dc99030f84c3bc9da36e76ca","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    return func"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def get_account_memcache_key(account):"},{"line_number":106,"context_line":"    return _get_cache_key(account, None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_510b2224","line":105,"in_reply_to":"dab17558_eb5b4484","updated":"2016-05-16 18:51:28.000000000","message":"Sure. We\u0027ll lose the ValueError coverage below, but I don\u0027t think it was doing much useful, anyway.","commit_id":"10ede3d5edf74a7b5fdea1a6353c17b4c2ee169d"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"5cc76635fc569d444016f6cc4d78d883e0ad0ff0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    return cache_key"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"def get_object_env_key(account, container, obj):"},{"line_number":353,"context_line":"    \"\"\""},{"line_number":354,"context_line":"    Get the keys for env[\u0027swift.infocache\u0027] where info about object is cached"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_4bdc10e4","line":352,"updated":"2016-05-16 17:35:49.000000000","message":"how about merging _get_cache_key and _get_object_env_key? don\u0027t see why we should have a separate method just for object.","commit_id":"10ede3d5edf74a7b5fdea1a6353c17b4c2ee169d"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"abc75f9414f758d8dc99030f84c3bc9da36e76ca","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    return cache_key"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"def get_object_env_key(account, container, obj):"},{"line_number":353,"context_line":"    \"\"\""},{"line_number":354,"context_line":"    Get the keys for env[\u0027swift.infocache\u0027] where info about object is cached"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_f11a166e","line":352,"in_reply_to":"dab17558_4bdc10e4","updated":"2016-05-16 18:51:28.000000000","message":"Done","commit_id":"10ede3d5edf74a7b5fdea1a6353c17b4c2ee169d"}]}