)]}'
{"swift/common/wsgi.py":[{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    :param app_section: App name from conf file to load config from"},{"line_number":234,"context_line":"    \"\"\""},{"line_number":235,"context_line":"    # Load configuration, Set logger and Load request processor"},{"line_number":236,"context_line":"    try:"},{"line_number":237,"context_line":"        (conf, logger, log_name) \u003d \\"},{"line_number":238,"context_line":"            init_request_processor(conf_path, app_section, *args, **kwargs)"},{"line_number":239,"context_line":"    except ConfigFileError, e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh2I%3D","line":236,"updated":"2013-05-31 06:29:14.000000000","message":"Please undo this change as it is needed by the Apache interface.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    sock \u003d get_socket(conf, default_port\u003dkwargs.get(\u0027default_port\u0027, 8080))"},{"line_number":245,"context_line":"    # remaining tasks should not require elevated privileges"},{"line_number":246,"context_line":"    drop_privileges(conf.get(\u0027user\u0027, \u0027swift\u0027))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    # Ensure the application can be loaded before proceeding."},{"line_number":249,"context_line":"    loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: log_name})"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh2Q%3D","line":247,"updated":"2013-05-31 06:29:14.000000000","message":"Changes in run_wsgi do not affecet the Apache interface since the Apache interface never call this function.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"ff8de9495cfae4bdc8ac20b3587efdb8f428ae2f","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    sock \u003d get_socket(conf, default_port\u003dkwargs.get(\u0027default_port\u0027, 8080))"},{"line_number":245,"context_line":"    # remaining tasks should not require elevated privileges"},{"line_number":246,"context_line":"    drop_privileges(conf.get(\u0027user\u0027, \u0027swift\u0027))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    # Ensure the application can be loaded before proceeding."},{"line_number":249,"context_line":"    loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: log_name})"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F88s%3D","line":247,"in_reply_to":"AAAAPH%2F%2Fg%2FY%3D","updated":"2013-06-05 11:02:13.000000000","message":"Peter, calling loddapp() here does not break the Apache interface and I do not objct to it. My remark above indicates that changes you are making to run_wsgi have no affect on Apache.\n\nThe problem I see with this patch is the change you made to the init_request_processor()","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"49828f582a6d36855e45227ff227d51abac9288d","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    sock \u003d get_socket(conf, default_port\u003dkwargs.get(\u0027default_port\u0027, 8080))"},{"line_number":245,"context_line":"    # remaining tasks should not require elevated privileges"},{"line_number":246,"context_line":"    drop_privileges(conf.get(\u0027user\u0027, \u0027swift\u0027))"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    # Ensure the application can be loaded before proceeding."},{"line_number":249,"context_line":"    loadapp(conf_path, global_conf\u003d{\u0027log_name\u0027: log_name})"},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fg%2FY%3D","line":247,"in_reply_to":"AAAAPH%2F%2Fh2Q%3D","updated":"2013-05-31 13:54:54.000000000","message":"David, to see if I understand what you mean, reading the apache integration documentation in our tree, I see that it describes how to create .wsgi files for Apache, which just invoke init_request_processor(). Hence the reason you say that this breaks the Apache interface.\n\nDo I have this correct?\n\nif so, perhaps we need to pull those .wsgi files out of the documentation, and place them in the tree so that this kind of conflicting change does not happen again?\n\nAdditionally, if we agree to pull that code out of the docs, we probably also need to modify those wsgi files so that:\n\n1.They invoke init_request_processor and then loadapp\n\n2. Ensure that in wsgi, loadapp is called after privileges are dropped, however Apache does that\n\nFor this commit, it would probably be sufficient for this commit to change the documentation to call loadapp directly.\n\nIs that agreeable?","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    if config_true_value(conf.get(\u0027disable_fallocate\u0027, \u0027no\u0027)):"},{"line_number":343,"context_line":"        disable_fallocate()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    monkey_patch_mimetools()"},{"line_number":346,"context_line":"    return (conf, logger, log_name)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh2E%3D","line":345,"updated":"2013-05-31 06:29:14.000000000","message":"Please undo this change as it is needed by the Apache interface.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"}],"test/unit/common/test_wsgi.py":[{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            conf_file \u003d os.path.join(t, \u0027proxy-server.conf\u0027)"},{"line_number":130,"context_line":"            with open(conf_file, \u0027w\u0027) as f:"},{"line_number":131,"context_line":"                f.write(contents.replace(\u0027TEMPDIR\u0027, t))"},{"line_number":132,"context_line":"            _fake_rings(t)"},{"line_number":133,"context_line":"            conf, logger, log_name \u003d wsgi.init_request_processor("},{"line_number":134,"context_line":"                conf_file, \u0027proxy-server\u0027)"},{"line_number":135,"context_line":"        # verify pipeline is catch_errors -\u003e proxy-servery"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh18%3D","line":132,"updated":"2013-05-31 06:29:14.000000000","message":"Please undo this change as it is needed by the Apache interface.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            conf_dir \u003d os.path.join(conf_root, \u0027proxy-server.conf.d\u0027)"},{"line_number":169,"context_line":"            with open(os.path.join(conf_dir, \u0027swift.conf\u0027), \u0027w\u0027) as f:"},{"line_number":170,"context_line":"                f.write(\u0027[DEFAULT]\\nswift_dir \u003d %s\u0027 % conf_root)"},{"line_number":171,"context_line":"            _fake_rings(conf_root)"},{"line_number":172,"context_line":"            conf, logger, log_name \u003d wsgi.init_request_processor("},{"line_number":173,"context_line":"                conf_dir, \u0027proxy-server\u0027)"},{"line_number":174,"context_line":"        # verify pipeline is catch_errors -\u003e proxy-servery"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh10%3D","line":171,"updated":"2013-05-31 06:29:14.000000000","message":"Please undo this change as it is needed by the Apache interface.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"},{"author":{"_account_id":4108,"name":"David Hadas","email":"davidh@il.ibm.com","username":"david-hadas"},"change_message_id":"3a9f10ce20450d74b5a3dbe1e4474c316bee1271","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            conf, logger, log_name \u003d wsgi.init_request_processor("},{"line_number":173,"context_line":"                conf_dir, \u0027proxy-server\u0027)"},{"line_number":174,"context_line":"        # verify pipeline is catch_errors -\u003e proxy-servery"},{"line_number":175,"context_line":"        expected \u003d swift.common.middleware.catch_errors.CatchErrorMiddleware"},{"line_number":176,"context_line":"        # appconfig returns values from \u0027proxy-server\u0027 section"},{"line_number":177,"context_line":"        expected \u003d {"},{"line_number":178,"context_line":"            \u0027__file__\u0027: conf_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fh1w%3D","line":175,"updated":"2013-05-31 06:29:14.000000000","message":"Please undo this change as it is needed by the Apache interface.","commit_id":"878535858e1191ceda4dc97f12dcc60380492206"}]}