)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"4f481360b9ef46abc3b7a48da51b3231ffd9b4d4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"to match against."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"So in this case we would have X-Backend-Etag-Is-At equal to"},{"line_number":33,"context_line":"\"X-Object-Sysmeta-Crypto-Etag,X-Object-Sysmeta-Crypto-Etag\" and for"},{"line_number":34,"context_line":"the unencrypted EC object the object server would find the alternate"},{"line_number":35,"context_line":"etag value at X-Object-Sysmeta-Crypto-Etag."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_a7c2f082","line":33,"updated":"2016-05-11 11:57:29.000000000","message":"both are crypto-etag; missed to add \"X-Object-Sysmeta-Ec-Etag\"","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"109c3c0065c8d1560c0e25257bff7d2e44c6c6fd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"to match against."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"So in this case we would have X-Backend-Etag-Is-At equal to"},{"line_number":33,"context_line":"\"X-Object-Sysmeta-Crypto-Etag,X-Object-Sysmeta-Crypto-Etag\" and for"},{"line_number":34,"context_line":"the unencrypted EC object the object server would find the alternate"},{"line_number":35,"context_line":"etag value at X-Object-Sysmeta-Crypto-Etag."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_ed8f69ca","line":33,"in_reply_to":"dab17558_a7c2f082","updated":"2016-05-12 16:47:20.000000000","message":"oops. good catch.","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"4f481360b9ef46abc3b7a48da51b3231ffd9b4d4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"So in this case we would have X-Backend-Etag-Is-At equal to"},{"line_number":33,"context_line":"\"X-Object-Sysmeta-Crypto-Etag,X-Object-Sysmeta-Crypto-Etag\" and for"},{"line_number":34,"context_line":"the unencrypted EC object the object server would find the alternate"},{"line_number":35,"context_line":"etag value at X-Object-Sysmeta-Crypto-Etag."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The patch also adds a set of tests to verify this behaviour by"},{"line_number":38,"context_line":"reusing the test server framework from test/proxy/test_server.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_470864da","line":35,"updated":"2016-05-11 11:57:29.000000000","message":"Should be \"X-Object-Sysmeta-Ec-Etag\"?","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"109c3c0065c8d1560c0e25257bff7d2e44c6c6fd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"So in this case we would have X-Backend-Etag-Is-At equal to"},{"line_number":33,"context_line":"\"X-Object-Sysmeta-Crypto-Etag,X-Object-Sysmeta-Crypto-Etag\" and for"},{"line_number":34,"context_line":"the unencrypted EC object the object server would find the alternate"},{"line_number":35,"context_line":"etag value at X-Object-Sysmeta-Crypto-Etag."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The patch also adds a set of tests to verify this behaviour by"},{"line_number":38,"context_line":"reusing the test server framework from test/proxy/test_server.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_adac4136","line":35,"in_reply_to":"dab17558_470864da","updated":"2016-05-12 16:47:20.000000000","message":"Done","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"}],"test/unit/common/middleware/test_encrypter_decrypter.py":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"4f481360b9ef46abc3b7a48da51b3231ffd9b4d4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # set proxy config to use fast post"},{"line_number":250,"context_line":"        extra_conf \u003d {\u0027object_post_as_copy\u0027: \u0027False\u0027}"},{"line_number":251,"context_line":"        cls._test_context \u003d setup_servers(extra_conf\u003dextra_conf)"},{"line_number":252,"context_line":"        cls.proxy_app \u003d cls._test_context[\"test_servers\"][0]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class TestEncrypterDecrypter(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4d15239a","line":252,"updated":"2016-05-11 11:57:29.000000000","message":"tests yet to follow for this class?","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"109c3c0065c8d1560c0e25257bff7d2e44c6c6fd","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        # set proxy config to use fast post"},{"line_number":250,"context_line":"        extra_conf \u003d {\u0027object_post_as_copy\u0027: \u0027False\u0027}"},{"line_number":251,"context_line":"        cls._test_context \u003d setup_servers(extra_conf\u003dextra_conf)"},{"line_number":252,"context_line":"        cls.proxy_app \u003d cls._test_context[\"test_servers\"][0]"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"class TestEncrypterDecrypter(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4d49558e","line":252,"in_reply_to":"dab17558_4d15239a","updated":"2016-05-12 16:47:20.000000000","message":"it inherits all the tests from TestCryptoPipelineChanges so they are repeated with the modified setup.","commit_id":"0055404d0659ab8c21d4a7c66e4c41b918bef899"}]}