)]}'
{"swift/proxy/controllers/base.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1ba6f375df6e6d2f540ae4580f6a5c9f33f6b5ec","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    if \u0027object_count\u0027 not in info and \u0027container_size\u0027 in info:"},{"line_number":358,"context_line":"        info[\u0027object_count\u0027] \u003d info.pop(\u0027container_size\u0027)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    for field in (\u0027storage_policy\u0027, \u0027bytes\u0027, \u0027object_count\u0027):"},{"line_number":361,"context_line":"        if info.get(field) is None:"},{"line_number":362,"context_line":"            info[field] \u003d 0"},{"line_number":363,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_056950f9","line":360,"range":{"start_line":360,"start_character":19,"end_line":360,"end_character":33},"updated":"2016-05-16 21:21:01.000000000","message":"So we\u0027re (maybe) changing the type here?","commit_id":"7eac98d8ba2c7d3d5673d574fbea14c281eb509b"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"40c9ea6d2b29ade32d6c051eab2742972e4e2bbd","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    if \u0027object_count\u0027 not in info and \u0027container_size\u0027 in info:"},{"line_number":358,"context_line":"        info[\u0027object_count\u0027] \u003d info.pop(\u0027container_size\u0027)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    for field in (\u0027storage_policy\u0027, \u0027bytes\u0027, \u0027object_count\u0027):"},{"line_number":361,"context_line":"        if info.get(field) is None:"},{"line_number":362,"context_line":"            info[field] \u003d 0"},{"line_number":363,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6d111e52","line":360,"range":{"start_line":360,"start_character":19,"end_line":360,"end_character":33},"in_reply_to":"dab17558_056950f9","updated":"2016-05-16 22:38:39.000000000","message":"correct, and I was a little bit nervous about this, but I think we want an int at the end, because this option is usually used to call POLICIES.get_by_index.\nAlso, looking at line https://review.openstack.org/#/c/317080/1/swift/proxy/controllers/base.py@a1515\nyou will notice that we were assigning an int there.","commit_id":"7eac98d8ba2c7d3d5673d574fbea14c281eb509b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"1ba6f375df6e6d2f540ae4580f6a5c9f33f6b5ec","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                or not is_success(info[\u0027status\u0027])"},{"line_number":1475,"context_line":"                or not info.get(\u0027account_really_exists\u0027, True)):"},{"line_number":1476,"context_line":"            return None, None, None"},{"line_number":1477,"context_line":"        container_count \u003d info[\u0027container_count\u0027]"},{"line_number":1478,"context_line":"        return partition, nodes, container_count"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    def container_info(self, account, container, req\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c500e804","line":1477,"range":{"start_line":1477,"start_character":8,"end_line":1477,"end_character":23},"updated":"2016-05-16 21:21:01.000000000","message":"Will this still be an int, or is it now a str? Does it matter?","commit_id":"7eac98d8ba2c7d3d5673d574fbea14c281eb509b"},{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"40c9ea6d2b29ade32d6c051eab2742972e4e2bbd","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                or not is_success(info[\u0027status\u0027])"},{"line_number":1475,"context_line":"                or not info.get(\u0027account_really_exists\u0027, True)):"},{"line_number":1476,"context_line":"            return None, None, None"},{"line_number":1477,"context_line":"        container_count \u003d info[\u0027container_count\u0027]"},{"line_number":1478,"context_line":"        return partition, nodes, container_count"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    def container_info(self, account, container, req\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4d541afd","line":1477,"range":{"start_line":1477,"start_character":8,"end_line":1477,"end_character":23},"in_reply_to":"dab17558_c500e804","updated":"2016-05-16 22:38:39.000000000","message":"get_account_info sets it as an int","commit_id":"7eac98d8ba2c7d3d5673d574fbea14c281eb509b"}]}
