)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c3b8107c502d5fe14e210cca17f59d26e15aaa4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Motiani \u003cmohit.motiani@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-23 21:10:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add region in ring structure \u0026 deployment guide."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deployment guide does not talk about the region. Also, it says"},{"line_number":10,"context_line":"zones are number."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_aa2f233d","line":7,"updated":"2016-05-23 21:29:45.000000000","message":"nit, no \u0027.\u0027 on end of first line","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohit Motiani \u003cmohit.motiani@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-23 21:10:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add region in ring structure \u0026 deployment guide."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deployment guide does not talk about the region. Also, it says"},{"line_number":10,"context_line":"zones are number."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_8193fa4e","line":7,"in_reply_to":"bab6814e_aa2f233d","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c3b8107c502d5fe14e210cca17f59d26e15aaa4c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"zones are number."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds brief description about region and changes numbers"},{"line_number":13,"context_line":"to int. Also, adds region in the ring data struture."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04ce42fb3e5c1f08e7f7ff6be23482cee8bdeb71"},{"line_number":16,"context_line":"Closes-Bug: #1583551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_aad60325","line":13,"updated":"2016-05-23 21:29:45.000000000","message":"In the ring data structure, or the docs that talk about the ring data structure?","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"zones are number."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds brief description about region and changes numbers"},{"line_number":13,"context_line":"to int. Also, adds region in the ring data struture."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I04ce42fb3e5c1f08e7f7ff6be23482cee8bdeb71"},{"line_number":16,"context_line":"Closes-Bug: #1583551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_e198066d","line":13,"in_reply_to":"bab6814e_aad60325","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"79ca37a9d8f849ad0d5381dc54fcaae96749278c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"struture."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I04ce42fb3e5c1f08e7f7ff6be23482cee8bdeb71"},{"line_number":17,"context_line":"Closes-Bug: #1583551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_3c372600","line":17,"updated":"2016-06-01 16:51:17.000000000","message":"This doesn\u0027t cover all the issues mentioned in the bug report so use Partial-Bug instead","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"aa4e1eedf4238f9fefb42f13da06a60a2bac57f9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"struture."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I04ce42fb3e5c1f08e7f7ff6be23482cee8bdeb71"},{"line_number":17,"context_line":"Closes-Bug: #1583551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9abb7d3a_284d1b9a","line":17,"in_reply_to":"9abb7d3a_3c372600","updated":"2016-06-01 19:29:21.000000000","message":"Done","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"}],"doc/source/deployment_guide.rst":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"5d9d9aef5e2eb61a64575ee408fcf70017d490fa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_5dc90aac","line":100,"updated":"2016-05-24 09:41:59.000000000","message":"A region can be used to distinguish between geographically separated areas, but it is not necessarily. A region can be also used within the same datacenter - for example two sides of a building with fire barriers between them, and zones might be racks. Therefore I would prefer to remove the the sentence \"Region is characterize ... horizon\".","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c3b8107c502d5fe14e210cca17f59d26e15aaa4c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_4aa2f79b","line":100,"updated":"2016-05-23 21:29:45.000000000","message":"Somewhat awkward wording.  Are you intending to say that zones exist within a region?","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_a1b55ed1","line":100,"in_reply_to":"bab6814e_4aa2f79b","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_81badabe","line":100,"in_reply_to":"bab6814e_5dc90aac","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":18838,"name":"Paul Dardeau","email":"paul.dardeau@intel.com","username":"pdardeau"},"change_message_id":"c3b8107c502d5fe14e210cca17f59d26e15aaa4c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_4ad037f8","line":101,"updated":"2016-05-23 21:29:45.000000000","message":"Maybe tweak the wording a little.\n\nThe region is characterized...?\n\n\u0027horizon\u0027?\n\n\"by integer\" --\u003e by an integer?","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"5d9d9aef5e2eb61a64575ee408fcf70017d490fa","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_bdbab608","line":101,"updated":"2016-05-24 09:41:59.000000000","message":"While we\u0027re at it - both can start with a 0.","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_21ca0e50","line":101,"in_reply_to":"bab6814e_4ad037f8","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"3c0b5884d2560ddf4ac5469efaa3ff29ef927f9f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone is physically"},{"line_number":100,"context_line":"present in a region. Region is characterize as a geographically confined"},{"line_number":101,"context_line":"horizon. Regions and Zones are referenced by integer, beginning with 1."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"You can now start building the ring with::"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bab6814e_61c41640","line":101,"in_reply_to":"bab6814e_bdbab608","updated":"2016-05-24 14:55:29.000000000","message":"Done","commit_id":"c0b8cb1ba65a4a1c8ee05544431de01e59e85263"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"79ca37a9d8f849ad0d5381dc54fcaae96749278c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"network connectivity. For example, in a small cluster you might decide to"},{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_2b77e202","line":99,"updated":"2016-06-01 16:51:17.000000000","message":"I suggest starting a new paragraph to discuss regions","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"aa4e1eedf4238f9fefb42f13da06a60a2bac57f9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"network connectivity. For example, in a small cluster you might decide to"},{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_08501731","line":99,"in_reply_to":"9abb7d3a_2b77e202","updated":"2016-06-01 19:29:21.000000000","message":"Nice suggestion. Thanks!","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"79ca37a9d8f849ad0d5381dc54fcaae96749278c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_a67b097a","line":100,"updated":"2016-06-01 16:51:17.000000000","message":"Regions are abstract concepts just like zones, so perhaps:\n\n  A region is also an abstract concept and may be used to   distinguish between geographically separated areas or to distinguish areas in the same datacenter.","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"aa4e1eedf4238f9fefb42f13da06a60a2bac57f9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_6843a36c","line":100,"in_reply_to":"9abb7d3a_a67b097a","updated":"2016-06-01 19:29:21.000000000","message":"Done","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"79ca37a9d8f849ad0d5381dc54fcaae96749278c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_e616b14a","line":101,"updated":"2016-06-01 16:51:17.000000000","message":"s/seperated/separated/","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"aa4e1eedf4238f9fefb42f13da06a60a2bac57f9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"You can now start building the ring with::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_48469f7b","line":101,"in_reply_to":"9abb7d3a_e616b14a","updated":"2016-06-01 19:29:21.000000000","message":"Done","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"79ca37a9d8f849ad0d5381dc54fcaae96749278c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"You can now start building the ring with::"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_e644f14a","line":102,"updated":"2016-06-01 16:51:17.000000000","message":"zones is lower case elsewhere when not at start of a sentence.\n\n\"integer\" -\u003e \"positive integer\" or \"whole number\" is most precise","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"aa4e1eedf4238f9fefb42f13da06a60a2bac57f9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region. A region is used to distinguish between geographically"},{"line_number":101,"context_line":"seperated area as well as can be used within the same datacenter. Regions"},{"line_number":102,"context_line":"and Zones are referenced by an integer, beginning with 0."},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"You can now start building the ring with::"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9abb7d3a_c8528f34","line":102,"in_reply_to":"9abb7d3a_e644f14a","updated":"2016-06-01 19:29:21.000000000","message":"positive integer sounds good. Thanks!","commit_id":"82899e26c47f8c08994b59d3ea6dbe7be311ea87"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"155ac324be1e23bd783916deaa33762cc6af4fc3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_b981f54f","line":100,"updated":"2016-06-03 10:52:00.000000000","message":"nit: I\u0027m not sure about use of the word \u0027physically\u0027, having just said that zones are abstract concepts. Maybe it\u0027s ok. The important point is that there is a containment heirarchy: zones exist within regions. And this sentence introduces the term \u0027region\u0027.","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"45e9e811eb057047f50b5774d013d00f7b69f0c9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"split the zones up by cabinet, with each cabinet having its own power and"},{"line_number":98,"context_line":"network connectivity. The zone concept is very abstract, so feel free to use"},{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_f808932a","line":100,"in_reply_to":"9abb7d3a_b981f54f","updated":"2016-07-12 15:38:37.000000000","message":"Done","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"155ac324be1e23bd783916deaa33762cc6af4fc3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."},{"line_number":104,"context_line":"Regions and zones are referenced by a positive integer beginning with 0."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_5918c975","line":102,"updated":"2016-06-03 10:52:00.000000000","message":"s/concept may/concept that may/","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"45e9e811eb057047f50b5774d013d00f7b69f0c9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"it in whatever way best isolates your data from failure. Each zone physically"},{"line_number":100,"context_line":"exists in a region."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."},{"line_number":104,"context_line":"Regions and zones are referenced by a positive integer beginning with 0."},{"line_number":105,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_d80b1723","line":102,"in_reply_to":"9abb7d3a_5918c975","updated":"2016-07-12 15:38:37.000000000","message":"Done","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"155ac324be1e23bd783916deaa33762cc6af4fc3","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."},{"line_number":104,"context_line":"Regions and zones are referenced by a positive integer beginning with 0."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"You can now start building the ring with::"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_596729b7","line":104,"updated":"2016-06-03 10:52:00.000000000","message":"0 is not a positive integer. I think we concluded that it is better not to mention 0 (it may work, depends on which options you pass to swift-ring-builder).\n\nAlso, I don\u0027t think there is any requirement for zones or regions to be be number monotonically increasing from 1 (or 0). So the phrase \u0027beginning with\u0027 is misleading. Maybe another reviewer can confirm the intent of the zone/region numbering, but I found I could create regions 1 and 99 without 2-98 existing.\n\nSo unless I am mistaken \"Regions and zones are referenced by a positive integer.\" is sufficent.","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"45e9e811eb057047f50b5774d013d00f7b69f0c9","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"A region is also an abstract concept may be used to distinguish between"},{"line_number":103,"context_line":"geographically separated areas as well as can be used within same datacenter."},{"line_number":104,"context_line":"Regions and zones are referenced by a positive integer beginning with 0."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"You can now start building the ring with::"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_180e3f32","line":104,"in_reply_to":"9abb7d3a_596729b7","updated":"2016-07-12 15:38:37.000000000","message":"Done","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"}],"doc/source/overview_ring.rst":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"155ac324be1e23bd783916deaa33762cc6af4fc3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":82,"context_line":"id      integer  The index into the list devices."},{"line_number":83,"context_line":"zone    integer  The zone the devices resides in."},{"line_number":84,"context_line":"region  integer  The region the zones resides in."},{"line_number":85,"context_line":"weight  float    The relative weight of the device in comparison to other"},{"line_number":86,"context_line":"                 devices. This usually corresponds directly to the amount of"},{"line_number":87,"context_line":"                 disk space the device has compared to other devices. For"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9abb7d3a_f9b37d08","line":84,"updated":"2016-06-03 10:52:00.000000000","message":"s/zones/zone/\n\nthe line above should also be corrected s/devices/device/\n\nthe dict describes one device which is in one zone in one region","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"45e9e811eb057047f50b5774d013d00f7b69f0c9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":82,"context_line":"id      integer  The index into the list devices."},{"line_number":83,"context_line":"zone    integer  The zone the devices resides in."},{"line_number":84,"context_line":"region  integer  The region the zones resides in."},{"line_number":85,"context_line":"weight  float    The relative weight of the device in comparison to other"},{"line_number":86,"context_line":"                 devices. This usually corresponds directly to the amount of"},{"line_number":87,"context_line":"                 disk space the device has compared to other devices. For"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1aa78d24_b8fe0b03","line":84,"in_reply_to":"9abb7d3a_f9b37d08","updated":"2016-07-12 15:38:37.000000000","message":"Done","commit_id":"a8bced0f82ed851dd1b05bd8f09db8b584ad7abd"}]}