)]}'
{"id":"openstack%2Fswift~32178","triplet_id":"openstack%2Fswift~master~I7bb21951d46050163c1b7bceac8d49302b9209f7","project":"openstack/swift","branch":"master","topic":"maxheader_fix","hashtags":[],"change_id":"I7bb21951d46050163c1b7bceac8d49302b9209f7","subject":"Add max_header_size to swift.conf-sample and relative UT","status":"MERGED","created":"2013-06-07 18:13:59.000000000","updated":"2013-06-20 14:04:26.000000000","submitted":"2013-06-20 14:04:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"33684325e4acbcfc4107b2aaca8210edd8af6321","_number":32178,"virtual_id_number":32178,"owner":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":0,"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":1,"date":"2013-06-19 16:04:30.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":2,"date":"2013-06-20 14:04:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"all":[{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":2,"date":"2013-06-19 15:49:45.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-06-20 13:13:26.000000000","_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"all":[{"value":0,"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"value":0,"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"value":0,"date":"2013-06-19 15:49:45.000000000","_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-06-20 13:13:35.000000000","_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-06-09 06:26:27.000000000","updated_by":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"reviewer":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"state":"REVIEWER"},{"updated":"2013-06-18 17:20:12.000000000","updated_by":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"reviewer":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"state":"REVIEWER"},{"updated":"2013-06-19 15:49:45.000000000","updated_by":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"reviewer":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"state":"REVIEWER"},{"updated":"2013-06-19 16:04:30.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-06-20 13:13:35.000000000","updated_by":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"reviewer":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"state":"REVIEWER"},{"updated":"2013-06-20 14:04:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"fe6d38c76b6ec1ae80c424a6d3ac27f6e66c6ecb","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-07 18:26:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ef5a83739748c5310d4e63f640e6e6ed2519762b","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-07 18:43:35.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/89922\n","accounts_in_message":[],"_revision_number":2},{"id":"ec84338c4f51a79013c23050011fb12e21d02d76","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-07 19:17:45.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32178/2/check/gate-swift-pep8/2650 : SUCCESS in 42s\n- http://docs-draft.openstack.org/32178/2/check/gate-swift-docs/2480/doc/build/html/ : SUCCESS in 1m 09s\n- http://logs.openstack.org/32178/2/check/gate-swift-python26/2728 : SUCCESS in 2m 50s\n- http://logs.openstack.org/32178/2/check/gate-swift-python27/2726 : SUCCESS in 1m 08s\n- http://logs.openstack.org/32178/2/check/gate-tempest-devstack-vm-full/21501 : FAILURE in 51m 26s\n- http://logs.openstack.org/32178/2/check/gate-tempest-devstack-vm-quantum/28634 : FAILURE in 20m 13s\n- http://logs.openstack.org/32178/2/check/gate-tempest-devstack-vm-postgres-full/21208 : FAILURE in 47m 29s\n- http://logs.openstack.org/32178/2/check/gate-grenade-devstack-vm/8777 : SUCCESS in 13m 53s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"5528c601db1620028fd446eae59f9279b003d68a","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-06-07 20:01:39.000000000","message":"Patch Set 2: Do not merge\n\nMAX_HEADER_SIZE is the maximum length of any *one* HTTP header, not the maximum length of all the headers combined.","accounts_in_message":[],"_revision_number":2},{"id":"6524e0d6d54ec048856493fe10f660c2bd5245c3","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-08 02:00:09.000000000","message":"Patch Set 2:\n\nsam, look like origin codes:\n\nMAX_META_VALUE_LENGTH it used to check the value of meta header\n\nMAX_META_NAME_LENGTH is used to check the key of meta header\n\nMAX_META_OVERALL_LENGTH is used to check the sum of above two\n\nMAX_HEADER_SIZE is used as same as MAX_META_VALUE_LENGTH\n\nand default value of MAX_HEADER_SIZE is 8096, which looks like a common limit of request header size, not one header line. But the related bad request has body as \"header line too long\"\n\nI think there must be something wrong about this MAX_HEADER_SIZE, usage or naming or default value","accounts_in_message":[],"_revision_number":2},{"id":"661c78c60db41ae09f7a367a4fe249463a0415c3","author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"date":"2013-06-09 06:26:27.000000000","message":"Patch Set 2:\n\nKun, I think Samuel is right.\nThe local variable of meta_size in the origin code is do the same thing as total_size your added code.\nSo MAX_META_OVERALL_SIZE is used to limit the total size of all headers, just like the response message \nsaid \"Total metadata too large\".\nHowever, I also agree your concern of the default values. it doesn\u0027t make sense to limit one header to\n 8192 but limit overall header length to 4096. So I suggest to exchange the two default values.\n\nMAX_META_OVERALL_SIZE \u003d constraints_conf_int(\u0027max_meta_overall_size\u0027, 8192)\nMAX_HEADER_SIZE \u003d constraints_conf_int(\u0027max_header_size\u0027, 4096)","accounts_in_message":[],"_revision_number":2},{"id":"73ae0a6819233d0a91ead775d5693753b6897041","author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"date":"2013-06-09 06:50:36.000000000","message":"Patch Set 2:\n\nI take back my comment to exchange default value.\nThe MAX_HEADER_SIZE is not only to limit headers of user metadata, but also to limit other headers in request.\nIt could be possibly larger than MAX_META_OVERALL_SIZE.\nCorrect me if I\u0027m wrong. :-)","accounts_in_message":[],"_revision_number":2},{"id":"e0259271f5abcd208ca2844a512e619dfe3c33ef","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-09 07:03:45.000000000","message":"Patch Set 2:\n\nAgreed with your understanding of MAX_META_OVERALL_SIZE\n\nBut the origin codes use MAX_HEADER_SIZE and MAX_META_VALUE_LENGTH in same way, which has different default value 4096 and 256.\n\nMaybe the name of variables looks like they are used to limit header or meta, but in check_meta what is checked is req.headers which contains meta and content-type and so on.\n\nMAX_HEADER_SIZE may be used like MAX_META_OVERALL_SIZE, but never same. For meta, we test the length of \"key\"+\"value\", and for header, we test the length of \"x-object-meta-key: value\".\n\nSo I think there should be some improvement here.","accounts_in_message":[],"_revision_number":2},{"id":"47566b8fcc688749753e7eeca22e99d9c1be4180","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-09 07:27:01.000000000","message":"Patch Set 2:\n\nBTW, hua, this MAX_HEADER_SIZE  is added in this patch https://review.openstack.org/#/c/22895/\n\nI would ask david about is correct usage but I didn\u0027t find his irc id...","accounts_in_message":[],"_revision_number":2},{"id":"cdd38469b47f18108686aeebcf76d9306e438cb4","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2013-06-11 14:04:12.000000000","message":"Patch Set 2:\n\nSo MAX_HEADER_SIZE is the maximum any single header can be, regardless of whether it\u0027s a meta header or just some other header. It has nothing to do with the overall size of all the headers combined. It even says in its comment \"Max size of any header\". There is no setting for the max size of all headers combined. That\u0027d be a new MAX_HEADERS_SIZE I guess?","accounts_in_message":[],"_revision_number":2},{"id":"c3b02bbd3b939dec7a1f59a9aeb211172332b0b6","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-11 14:45:42.000000000","message":"Patch Set 2:\n\ngholt\n\nwhat do you think give default size 1024 to MAX_HEADER_SIZE\n\nand rename META_OVERALL_SIZE to  MAX_HEADERS_SIZE (in check_meta, this is no difference from meta header and normal header, so I think that we could use it to config overall headers)","accounts_in_message":[],"_revision_number":2},{"id":"27bac3bcfe863b41b4ee02a64a491bb0e6c2e22e","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2013-06-11 15:41:32.000000000","message":"Patch Set 2:\n\nWell, let\u0027s start with: What are you trying to accomplish? Is there something you\u0027re trying fix? Some bug you\u0027re encountering?\n\nThere is a difference between non-meta headers and meta headers in check_metadata. Everything before \"if not key.lower().startswith(prefix):\" is for both, everything after is for meta headers only.\n\nWhy do you want to restrict each header to 1024 instead of the current 8192? Keystone tokens are really long (not sure if they exceed 1024 since I don\u0027t personally use Keystone, but I know they\u0027re really long).","accounts_in_message":[],"_revision_number":2},{"id":"33b1fa93e3692ad85b2243e14038c267212558e2","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-11 15:58:29.000000000","message":"Patch Set 2:\n\nsorry, I miss the \"if not key.lower().startswith(prefix):\" line.\n\nBut I still feel the 8192 is werid. Many HTTP Serves give default headers limit 4096 ~ 8192, but we use it to limit one header line. It\u0027s possible to something about keystone. I\u0027ll take some time on it and reply later.","accounts_in_message":[],"_revision_number":2},{"id":"3fce8b388ea1942b7352d49a349964e99808746a","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-13 06:51:15.000000000","message":"Patch Set 2:\n\ngholt, sam, I have new evidences.\n\n1. 8192 is from keystone PKI token, which has default token size 8192.\n\n2. set 8192 for MAX_HEADER_SIZE seems as same as set unlimit to most of headers. Here PKI token is a very special case. so let\u0027s see what keystone developers did. https://github.com/openstack/keystone/blob/master/etc/keystone.conf.sample#L40\n\nsimply, they set 64 for common param value, and for the very special PKI token, use 8192 instead. their strategy keep both 64 and 8192 meaningful in my option","accounts_in_message":[],"_revision_number":2},{"id":"e0c616c13cb06e73d7613d18f066bcda3f964271","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 03:21:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6317b3509ead74bf249aeff062457f5af4b3600f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 03:36:14.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32178/3/check/gate-swift-pep8/2766 : SUCCESS in 49s\n- http://docs-draft.openstack.org/32178/3/check/gate-swift-docs/2596/doc/build/html/ : SUCCESS in 1m 09s\n- http://logs.openstack.org/32178/3/check/gate-swift-python26/2844 : SUCCESS in 2m 33s\n- http://logs.openstack.org/32178/3/check/gate-swift-python27/2842 : SUCCESS in 1m 09s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-full/23201 : FAILURE in 5m 35s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-quantum/30538 : FAILURE in 7m 29s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-postgres-full/22908 : FAILURE in 5m 37s\n- http://logs.openstack.org/32178/3/check/gate-grenade-devstack-vm/10262 : FAILURE in 14m 06s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"a6f0b0e35b78be43f1d8998e11caa711814f84cd","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 03:50:02.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"87d98477a0198ed3e78bfaa45c7e951aefc68e4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 04:04:16.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32178/3/check/gate-swift-pep8/2767 : SUCCESS in 46s\n- http://docs-draft.openstack.org/32178/3/check/gate-swift-docs/2597/doc/build/html/ : SUCCESS in 1m 00s\n- http://logs.openstack.org/32178/3/check/gate-swift-python26/2845 : SUCCESS in 2m 21s\n- http://logs.openstack.org/32178/3/check/gate-swift-python27/2843 : SUCCESS in 1m 05s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-full/23208 : FAILURE in 6m 38s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-quantum/30545 : FAILURE in 6m 08s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-postgres-full/22915 : FAILURE in 5m 50s\n- http://logs.openstack.org/32178/3/check/gate-grenade-devstack-vm/10269 : FAILURE in 14m 00s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"72ded1162c0326c7b151ad43ea198281b716714b","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 04:06:01.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"82ca0ed2d97444721174b26d4f19770cbd008ed8","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 04:08:41.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"39175993e6a700f25e422d668952724b69140d6a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-14 04:24:14.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/32178/3/check/gate-swift-pep8/2768 : SUCCESS in 48s\n- http://docs-draft.openstack.org/32178/3/check/gate-swift-docs/2598/doc/build/html/ : SUCCESS in 1m 03s\n- http://logs.openstack.org/32178/3/check/gate-swift-python26/2846 : SUCCESS in 1m 51s\n- http://logs.openstack.org/32178/3/check/gate-swift-python27/2844 : SUCCESS in 1m 08s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-full/23211 : FAILURE in 6m 38s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-quantum/30548 : FAILURE in 7m 29s\n- http://logs.openstack.org/32178/3/check/gate-tempest-devstack-vm-postgres-full/22918 : FAILURE in 5m 57s\n- http://logs.openstack.org/32178/3/check/gate-grenade-devstack-vm/10272 : FAILURE in 15m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"08b3fb4a1da3a06eb433ddd0d6d2af7af5a0fbb2","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 08:52:48.000000000","message":"Patch Set 3: Work In Progress","accounts_in_message":[],"_revision_number":3},{"id":"f899342d6c36b28b7b9f168fc814e39f3f75e617","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 08:53:02.000000000","message":"Patch Set 3: Ready For Review","accounts_in_message":[],"_revision_number":3},{"id":"f8f67514312d274b0ffb45ff427c5b9ac12ad493","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-14 08:53:43.000000000","message":"Patch Set 3: Work In Progress","accounts_in_message":[],"_revision_number":3},{"id":"919f36081689cfeb8678672ca097a6c2555f4544","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-18 17:14:03.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7b21c189f4609628fdc60285406d9d1306a7c868","author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"date":"2013-06-18 17:20:12.000000000","message":"Patch Set 4: No score\n\nLooks like this no longer breaks existing clusters, so I\u0027m removing my -2.","accounts_in_message":[],"_revision_number":4},{"id":"294093e1889ca2d1588f2d3175191544a55cfe0d","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-18 17:23:58.000000000","message":"Patch Set 4:\n\nYes, I think I finally finally find out why 8192 why max_header_size. So add this into swift.conf with my thought.\n\nplease also review my idea of new unit test I added","accounts_in_message":[],"_revision_number":4},{"id":"ce33bdb703f7b3143ebaa327eedbee7f30856f12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-18 18:05:06.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32178/4/check/gate-swift-pep8/2806 : SUCCESS in 38s\n- http://docs-draft.openstack.org/32178/4/check/gate-swift-docs/2636/doc/build/html/ : SUCCESS in 1m 00s\n- http://logs.openstack.org/32178/4/check/gate-swift-python26/2884 : SUCCESS in 2m 30s\n- http://logs.openstack.org/32178/4/check/gate-swift-python27/2882 : SUCCESS in 1m 08s\n- http://logs.openstack.org/32178/4/check/gate-tempest-devstack-vm-full/24257 : SUCCESS in 39m 42s\n- http://logs.openstack.org/32178/4/check/gate-tempest-devstack-vm-quantum/31710 : SUCCESS in 16m 57s\n- http://logs.openstack.org/32178/4/check/gate-tempest-devstack-vm-postgres-full/23963 : SUCCESS in 50m 52s\n- http://logs.openstack.org/32178/4/check/gate-grenade-devstack-vm/11148 : FAILURE in 34m 55s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"696f1bbb9f760a7c0c99058660900f689b012384","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2013-06-19 13:33:48.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\nJust for the future: There is an assertTrue with unit testing so you don\u0027t have to assertEquals(x, True).","accounts_in_message":[],"_revision_number":4},{"id":"ceb80c479e8eb01bdd42304f1d7c4c56187b2f6e","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2013-06-19 15:35:58.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\nwait, where did max_token_size come from?","accounts_in_message":[],"_revision_number":4},{"id":"3bf6ceb804d5d5b6cbdf84b36efe6f1b65b9da7d","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-19 15:40:25.000000000","message":"Patch Set 4:\n\nThat is in my last patch set. I try to use a lower size to limit most of header line and 8192 to limit special ones (like keystone PKI token), but not I cancel that thought, because using 8192 as limit of one header line is from eventlet, not keystone. So I update my this patch set without anything about max_token_size. And as a result sam removed his -2","accounts_in_message":[],"_revision_number":4},{"id":"16d7374b156672443f967d7c70d2131254bb2ff6","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-19 15:41:06.000000000","message":"Patch Set 4:\n\nsome mistakes!","accounts_in_message":[],"_revision_number":4},{"id":"2e6198d9b36ff75c2e151f1e0d72c2f80f5cdf19","author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"date":"2013-06-19 15:45:42.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"16ccc833b8e41a4b6cca3ae5009a3e79c2d29b03","author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"date":"2013-06-19 15:49:45.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\nok that looks better :)","accounts_in_message":[],"_revision_number":5},{"id":"c02455607b34bc85a9a365a0fb73bbe76e6f2517","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-06-19 16:04:30.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/92264\n","accounts_in_message":[],"_revision_number":5},{"id":"5c66954fc5ef0d263101e42dac709a427bf68f5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-19 16:26:55.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/32178/5/check/gate-swift-pep8/2830 : SUCCESS in 44s\n- http://docs-draft.openstack.org/32178/5/check/gate-swift-docs/2660/doc/build/html/ : SUCCESS in 1m 08s\n- http://logs.openstack.org/32178/5/check/gate-swift-python26/2908 : SUCCESS in 2m 43s\n- http://logs.openstack.org/32178/5/check/gate-swift-python27/2906 : SUCCESS in 1m 11s\n- http://logs.openstack.org/32178/5/check/gate-tempest-devstack-vm-full/24639 : SUCCESS in 41m 03s\n- http://logs.openstack.org/32178/5/check/gate-tempest-devstack-vm-quantum/32126 : SUCCESS in 19m 36s\n- http://logs.openstack.org/32178/5/check/gate-tempest-devstack-vm-postgres-full/24345 : SUCCESS in 41m 03s\n- http://logs.openstack.org/32178/5/check/gate-grenade-devstack-vm/11467 : FAILURE in 38m 24s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"d3763b6a2055f26754a7465c9f1a08e23f120b37","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2013-06-20 13:13:26.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\nHah, thanks Chuck, I didn\u0027t catch that either.","accounts_in_message":[],"_revision_number":5},{"id":"df62a6c3ae494365044f4783d9f7d14ef7e4b7cc","author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"date":"2013-06-20 13:13:35.000000000","message":"Patch Set 5: Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"caf773fb25c54521d8ea5b9d7ae933e80e9f2f18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 13:13:37.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"194aa2d9de8c10d4a56d2ac6e3680ca3bba9d71b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 14:04:26.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/32178/5/gate/gate-swift-docs/2683/doc/build/html/ : SUCCESS in 1m 05s\n- http://logs.openstack.org/32178/5/gate/gate-swift-pep8/2853 : SUCCESS in 43s\n- http://logs.openstack.org/32178/5/gate/gate-swift-python26/2931 : SUCCESS in 3m 04s\n- http://logs.openstack.org/32178/5/gate/gate-swift-python27/2929 : SUCCESS in 1m 31s\n- http://logs.openstack.org/32178/5/gate/gate-tempest-devstack-vm-full/24957 : SUCCESS in 39m 15s\n- http://logs.openstack.org/32178/5/gate/gate-tempest-devstack-vm-quantum/32468 : SUCCESS in 15m 56s\n- http://logs.openstack.org/32178/5/gate/gate-tempest-devstack-vm-postgres-full/24663 : SUCCESS in 50m 45s\n- http://logs.openstack.org/32178/5/gate/gate-grenade-devstack-vm/11717 : FAILURE in 11m 30s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"f6fbf5b50eb2490b2c74c9dee03ec263755c7347","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-06-20 14:04:26.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"5c8785aaee959177258511d7adbe74afed0cb9fb","revisions":{"c14a80dbbdbeb46cb3acb9254c658eb671403e81":{"kind":"REWORK","_number":1,"created":"2013-06-07 18:13:59.000000000","uploader":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"ref":"refs/changes/78/32178/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/78/32178/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/78/32178/1"}}},"commit":{"parents":[{"commit":"63a5a93734d76a649610df11d24085c0dbe6dc8e","subject":"Merge \"Change to use dash instead of slash\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/63a5a93734d76a649610df11d24085c0dbe6dc8e"}]}],"author":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-07 18:10:36.000000000","tz":480},"committer":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-07 18:10:36.000000000","tz":480},"subject":"Fix usage of MAX_HEADER_SIZE","message":"Fix usage of MAX_HEADER_SIZE\n\nSum the total length of key/value in request headers, and compare it to\nMAX_HEADER_SIZE. If the total size is greate, return a bad request.\n\nAlso add new test cases in test_constraints. The new ones could check\nwhether user set some invalid configration.\n\nChange-Id: I7bb21951d46050163c1b7bceac8d49302b9209f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c14a80dbbdbeb46cb3acb9254c658eb671403e81"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c14a80dbbdbeb46cb3acb9254c658eb671403e81"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"63a5a93734d76a649610df11d24085c0dbe6dc8e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"8030c2cc52ac08f7b64e428e36da1d9a82534b73":{"kind":"REWORK","_number":2,"created":"2013-06-07 18:26:00.000000000","uploader":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"ref":"refs/changes/78/32178/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/78/32178/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/78/32178/2"}}},"commit":{"parents":[{"commit":"63a5a93734d76a649610df11d24085c0dbe6dc8e","subject":"Merge \"Change to use dash instead of slash\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/63a5a93734d76a649610df11d24085c0dbe6dc8e"}]}],"author":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-07 18:10:36.000000000","tz":480},"committer":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-07 18:25:41.000000000","tz":480},"subject":"Fix usage of MAX_HEADER_SIZE","message":"Fix usage of MAX_HEADER_SIZE\n\nSum the total length of key/value in request headers, and compare it to\nMAX_HEADER_SIZE. If the total size is greate, return a bad request.\n\nAlso add new test cases in test_constraints. The new ones could check\nwhether user set some invalid configration.\n\nChange-Id: I7bb21951d46050163c1b7bceac8d49302b9209f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8030c2cc52ac08f7b64e428e36da1d9a82534b73"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8030c2cc52ac08f7b64e428e36da1d9a82534b73"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"63a5a93734d76a649610df11d24085c0dbe6dc8e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"ed6894827cee388b2acc507aca52684776293269":{"kind":"REWORK","_number":3,"created":"2013-06-14 03:21:43.000000000","uploader":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"ref":"refs/changes/78/32178/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/78/32178/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/78/32178/3"}}},"commit":{"parents":[{"commit":"63a5a93734d76a649610df11d24085c0dbe6dc8e","subject":"Merge \"Change to use dash instead of slash\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/63a5a93734d76a649610df11d24085c0dbe6dc8e"}]}],"author":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-07 18:10:36.000000000","tz":480},"committer":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-14 03:19:51.000000000","tz":480},"subject":"Fix MAX_HEADER_SIZE and add MAX_TOKEN_SIZE","message":"Fix MAX_HEADER_SIZE and add MAX_TOKEN_SIZE\n\nMAX_HEADER_SIZE\u0027s default size is 8192 because of Keystone PKI auth\ntoken. But setting 8192 to all headers seems not meaningful for most of\nother headers. This patch add MAX_TOKEN_SIZE to limit \u0027X-Auth-Token\u0027 and\nuse MAX_HEADER_SIZE(defualt 1024) to limit other common headers in a\nreasonable size.\n\nAlso add new test cases in test_constraints. The new ones could check\nwhether user set some invalid configration.\n\nChange-Id: I7bb21951d46050163c1b7bceac8d49302b9209f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ed6894827cee388b2acc507aca52684776293269"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ed6894827cee388b2acc507aca52684776293269"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"63a5a93734d76a649610df11d24085c0dbe6dc8e","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"f12ae8417cc8b1d728c9222c3eef0c10d8b18fd4":{"kind":"REWORK","_number":4,"created":"2013-06-18 17:14:03.000000000","uploader":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"ref":"refs/changes/78/32178/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/78/32178/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/78/32178/4"}}},"commit":{"parents":[{"commit":"f99cf2dcc1a6554e768f682d4e5b7f935788c73f","subject":"Merge \"Fixed some minor doc building errors\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f99cf2dcc1a6554e768f682d4e5b7f935788c73f"}]}],"author":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-18 17:02:37.000000000","tz":480},"committer":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-18 17:02:37.000000000","tz":480},"subject":"Add max_header_size to swift.conf-sample and relative UT","message":"Add max_header_size to swift.conf-sample and relative UT\n\n1. Add explanation of MAX_HEADER_SIZE into swift.conf-sample as same as\nother settings in swift.conf. Especially point out the default size of\nheader line in eventlet is 8192 which is the main reason why we set 8192\nfor MAX_HEADER_SIZE in swift.\n\n2. Add some unit tests to check valid settings in swift.conf. Test cases\nin test_constraints use /etc/swift/swift.conf if exists, and if any\nwrong settings are in it (MAX_META_VALE \u003e MAX_META_OVERALL_SIZE), swift\u0027s\nunit test must fail. These new unit tests is used in this case.\n\nChange-Id: I7bb21951d46050163c1b7bceac8d49302b9209f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f12ae8417cc8b1d728c9222c3eef0c10d8b18fd4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/f12ae8417cc8b1d728c9222c3eef0c10d8b18fd4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f99cf2dcc1a6554e768f682d4e5b7f935788c73f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"5c8785aaee959177258511d7adbe74afed0cb9fb":{"kind":"REWORK","_number":5,"created":"2013-06-19 15:45:42.000000000","uploader":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"ref":"refs/changes/78/32178/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/78/32178/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/78/32178/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/78/32178/5"}}},"commit":{"parents":[{"commit":"60c1bc545e07488eace563d09111f6f4e72ed1c4","subject":"Merge \"Treat directory objects as not found\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/60c1bc545e07488eace563d09111f6f4e72ed1c4"}]}],"author":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-18 17:02:37.000000000","tz":480},"committer":{"name":"Kun Huang","email":"academicgareth@gmail.com","date":"2013-06-19 15:45:38.000000000","tz":480},"subject":"Add max_header_size to swift.conf-sample and relative UT","message":"Add max_header_size to swift.conf-sample and relative UT\n\n1. Add explanation of MAX_HEADER_SIZE into swift.conf-sample as same as\nother settings in swift.conf. Especially point out the default size of\nheader line in eventlet is 8192 which is the main reason why we set 8192\nfor MAX_HEADER_SIZE in swift.\n\n2. Add some unit tests to check valid settings in swift.conf. Test cases\nin test_constraints use /etc/swift/swift.conf if exists, and if any\nwrong settings are in it (MAX_META_VALE \u003e MAX_META_OVERALL_SIZE), swift\u0027s\nunit test must fail. These new unit tests is used in this case.\n\nChange-Id: I7bb21951d46050163c1b7bceac8d49302b9209f7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5c8785aaee959177258511d7adbe74afed0cb9fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5c8785aaee959177258511d7adbe74afed0cb9fb"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"60c1bc545e07488eace563d09111f6f4e72ed1c4","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}