)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9625,"name":"Thiago da Silva","email":"thiagodasilva@gmail.com","username":"thiago"},"change_message_id":"519d946a196252c4ba0735aea172ee59e22179bf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Also added a Timeout class to test.unit to wrap possible long-running"},{"line_number":10,"context_line":"functions. For example, if there is some regression and the \"--yes\""},{"line_number":11,"context_line":"argument is no longer evaluated correctly and the test excepts some"},{"line_number":12,"context_line":"keyboard input, it will be terminated after a few seconds to ensure"},{"line_number":13,"context_line":"there is no long-running blocker on the gate."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_fb92699e","line":11,"range":{"start_line":11,"start_character":55,"end_line":11,"end_character":62},"updated":"2016-07-08 18:09:49.000000000","message":"expects?","commit_id":"e5a6d458829b367ecc16af54a44f629cb1fdcd68"}],"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"fb46756290f4290fdf78abcfd1fd007555a1c071","unresolved":false,"context_lines":[{"line_number":1955,"context_line":"        # Would block without the \u0027yes\u0027 argument"},{"line_number":1956,"context_line":"        self.create_sample_ring()"},{"line_number":1957,"context_line":"        argv \u003d [\"\", self.tmpfile, \"remove\", \"--weight\", \"100\", \"--yes\"]"},{"line_number":1958,"context_line":"        self.assertSystemExit(EXIT_SUCCESS, ringbuilder.main, argv)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    def test_set_info_all_devices(self):"},{"line_number":1961,"context_line":"        # Would block without the \u0027yes\u0027 argument"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_04334af7","line":1958,"updated":"2016-06-07 15:18:30.000000000","message":"should we wrap these assertions is a timeout?","commit_id":"9bb48a4ffbb368b81450735c21998e83748bb34f"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"e22c65383854265eaef3971ed12d1448189116d6","unresolved":false,"context_lines":[{"line_number":1955,"context_line":"        # Would block without the \u0027yes\u0027 argument"},{"line_number":1956,"context_line":"        self.create_sample_ring()"},{"line_number":1957,"context_line":"        argv \u003d [\"\", self.tmpfile, \"remove\", \"--weight\", \"100\", \"--yes\"]"},{"line_number":1958,"context_line":"        self.assertSystemExit(EXIT_SUCCESS, ringbuilder.main, argv)"},{"line_number":1959,"context_line":""},{"line_number":1960,"context_line":"    def test_set_info_all_devices(self):"},{"line_number":1961,"context_line":"        # Would block without the \u0027yes\u0027 argument"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_2dc3c9ee","line":1958,"in_reply_to":"7aa08908_04334af7","updated":"2016-06-07 16:03:06.000000000","message":"Yes, I think that\u0027s a good idea - for example if the opts.yes is no longer evaluated. I just added a wrapper to test.unit.\n\nI think there is already a timeout on the gate itself, but it\u0027s a rather high value IIRC.","commit_id":"9bb48a4ffbb368b81450735c21998e83748bb34f"}]}