)]}'
{"test/unit/common/middleware/test_gatekeeper.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a8f547997be8f1145d8ffd0f9b2ea3b0e81abab2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    x_backend_headers \u003d {\u0027X-Backend-Replication\u0027: \u0027true\u0027,"},{"line_number":75,"context_line":"                         \u0027X-Backend-Replication-Headers\u0027: \u0027stuff\u0027}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    forbidden_headers_out \u003d dict(sysmeta_headers)"},{"line_number":78,"context_line":"    forbidden_headers_out.update(x_backend_headers)"},{"line_number":79,"context_line":"    forbidden_headers_in \u003d dict(forbidden_headers_out)"},{"line_number":80,"context_line":"    shunted_headers_in \u003d {\u0027X-Timestamp\u0027: \u00271455952805.719739\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_23bd9902","line":77,"updated":"2016-06-23 16:11:23.000000000","message":"don\u0027t even need dict() here, I think","commit_id":"be6c51d8355a639f13e8cb5fefff3bd7e0c0b6f0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a040b27c219515ec630962cc8c4e0794c5b24ab7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    x_backend_headers \u003d {\u0027X-Backend-Replication\u0027: \u0027true\u0027,"},{"line_number":75,"context_line":"                         \u0027X-Backend-Replication-Headers\u0027: \u0027stuff\u0027}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    forbidden_headers_out \u003d dict(sysmeta_headers)"},{"line_number":78,"context_line":"    forbidden_headers_out.update(x_backend_headers)"},{"line_number":79,"context_line":"    forbidden_headers_in \u003d dict(forbidden_headers_out)"},{"line_number":80,"context_line":"    shunted_headers_in \u003d {\u0027X-Timestamp\u0027: \u00271455952805.719739\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_82d27c5a","line":77,"in_reply_to":"3aaa91ec_23bd9902","updated":"2016-06-23 20:04:02.000000000","message":"Well, technically yes, but I prefer to not change the code too much to keep the intent of the author.","commit_id":"be6c51d8355a639f13e8cb5fefff3bd7e0c0b6f0"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a8f547997be8f1145d8ffd0f9b2ea3b0e81abab2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    forbidden_headers_out \u003d dict(sysmeta_headers)"},{"line_number":78,"context_line":"    forbidden_headers_out.update(x_backend_headers)"},{"line_number":79,"context_line":"    forbidden_headers_in \u003d dict(forbidden_headers_out)"},{"line_number":80,"context_line":"    shunted_headers_in \u003d {\u0027X-Timestamp\u0027: \u00271455952805.719739\u0027}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _assertHeadersEqual(self, expected, actual):"},{"line_number":83,"context_line":"        for key in expected:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_236119d4","line":80,"updated":"2016-06-23 16:11:23.000000000","message":"You see this transformation as equivalent, but I do not. Yes, the code does the same thing. But you just lost the intent there (possibly). I would rather you keep the x_timestamp_headers as it was.","commit_id":"be6c51d8355a639f13e8cb5fefff3bd7e0c0b6f0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a040b27c219515ec630962cc8c4e0794c5b24ab7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    forbidden_headers_out \u003d dict(sysmeta_headers)"},{"line_number":78,"context_line":"    forbidden_headers_out.update(x_backend_headers)"},{"line_number":79,"context_line":"    forbidden_headers_in \u003d dict(forbidden_headers_out)"},{"line_number":80,"context_line":"    shunted_headers_in \u003d {\u0027X-Timestamp\u0027: \u00271455952805.719739\u0027}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _assertHeadersEqual(self, expected, actual):"},{"line_number":83,"context_line":"        for key in expected:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e2c38087","line":80,"in_reply_to":"3aaa91ec_236119d4","updated":"2016-06-23 20:04:02.000000000","message":"Right, I hesitated to do this change. I agree that it\u0027s better to keep the x_timestamp_headers.","commit_id":"be6c51d8355a639f13e8cb5fefff3bd7e0c0b6f0"}],"test/unit/obj/test_ssync.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6c90783d5fdffbfcfb1910ff325e0b85656ae953","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        tx_tombstones[\u0027o5\u0027][0].delete(t5)"},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        suffixes \u003d set()"},{"line_number":349,"context_line":"        for diskfiles in list(tx_objs.values()) + list(tx_tombstones.values()):"},{"line_number":350,"context_line":"            for df in diskfiles:"},{"line_number":351,"context_line":"                suffixes.add(os.path.basename(os.path.dirname(df._datadir)))"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_16b0c642","line":349,"updated":"2016-07-25 15:04:31.000000000","message":"Wow this is unfortunate - it is begging someone to accidentally remove the list wrappers until we get py34 test coverage :/\n\nFWIW I think I\u0027d prefer:\n\n  tx_all \u003d dict(tx_objs)\n  ts_all.update(tx_tombstones)\n  for diskfiles in tx_all.values():\n      ...\n\nas it is less likely to cause someone with a py2 mindset to want to fix it.","commit_id":"5677a04c8f5d46da80ac4cf8be135549b422772c"}]}