)]}'
{"swift/cli/ring_builder_analyzer.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb4dac34b11b76b31a207a5a8b009f2ee8cdbb3f","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_384c7b9d","line":80,"updated":"2016-06-24 10:43:45.000000000","message":"this is not needed","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"dbfa71a1182ada2facdb238fbdf993b5ba2e44d8","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_50860514","line":80,"in_reply_to":"3aaa91ec_384c7b9d","updated":"2016-06-28 03:17:26.000000000","message":"@Victor, Thank you for your review! it is useful. Add this line,in python2 can check as python3 style.\nFor example:\nIn python2\n\u003e\u003e\u003e from __future__ import print_function\n\u003e\u003e\u003e print \u0027xxxccc\u0027\nSyntaxError: invalid syntax\n\u003e\u003e\u003e print(\u0027xxxccc\u0027)\nxxxccc\n\u003e\u003e\u003e","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"670eb3d1537d341b9b0222130fdf34cb9ebc2070","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6dc9aeac","line":80,"in_reply_to":"3aaa91ec_384c7b9d","updated":"2016-06-28 02:26:17.000000000","message":"Agree with Victor.","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"740da000fb78cdb245abc8b7753391c17da4e3c2","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_689fd55f","line":80,"in_reply_to":"3aaa91ec_50860514","updated":"2016-06-28 07:26:27.000000000","message":"\"Add this line,in python2 can check as python3 style.\"\n\nThe short term goal for Swift is to run unit tests on Python 3 on the voting py34 gate, so the gate will run the check for you.\n\nI disagree that it\u0027s worth it to add the import just to check on Python 2. I prefer to keep the code simple and short.","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fb4dac34b11b76b31a207a5a8b009f2ee8cdbb3f","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        parts_moved, old_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":311,"context_line":"        rb.pretend_min_part_hours_passed()"},{"line_number":312,"context_line":"        print(\"\\tRebalance 1: moved %d parts, balance is %.6f, \\"},{"line_number":313,"context_line":"                %d removed devs\" % ("},{"line_number":314,"context_line":"            parts_moved, old_balance, removed_devs))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_786ba3f1","line":313,"range":{"start_line":313,"start_character":19,"end_line":313,"end_character":26},"updated":"2016-06-24 10:43:45.000000000","message":"unrelated to your change: I\u0027m surprised that \\ at the end of the line: I understand that this code contains a long list of spaces, no? Is it a deliberate choice?","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"0fa9c0bad559246a8bbcba180c338a74c8bd9615","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        parts_moved, old_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":311,"context_line":"        rb.pretend_min_part_hours_passed()"},{"line_number":312,"context_line":"        print(\"\\tRebalance 1: moved %d parts, balance is %.6f, \\"},{"line_number":313,"context_line":"                %d removed devs\" % ("},{"line_number":314,"context_line":"            parts_moved, old_balance, removed_devs))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d0a67552","line":313,"range":{"start_line":313,"start_character":19,"end_line":313,"end_character":26},"in_reply_to":"3aaa91ec_0d3bca9d","updated":"2016-06-28 03:31:16.000000000","message":"Thanks! I will fix it.","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"0fa9c0bad559246a8bbcba180c338a74c8bd9615","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        parts_moved, old_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":311,"context_line":"        rb.pretend_min_part_hours_passed()"},{"line_number":312,"context_line":"        print(\"\\tRebalance 1: moved %d parts, balance is %.6f, \\"},{"line_number":313,"context_line":"                %d removed devs\" % ("},{"line_number":314,"context_line":"            parts_moved, old_balance, removed_devs))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_50ba856f","line":313,"range":{"start_line":313,"start_character":19,"end_line":313,"end_character":26},"in_reply_to":"3aaa91ec_786ba3f1","updated":"2016-06-28 03:31:16.000000000","message":"@Victor, \\ maybe redundant, it can be left out.","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"670eb3d1537d341b9b0222130fdf34cb9ebc2070","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        parts_moved, old_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":311,"context_line":"        rb.pretend_min_part_hours_passed()"},{"line_number":312,"context_line":"        print(\"\\tRebalance 1: moved %d parts, balance is %.6f, \\"},{"line_number":313,"context_line":"                %d removed devs\" % ("},{"line_number":314,"context_line":"            parts_moved, old_balance, removed_devs))"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0d3bca9d","line":313,"range":{"start_line":313,"start_character":19,"end_line":313,"end_character":26},"in_reply_to":"3aaa91ec_786ba3f1","updated":"2016-06-28 02:26:17.000000000","message":"Better:\n        print(\"\\tRebalance 1: moved %d parts, balance is %.6f, %d removed \"\n              \"devs\" % (parts_moved, old_balance, removed_devs))","commit_id":"568bf43bec737d6c9703acbb7399600cec474c5a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"670a820afc4043567c4ff8a8dd4751e4657d65f9","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_287cad1f","line":80,"range":{"start_line":80,"start_character":5,"end_line":80,"end_character":15},"updated":"2016-06-28 07:26:51.000000000","message":"It\u0027s still useless (see my comment on the Patch Set 2).","commit_id":"7e35d82c6920ac3b0851767601e4d2efcd73df0f"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"6497ffaacbd690e6c4be1a06ab9039624f0a6169","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"from __future__ import print_function"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"import argparse"},{"line_number":83,"context_line":"import json"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_d7e780aa","line":80,"range":{"start_line":80,"start_character":5,"end_line":80,"end_character":15},"in_reply_to":"3aaa91ec_287cad1f","updated":"2016-06-28 09:07:30.000000000","message":"@ Victor, Thank you very much! I understand your advice. I agree with you. I will fix it. Thanks!","commit_id":"7e35d82c6920ac3b0851767601e4d2efcd73df0f"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1a480e676afc7491a1fd8dfb34497c732a027313","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            rebalance_number +\u003d 1"},{"line_number":315,"context_line":"            parts_moved, new_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":316,"context_line":"            rb.pretend_min_part_hours_passed()"},{"line_number":317,"context_line":"            print(\"\\tRebalance %d: moved %d parts, balance is %.6f, \\"},{"line_number":318,"context_line":"                    %d removed devs\" % ("},{"line_number":319,"context_line":"                rebalance_number, parts_moved, new_balance, removed_devs))"},{"line_number":320,"context_line":"            if parts_moved \u003d\u003d 0 and removed_devs \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0dae1198","line":317,"range":{"start_line":317,"start_character":68,"end_line":317,"end_character":69},"updated":"2016-06-28 12:33:34.000000000","message":"you should also avoid \\ here (even if it\u0027s not directly related to your change), as you did on the previous print.","commit_id":"7b425e0fa7c7c6b2ee2d93cf7230bbac9238c4b0"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"c02d9d3fa016091d5467d9a5db04ff9df6656b68","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            rebalance_number +\u003d 1"},{"line_number":315,"context_line":"            parts_moved, new_balance, removed_devs \u003d rb.rebalance(seed\u003dseed)"},{"line_number":316,"context_line":"            rb.pretend_min_part_hours_passed()"},{"line_number":317,"context_line":"            print(\"\\tRebalance %d: moved %d parts, balance is %.6f, \\"},{"line_number":318,"context_line":"                    %d removed devs\" % ("},{"line_number":319,"context_line":"                rebalance_number, parts_moved, new_balance, removed_devs))"},{"line_number":320,"context_line":"            if parts_moved \u003d\u003d 0 and removed_devs \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_6385fd57","line":317,"range":{"start_line":317,"start_character":68,"end_line":317,"end_character":69},"in_reply_to":"3aaa91ec_0dae1198","updated":"2016-06-29 03:53:25.000000000","message":"@Victor, Thank you very much! I will fix it.","commit_id":"7b425e0fa7c7c6b2ee2d93cf7230bbac9238c4b0"}]}