)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"b24bc3a25f05e7bae7258996e988d098e447a269","unresolved":false,"context_lines":[{"line_number":10,"context_line":"object being a SLO is a property of the .data file.  Revert the change"},{"line_number":11,"context_line":"from 4500ff which attempts to correctly handle X-Static-Large-Object"},{"line_number":12,"context_line":"metadata on a POST, but is subject to a race if the most recent SLO"},{"line_number":13,"context_line":".data isn\u0027t available during the POST.  Instead this chagne adusts the"},{"line_number":14,"context_line":"reading of metdata such that the X-Static-Large-Object metadata is"},{"line_number":15,"context_line":"always preserved from the metadata on the datafile and bleeds through"},{"line_number":16,"context_line":"a .meta if any."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_17ed9725","line":13,"range":{"start_line":13,"start_character":60,"end_line":13,"end_character":66},"updated":"2016-06-28 01:31:29.000000000","message":"s/adusts/adjusts/","commit_id":"da59c1c39c7ead0afd75b9b16f2d4c7b1eed0756"},{"author":{"_account_id":14766,"name":"Kazuhiro MIYAHARA","email":"miyahara.kazuhiro@lab.ntt.co.jp","username":"miyahara"},"change_message_id":"17b95eecd44bb26345b4a2c0ca9b3b9b8b5531b4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"object being a SLO is a property of the .data file.  Revert the change"},{"line_number":11,"context_line":"from 4500ff which attempts to correctly handle X-Static-Large-Object"},{"line_number":12,"context_line":"metadata on a POST, but is subject to a race if the most recent SLO"},{"line_number":13,"context_line":".data isn\u0027t available during the POST.  Instead this chagne adusts the"},{"line_number":14,"context_line":"reading of metdata such that the X-Static-Large-Object metadata is"},{"line_number":15,"context_line":"always preserved from the metadata on the datafile and bleeds through"},{"line_number":16,"context_line":"a .meta if any."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_89f0fc68","line":13,"range":{"start_line":13,"start_character":53,"end_line":13,"end_character":59},"updated":"2017-01-30 06:39:27.000000000","message":"s/chagne/change/","commit_id":"da59c1c39c7ead0afd75b9b16f2d4c7b1eed0756"}],"swift/obj/diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"3c9d5c1b6a4745892fdbd808f324ffe9ac887025","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# These are system-set metadata keys that cannot be changed with a POST."},{"line_number":81,"context_line":"# They should be lowercase."},{"line_number":82,"context_line":"RESERVED_DATAFILE_META \u003d set(\u0027content-length deleted etag\u0027.split())"},{"line_number":83,"context_line":"DATAFILE_SYSTEM_META \u003d set(\u0027x-static-large-object\u0027.split())"},{"line_number":84,"context_line":"DATADIR_BASE \u003d \u0027objects\u0027"},{"line_number":85,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":86,"context_line":"TMP_BASE \u003d \u0027tmp\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_36908aec","line":83,"updated":"2016-06-28 08:19:00.000000000","message":"DATAFILE_SYSTEM_META gets imported in mem_diskfile, so the import should need to be changed, but its curious that its value can be changed here with no impact in mem_diskfile.\n\nAlso, the split() seems unnecessary, just define the list of one item?","commit_id":"da59c1c39c7ead0afd75b9b16f2d4c7b1eed0756"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"21d64891463ceaf65886484a10c194bbcf3b80d7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# These are system-set metadata keys that cannot be changed with a POST."},{"line_number":81,"context_line":"# They should be lowercase."},{"line_number":82,"context_line":"RESERVED_DATAFILE_META \u003d set(\u0027content-length deleted etag\u0027.split())"},{"line_number":83,"context_line":"DATAFILE_SYSTEM_META \u003d set(\u0027x-static-large-object\u0027.split())"},{"line_number":84,"context_line":"DATADIR_BASE \u003d \u0027objects\u0027"},{"line_number":85,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":86,"context_line":"TMP_BASE \u003d \u0027tmp\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ac5b8a2d","line":83,"updated":"2016-06-28 09:32:18.000000000","message":"I thought that too Alistair (the extra split()). However because its going into a set, a set of a string is all the characters, so it either needs to split() or be a list/tuple:\n\n  set((\u0027x-static-large-object\u0027,))","commit_id":"da59c1c39c7ead0afd75b9b16f2d4c7b1eed0756"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"26d51d733cb2eed4f28a3744b4f6d28bc0a43ba8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# These are system-set metadata keys that cannot be changed with a POST."},{"line_number":81,"context_line":"# They should be lowercase."},{"line_number":82,"context_line":"RESERVED_DATAFILE_META \u003d set(\u0027content-length deleted etag\u0027.split())"},{"line_number":83,"context_line":"DATAFILE_SYSTEM_META \u003d set(\u0027x-static-large-object\u0027.split())"},{"line_number":84,"context_line":"DATADIR_BASE \u003d \u0027objects\u0027"},{"line_number":85,"context_line":"ASYNCDIR_BASE \u003d \u0027async_pending\u0027"},{"line_number":86,"context_line":"TMP_BASE \u003d \u0027tmp\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_a31aa06c","line":83,"in_reply_to":"3aaa91ec_ac5b8a2d","updated":"2016-07-03 04:03:33.000000000","message":"(Or, since we finally dropped 2.6 support:\n\n  {\u0027x-static-large-object\u0027}\n\n)","commit_id":"da59c1c39c7ead0afd75b9b16f2d4c7b1eed0756"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":4608,"name":"Kota Tsuyuzaki","email":"bloodeagle40234@gmail.com","username":"tsuyuzaki-kota"},"change_message_id":"7c215dae3f11a2e7208e1a8c7bfbbd119f3c5b00","unresolved":false,"context_lines":[{"line_number":3162,"context_line":"        with df.open():"},{"line_number":3163,"context_line":"            # non-fast-post updateable keys are preserved"},{"line_number":3164,"context_line":"            self.assertEqual(\u0027text/garbage\u0027, df._metadata[\u0027Content-Type\u0027])"},{"line_number":3165,"context_line":"            self.assertEqual(\u0027True\u0027, df._metadata[\u0027X-Static-Large-Object\u0027])"},{"line_number":3166,"context_line":""},{"line_number":3167,"context_line":"    def test_disk_file_reader_iter(self):"},{"line_number":3168,"context_line":"        df, df_data \u003d self._create_test_file(\u00271234567890\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_ceab5273","line":3165,"updated":"2017-10-10 07:36:30.000000000","message":"OK, w/o change, this assertion failed as expected.","commit_id":"36a843be73e2d58c3fe49a049d514b421124bd06"}]}