)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2696,"name":"Darrell Bishop","email":"dbishop@nvidia.com","username":"darrellb"},"change_message_id":"811908480b0c674ec143bb2295a63020c1d4ff6c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"So, there\u0027s two cases here. In one case, we have memcache enabled;"},{"line_number":10,"context_line":"account info gets cached in the usual place, and tempurl keys get"},{"line_number":11,"context_line":"cached separately. In the other case, we have no cache. In neither"},{"line_number":12,"context_line":"case does is anything gained by having TempURL caching keys separately"},{"line_number":13,"context_line":"from the account info."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit removes TempURL\u0027s custom caching logic and makes it rely"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2F2vY%3D","line":12,"updated":"2013-06-19 18:17:42.000000000","message":"Extra word in here, I think?  Just remove \"does\"?","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"ac20e4a4771643326a4811125d2dc71cba385180","unresolved":false,"context_lines":[{"line_number":9,"context_line":"So, there\u0027s two cases here. In one case, we have memcache enabled;"},{"line_number":10,"context_line":"account info gets cached in the usual place, and tempurl keys get"},{"line_number":11,"context_line":"cached separately. In the other case, we have no cache. In neither"},{"line_number":12,"context_line":"case does is anything gained by having TempURL caching keys separately"},{"line_number":13,"context_line":"from the account info."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit removes TempURL\u0027s custom caching logic and makes it rely"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPn%2F%2F2sU%3D","line":12,"in_reply_to":"AAAAPn%2F%2F2vY%3D","updated":"2013-06-19 18:34:38.000000000","message":"Yep. Will fix.","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"}],"test/unit/common/middleware/test_tempurl.py":[{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"953ff68c025581612b7c5ea3a258be33869ae392","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEquals(resp.status_int, 200)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def assert_valid_sig(self, expires, path, keys, sig):"},{"line_number":99,"context_line":"        _junk, account, _junk, _junk \u003d split_path(path, 2, 4)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        req \u003d self._make_request(path, keys\u003dkeys,"},{"line_number":102,"context_line":"            environ\u003d{\u0027QUERY_STRING\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F3eI%3D","line":99,"updated":"2013-06-19 14:07:40.000000000","message":"Why\u0027s this here?","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"ac20e4a4771643326a4811125d2dc71cba385180","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.assertEquals(resp.status_int, 200)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def assert_valid_sig(self, expires, path, keys, sig):"},{"line_number":99,"context_line":"        _junk, account, _junk, _junk \u003d split_path(path, 2, 4)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        req \u003d self._make_request(path, keys\u003dkeys,"},{"line_number":102,"context_line":"            environ\u003d{\u0027QUERY_STRING\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2sg%3D","line":99,"in_reply_to":"AAAAPn%2F%2F3eI%3D","updated":"2013-06-19 18:34:38.000000000","message":"Ooh, leftovers!\n\nWhen I was writing this, I was wishy-washy as to where to extract the account from the path. Looks like I settled on doing it in _make_request, but forgot to remove this one.","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"953ff68c025581612b7c5ea3a258be33869ae392","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        key \u003d \u0027abc\u0027"},{"line_number":138,"context_line":"        hmac_body \u003d \u0027%s\\n%s\\n%s\u0027 % (method, expires, path)"},{"line_number":139,"context_line":"        sig \u003d hmac.new(key, hmac_body, sha1).hexdigest()"},{"line_number":140,"context_line":"        req \u003d self._make_request(path, keys\u003d[key], environ\u003d{"},{"line_number":141,"context_line":"            \u0027QUERY_STRING\u0027: \u0027temp_url_sig\u003d%s\u0026temp_url_expires\u003d%s\u0026\u0027"},{"line_number":142,"context_line":"            \u0027filename\u003dbob%%20%%22killer%%22.txt\u0027 % (sig, expires)})"},{"line_number":143,"context_line":"        self.tempurl.app \u003d FakeApp(iter([(\u0027200 Ok\u0027, (), \u0027123\u0027)]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F3d0%3D","line":140,"updated":"2013-06-19 14:07:40.000000000","message":"Completely silly, but it\u0027s odd to have some [x] and some (x,)","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"ac20e4a4771643326a4811125d2dc71cba385180","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        key \u003d \u0027abc\u0027"},{"line_number":138,"context_line":"        hmac_body \u003d \u0027%s\\n%s\\n%s\u0027 % (method, expires, path)"},{"line_number":139,"context_line":"        sig \u003d hmac.new(key, hmac_body, sha1).hexdigest()"},{"line_number":140,"context_line":"        req \u003d self._make_request(path, keys\u003d[key], environ\u003d{"},{"line_number":141,"context_line":"            \u0027QUERY_STRING\u0027: \u0027temp_url_sig\u003d%s\u0026temp_url_expires\u003d%s\u0026\u0027"},{"line_number":142,"context_line":"            \u0027filename\u003dbob%%20%%22killer%%22.txt\u0027 % (sig, expires)})"},{"line_number":143,"context_line":"        self.tempurl.app \u003d FakeApp(iter([(\u0027200 Ok\u0027, (), \u0027123\u0027)]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F2sc%3D","line":140,"in_reply_to":"AAAAPn%2F%2F3d0%3D","updated":"2013-06-19 18:34:38.000000000","message":"Agreed.","commit_id":"78498d1a84ee5cac2d610d08caa1a329434928bc"}]}