)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"610f3fa84598f7350eb8bd6835ca4f6390874970","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        device_path \u003d self.construct_dev_path(device)"},{"line_number":1117,"context_line":"        async_dir \u003d os.path.join(device_path, get_async_dir(policy))"},{"line_number":1118,"context_line":"        tmp_dir \u003d os.path.join(device_path, get_tmp_dir(policy))"},{"line_number":1119,"context_line":"        if not os.path.exists(tmp_dir):"},{"line_number":1120,"context_line":"            mkdirs(tmp_dir)"},{"line_number":1121,"context_line":"        ohash \u003d hash_path(account, container, obj)"},{"line_number":1122,"context_line":"        write_pickle("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_ecc54c3c","line":1119,"updated":"2016-07-05 21:26:14.000000000","message":"What will happen if tmp_dir exists but is not a directory? Presumably we\u0027ll fail down in write_pickle somewhere?\n\n(FWIW, this would previously raise an OSError with errno\u003d\u003dEEXIST in such a case.)\n\nDon\u0027t we already do this check, down in mkdirs? See https://github.com/openstack/swift/blob/d4a7ad0/swift/common/utils.py#L1064","commit_id":"76b6a00a2243cbd851ea2f700c84dc00a190f254"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"8867403095e67f2ad55f2cb25dd3bbc0f01f9854","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        device_path \u003d self.construct_dev_path(device)"},{"line_number":1117,"context_line":"        async_dir \u003d os.path.join(device_path, get_async_dir(policy))"},{"line_number":1118,"context_line":"        tmp_dir \u003d os.path.join(device_path, get_tmp_dir(policy))"},{"line_number":1119,"context_line":"        if not os.path.exists(tmp_dir):"},{"line_number":1120,"context_line":"            mkdirs(tmp_dir)"},{"line_number":1121,"context_line":"        ohash \u003d hash_path(account, container, obj)"},{"line_number":1122,"context_line":"        write_pickle("}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_33ee7eb4","line":1119,"in_reply_to":"1aa78d24_ecc54c3c","updated":"2016-07-06 08:58:43.000000000","message":"If tmp_dir is not a dir with this change we\u0027ll get \"OSError: [Errno 20] Not a directory\" raised from write_pickle.\n\nWe do check for isdir in mkdirs, but as you say that function raises EEXIST if the path is not a dir.","commit_id":"76b6a00a2243cbd851ea2f700c84dc00a190f254"}]}