)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"272fd7372640c17e082a255bcf99f38b5a180aac","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a new configuration option \u0027servers_per_port_type\u0027 to choose on which"},{"line_number":10,"context_line":"port the object-server must bind when servers_per_port is enabled. It can"},{"line_number":11,"context_line":"be \u0027port\u0027 (the default, which does not change the current behavior), or"},{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a semicolon."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_fc55b1c1","line":12,"updated":"2017-03-10 01:37:04.000000000","message":"s/semicolon/comma/","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"9f6e5cd758f9f5625eaffdb460fc362a1221a66a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add a new configuration option \u0027servers_per_port_type\u0027 to choose on which"},{"line_number":10,"context_line":"port the object-server must bind when servers_per_port is enabled. It can"},{"line_number":11,"context_line":"be \u0027port\u0027 (the default, which does not change the current behavior), or"},{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a semicolon."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_2bcc5869","line":12,"in_reply_to":"9a30ddce_fc55b1c1","updated":"2017-03-10 08:46:07.000000000","message":"Done","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"00d4045e1aad518c7df5da7bef55024f98165699","unresolved":false,"context_lines":[{"line_number":11,"context_line":"be \u0027port\u0027 (the default, which does not change the current behavior), or"},{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_86d61bef","line":14,"updated":"2017-03-10 09:09:07.000000000","message":"s/per devices/per device","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"f597024305e9aa8f8c97e514bd2104335c0c7610","unresolved":false,"context_lines":[{"line_number":11,"context_line":"be \u0027port\u0027 (the default, which does not change the current behavior), or"},{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_6b472b77","line":14,"in_reply_to":"9a30ddce_86d61bef","updated":"2017-03-10 10:55:45.000000000","message":"Done","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"00d4045e1aad518c7df5da7bef55024f98165699","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"},{"line_number":18,"context_line":"    servers_per_port_type \u003d port, replication_port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_c6d9f358","line":15,"range":{"start_line":15,"start_character":64,"end_line":15,"end_character":71},"updated":"2017-03-10 09:09:07.000000000","message":"s/clients/clients\u0027","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"00d4045e1aad518c7df5da7bef55024f98165699","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"},{"line_number":18,"context_line":"    servers_per_port_type \u003d port, replication_port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_461fc307","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":35},"updated":"2017-03-10 09:09:07.000000000","message":"s/differents/different","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"f597024305e9aa8f8c97e514bd2104335c0c7610","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"},{"line_number":18,"context_line":"    servers_per_port_type \u003d port, replication_port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_cb565729","line":15,"range":{"start_line":15,"start_character":25,"end_line":15,"end_character":35},"in_reply_to":"9a30ddce_461fc307","updated":"2017-03-10 10:55:45.000000000","message":"Done","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"f597024305e9aa8f8c97e514bd2104335c0c7610","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\u0027replication_port\u0027, or both separated by a comma."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The following configuration will create two workers per devices if port"},{"line_number":15,"context_line":"and replication_port are differents in the ring. One worker for clients"},{"line_number":16,"context_line":"traffic and one worker for replication traffic:"},{"line_number":17,"context_line":"    servers_per_port \u003d 1"},{"line_number":18,"context_line":"    servers_per_port_type \u003d port, replication_port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a30ddce_2b38d3ee","line":15,"range":{"start_line":15,"start_character":64,"end_line":15,"end_character":71},"in_reply_to":"9a30ddce_c6d9f358","updated":"2017-03-10 10:55:45.000000000","message":"Done","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"}],"doc/source/deployment_guide.rst":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"272fd7372640c17e082a255bcf99f38b5a180aac","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                                             setting \u0027port\u0027, or the replication_port,"},{"line_number":470,"context_line":"                                             by setting \u0027replication_port\u0027, or both,"},{"line_number":471,"context_line":"                                             be setting both values separated by a"},{"line_number":472,"context_line":"                                             semicolon. This is useful when you want to"},{"line_number":473,"context_line":"                                             separate workers for client requests and"},{"line_number":474,"context_line":"                                             replication requests, as replication"},{"line_number":475,"context_line":"                                             requests can be IO-intensive and sometimes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_1c5b65f7","line":472,"updated":"2017-03-10 01:37:04.000000000","message":"It\u0027s actually seperated by a comma (according to the code).","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"9f6e5cd758f9f5625eaffdb460fc362a1221a66a","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                                             setting \u0027port\u0027, or the replication_port,"},{"line_number":470,"context_line":"                                             by setting \u0027replication_port\u0027, or both,"},{"line_number":471,"context_line":"                                             be setting both values separated by a"},{"line_number":472,"context_line":"                                             semicolon. This is useful when you want to"},{"line_number":473,"context_line":"                                             separate workers for client requests and"},{"line_number":474,"context_line":"                                             replication requests, as replication"},{"line_number":475,"context_line":"                                             requests can be IO-intensive and sometimes"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a30ddce_ab05a87a","line":472,"in_reply_to":"9a30ddce_1c5b65f7","updated":"2017-03-10 08:46:07.000000000","message":"right, i\u0027m always mixing up this 2 words in english :)","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"00d4045e1aad518c7df5da7bef55024f98165699","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                             bind. It can be the standard port, by"},{"line_number":469,"context_line":"                                             setting \u0027port\u0027, or the replication_port,"},{"line_number":470,"context_line":"                                             by setting \u0027replication_port\u0027, or both,"},{"line_number":471,"context_line":"                                             be setting both values separated by a"},{"line_number":472,"context_line":"                                             comma. This is useful when you want to"},{"line_number":473,"context_line":"                                             separate workers for client requests and"},{"line_number":474,"context_line":"                                             replication requests, as replication"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_c6057311","line":471,"updated":"2017-03-10 09:09:07.000000000","message":"s/be/by","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"f597024305e9aa8f8c97e514bd2104335c0c7610","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                                             bind. It can be the standard port, by"},{"line_number":469,"context_line":"                                             setting \u0027port\u0027, or the replication_port,"},{"line_number":470,"context_line":"                                             by setting \u0027replication_port\u0027, or both,"},{"line_number":471,"context_line":"                                             be setting both values separated by a"},{"line_number":472,"context_line":"                                             comma. This is useful when you want to"},{"line_number":473,"context_line":"                                             separate workers for client requests and"},{"line_number":474,"context_line":"                                             replication requests, as replication"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9a30ddce_8b27ffc8","line":471,"in_reply_to":"9a30ddce_c6057311","updated":"2017-03-10 10:55:45.000000000","message":"Done","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"}],"etc/object-server.conf-sample":[{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"00d4045e1aad518c7df5da7bef55024f98165699","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# If servers_per_port is enabled, define for what type of port processes must"},{"line_number":25,"context_line":"# be started. Can be \u0027port\u0027, \u0027replication_port\u0027, or both separated by a semi"},{"line_number":26,"context_line":"# colon"},{"line_number":27,"context_line":"# servers_per_port_type \u003d port"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# Maximum concurrent requests per worker"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a30ddce_067f8b66","line":26,"updated":"2017-03-10 09:09:07.000000000","message":"s/semi colon/comma per the code","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"f597024305e9aa8f8c97e514bd2104335c0c7610","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"# If servers_per_port is enabled, define for what type of port processes must"},{"line_number":25,"context_line":"# be started. Can be \u0027port\u0027, \u0027replication_port\u0027, or both separated by a semi"},{"line_number":26,"context_line":"# colon"},{"line_number":27,"context_line":"# servers_per_port_type \u003d port"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# Maximum concurrent requests per worker"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9a30ddce_eb2a3b8f","line":26,"in_reply_to":"9a30ddce_067f8b66","updated":"2017-03-10 10:55:45.000000000","message":"Done","commit_id":"79a8fd7b7d18ac6dc7e58e43aeda963319e29e1e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"4baa31ea4a87e43a2f04770e36e9389ec1f3380d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# If servers_per_port is enabled, define for what type of port processes must"},{"line_number":26,"context_line":"# be started. Can be \u0027port\u0027, \u0027replication_port\u0027, or both separated by a comma"},{"line_number":27,"context_line":"# servers_per_port_type \u003d port"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# Maximum concurrent requests per worker"},{"line_number":30,"context_line":"# max_clients \u003d 1024"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3fa7e38b_b90455c7","line":27,"updated":"2019-10-30 02:54:33.000000000","message":"Just a random question. Would it ever make sense to have a different servers_per_port for normal and replication traffic? Ie, I need 6 servers_per_port on the user traffic \u0027port\u0027 and 4 on the \u0027replication_port\u0027?\n\nI should probably just go look at the code, or go set it up in an SAIO, but what happens currently if the port and replication port is the same? but the ip and replication ip are different. If we\u0027re listening on 0.0.0.0, currently if the servers_per_port were way 4, should there be 4 processes listening on the same port for both normal and replication, with differnt IPs?","commit_id":"cbe5031078cb6b268b726b6d11a9f7195efbad20"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6cf9857a0dcf080e489725994628754b93b1e82c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# If servers_per_port is enabled, define for what type of port processes must"},{"line_number":26,"context_line":"# be started. Can be \u0027port\u0027, \u0027replication_port\u0027, or both separated by a comma"},{"line_number":27,"context_line":"# servers_per_port_type \u003d port"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# Maximum concurrent requests per worker"},{"line_number":30,"context_line":"# max_clients \u003d 1024"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3fa7e38b_8259798e","line":27,"in_reply_to":"3fa7e38b_b90455c7","updated":"2020-01-31 18:19:09.000000000","message":"FWIW, we typically run with separate config files for user traffic and replication, which makes this fairly easy to twiddle (and you don\u0027t have to listen on all IPs).","commit_id":"cbe5031078cb6b268b726b6d11a9f7195efbad20"}],"swift/common/storage_policy.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"713bd849c6867f63fba536a281da00ef3167513c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                if \u0027replication_port\u0027 in self.ports_type:"},{"line_number":80,"context_line":"                    self.portsets_by_ring_path[serialized_path].update(set("},{"line_number":81,"context_line":"                        dev[\u0027replication_port\u0027] for dev in devs"},{"line_number":82,"context_line":"                        if dev and dev[\u0027ip\u0027] in self.my_ips))"},{"line_number":83,"context_line":"                self.mtimes_by_ring_path[serialized_path] \u003d new_mtime"},{"line_number":84,"context_line":"                # No \"break\" here so that the above line will update the"},{"line_number":85,"context_line":"                # mtimes_by_ring_path entry for any ring that changes, not just"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_62079dca","line":82,"range":{"start_line":82,"start_character":40,"end_line":82,"end_character":42},"updated":"2020-01-31 18:15:56.000000000","message":"ip, or replication_ip?","commit_id":"47060c889736d2a8fd763d0587180b30ce21c1ad"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0f9707d14c6b6cc76e568defeb70c91e05a7a0a7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                    self.portsets_by_ring_path[serialized_path].update(set("},{"line_number":81,"context_line":"                        dev[\u0027replication_port\u0027] for dev in devs"},{"line_number":82,"context_line":"                        if dev and dev[\u0027ip\u0027] in self.my_ips))"},{"line_number":83,"context_line":"                self.mtimes_by_ring_path[serialized_path] \u003d new_mtime"},{"line_number":84,"context_line":"                # No \"break\" here so that the above line will update the"},{"line_number":85,"context_line":"                # mtimes_by_ring_path entry for any ring that changes, not just"},{"line_number":86,"context_line":"                # the first one we notice."}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_e69a5360","line":83,"updated":"2020-03-19 21:02:52.000000000","message":"Yeah.\n\nAlso, what is going to happen if someone types:\n\nservers_per_port_type \u003d replication_purt\n\nIt is a mistake, but what happens then?\nWhat I\u0027m trying to avoid is this scenario:\nhttps://twitter.com/ChiaoArthur/status/1057192400471224320\n\nI think it would be great if we flagged unsupported\ntypes and possibly refused to start outright.","commit_id":"47060c889736d2a8fd763d0587180b30ce21c1ad"}],"swift/common/wsgi.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"272fd7372640c17e082a255bcf99f38b5a180aac","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.servers_per_port_type \u003d ["},{"line_number":708,"context_line":"            a.strip()"},{"line_number":709,"context_line":"            for a in conf.get(\u0027servers_per_port_type\u0027, \u0027port\u0027).split(\u0027,\u0027)"},{"line_number":710,"context_line":"            if a.strip()]"},{"line_number":711,"context_line":"        self.swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":712,"context_line":"        self.ring_check_interval \u003d int(conf.get(\u0027ring_check_interval\u0027, 15))"},{"line_number":713,"context_line":"        self.port_pid_state \u003d PortPidState(servers_per_port, logger)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_3c74a966","line":710,"updated":"2017-03-10 01:37:04.000000000","message":"Cant we just use list_from_csv here?","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"9f6e5cd758f9f5625eaffdb460fc362a1221a66a","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.servers_per_port_type \u003d ["},{"line_number":708,"context_line":"            a.strip()"},{"line_number":709,"context_line":"            for a in conf.get(\u0027servers_per_port_type\u0027, \u0027port\u0027).split(\u0027,\u0027)"},{"line_number":710,"context_line":"            if a.strip()]"},{"line_number":711,"context_line":"        self.swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":712,"context_line":"        self.ring_check_interval \u003d int(conf.get(\u0027ring_check_interval\u0027, 15))"},{"line_number":713,"context_line":"        self.port_pid_state \u003d PortPidState(servers_per_port, logger)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_0b01546a","line":710,"in_reply_to":"9a30ddce_3c74a966","updated":"2017-03-10 08:46:07.000000000","message":"Done","commit_id":"9b1c8fd8723b23e22346a95232e568db8f0847f2"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"0f9707d14c6b6cc76e568defeb70c91e05a7a0a7","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        self.logger \u003d logger"},{"line_number":984,"context_line":"        self.servers_per_port \u003d servers_per_port"},{"line_number":985,"context_line":"        self.servers_per_port_type \u003d list_from_csv("},{"line_number":986,"context_line":"            conf.get(\u0027servers_per_port_type\u0027, \u0027port\u0027))"},{"line_number":987,"context_line":"        self.swift_dir \u003d conf.get(\u0027swift_dir\u0027, \u0027/etc/swift\u0027)"},{"line_number":988,"context_line":"        self.ring_check_interval \u003d int(conf.get(\u0027ring_check_interval\u0027, 15))"},{"line_number":989,"context_line":"        self.port_pid_state \u003d PortPidState(servers_per_port, logger)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1fa4df85_06bd2fd7","line":986,"updated":"2020-03-19 21:02:52.000000000","message":"Is this necessary to save in the class self.? Not that I mind too much, but still.","commit_id":"47060c889736d2a8fd763d0587180b30ce21c1ad"}],"test/unit/common/test_storage_policy.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"713bd849c6867f63fba536a281da00ef3167513c","unresolved":false,"context_lines":[{"line_number":1273,"context_line":"                                          stub_objs\u003ddevs_by_ring_name1)"},{"line_number":1274,"context_line":"            self.assertEqual(set(["},{"line_number":1275,"context_line":"                6206, 6208, 6211,"},{"line_number":1276,"context_line":"            ]), cache.all_bind_ports_for_node())"},{"line_number":1277,"context_line":"            mock_ld.reset_mock()"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"            # Test with port and replication_port"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_e2138d01","line":1276,"updated":"2020-01-31 18:15:56.000000000","message":"Test pops nicely if I back out the core of the change:\n\n AssertionError: Items in the first set but not the second:\n 6208\n 6211\n 6206\n Items in the second set but not the first:\n 6008\n 6011\n 6006","commit_id":"47060c889736d2a8fd763d0587180b30ce21c1ad"}]}