)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b1d30242a436ca87322a1951b9d085a9b175d2a7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Python3 fix httplib import issues"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace httplib in eventlet patched"},{"line_number":10,"context_line":"import with six.moves.http_client"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f7dbcecbbecd7cb69b7031faa39f35bcfadcfc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_5bc96c58","line":10,"updated":"2016-07-21 04:19:24.000000000","message":"This commit message still isn\u0027t very clear. Also you are doing more then just dealing with httplib, your changing a configparser too.\nMaybe is should be something like:\n\n  Python3 eventlet patched httplib fix\n\n  This change patches the correct eventlet monkey patched httplib\u0027s\n  _MAXHEADERS as required by Swift.\n\n  It also makes the configparser inside the copy middleware py3\n  compatable.","commit_id":"a01343370ed791e5dbffca42f2319e8f310919a9"}],"swift/common/bufferedhttp.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"159083452b0d973bcb03d266fa16d03fe909c64e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from six.moves.urllib.parse import quote"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"httplib \u003d eventlet.import_patched(\u0027six.moves.http_client\u0027)"},{"line_number":42,"context_line":"httplib._MAXHEADERS \u003d constraints.MAX_HEADER_COUNT"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_fb0660cc","line":41,"updated":"2016-07-21 04:07:40.000000000","message":"Nice one Tim, I started looking at this last night and was worried about the above, what we are doing here is increasing the _MAXHEADERS in eventlet\u0027s patched version of httplib, since httplib decided to add a _MAXHEADERS about a year ago which broke swift.\n\neventlet monkey patches it, and this allows us to define our own _MAXHEADERS. The http.client (py3\u0027s version) does the same thing, that is limits the size of _MAXHEADERS to 100. So nice fix Tim!","commit_id":"2aecc071560a16e28de7a1922afc1202987b8d52"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"e920dcb03c371947c0f62a4c200ad4457e4359f8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from six.moves.urllib.parse import quote"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"httplib \u003d eventlet.import_patched(\u0027six.moves.http_client\u0027)"},{"line_number":42,"context_line":"httplib._MAXHEADERS \u003d constraints.MAX_HEADER_COUNT"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_a43220f0","line":41,"updated":"2016-07-20 16:18:59.000000000","message":"This is what\u0027s causing the functest failures. I\u0027m not clear on why, but the _MAXHEADERS override doesn\u0027t get applied properly. You\u0027ll want something like\n\n if six.PY2:\n     httplib \u003d eventlet.import_patched(\u0027httplib\u0027)\n else:\n     httplib \u003d eventlet.import_patched(\u0027http.client\u0027)","commit_id":"2aecc071560a16e28de7a1922afc1202987b8d52"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"5e618d4f033f32d00448b2aabd7d388629f2409f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from six.moves.urllib.parse import quote"},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"httplib \u003d eventlet.import_patched(\u0027six.moves.http_client\u0027)"},{"line_number":42,"context_line":"httplib._MAXHEADERS \u003d constraints.MAX_HEADER_COUNT"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_af04b917","line":41,"in_reply_to":"dada55a8_a43220f0","updated":"2016-07-20 16:47:39.000000000","message":"Thanks for the review will update.","commit_id":"2aecc071560a16e28de7a1922afc1202987b8d52"}]}