)]}'
{"swift/cli/ringbuilder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5d50bcc86a54252f0933707c1474a44b02e41c9d","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        exit(EXIT_ERROR)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"def _make_display_device_table(builder):"},{"line_number":392,"context_line":"    ip_width \u003d 10"},{"line_number":393,"context_line":"    port_width \u003d 4"},{"line_number":394,"context_line":"    rep_ip_width \u003d 14"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_31aaa685","line":391,"updated":"2016-07-21 21:36:19.000000000","message":"i\u0027m pretty dubious of this refactoring, it doesn\u0027t really decouple it *that* much and it\u0027s still hard to test stand alone...","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5d50bcc86a54252f0933707c1474a44b02e41c9d","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    rep_ip_width \u003d 14"},{"line_number":395,"context_line":"    rep_port_width \u003d 4"},{"line_number":396,"context_line":"    ipv6 \u003d False"},{"line_number":397,"context_line":"    for dev in builder._iter_devs():"},{"line_number":398,"context_line":"        if not ipv6 and any(\u0027:\u0027 in dev[key]"},{"line_number":399,"context_line":"                            for key in (\u0027ip\u0027, \u0027replication_ip\u0027)):"},{"line_number":400,"context_line":"            ipv6 \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_9199d27b","line":397,"updated":"2016-07-21 21:36:19.000000000","message":"getting to a single iteration over the devices list (could be very long) is very good improvement I think.","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"f47e8798e202a5da09e53054b3ca5e46567ac810","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if not ipv6 and any(\u0027:\u0027 in dev[key]"},{"line_number":399,"context_line":"                            for key in (\u0027ip\u0027, \u0027replication_ip\u0027)):"},{"line_number":400,"context_line":"            ipv6 \u003d True"},{"line_number":401,"context_line":"        ip_width \u003d max(len(str(dev[\u0027ip\u0027])), ip_width)"},{"line_number":402,"context_line":"        rep_ip_width \u003d max(len(str(dev[\u0027replication_ip\u0027])), rep_ip_width)"},{"line_number":403,"context_line":"        port_width \u003d max(len(str(dev[\u0027port\u0027])), port_width)"},{"line_number":404,"context_line":"        rep_port_width \u003d max(len(str(dev[\u0027replication_port\u0027])),"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2af7a0f6","line":401,"updated":"2016-07-22 20:15:52.000000000","message":"dev[\u0027ip\u0027] and dev[\u0027replication_ip\u0027] are strings already and hence we needn\u0027t explicitly convert them again.","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"f47e8798e202a5da09e53054b3ca5e46567ac810","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                             rep_port_width)"},{"line_number":406,"context_line":"    if ipv6:"},{"line_number":407,"context_line":"        ip_width +\u003d 2"},{"line_number":408,"context_line":"        rep_ip_width +\u003d 2"},{"line_number":409,"context_line":"    header_line \u003d (\u0027Devices:%5s %6s %4s %\u0027 + str(ip_width)"},{"line_number":410,"context_line":"                   + \u0027s:%-\u0027 + str(port_width) + \u0027s %\u0027 +"},{"line_number":411,"context_line":"                   str(rep_ip_width) + \u0027s:%-\u0027 + str(rep_port_width) +"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_847317e7","line":408,"updated":"2016-07-22 20:15:52.000000000","message":"I\u0027m actually beginning to think now - if we have an ipv6 \"ip\" and an ipv4 \"replication_ip\", we need to individually check and set the column width accordingly. I missed this part in my patch too.","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5d50bcc86a54252f0933707c1474a44b02e41c9d","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                       \u0027weight\u0027, \u0027partitions\u0027, \u0027balance\u0027, \u0027flags\u0027,"},{"line_number":416,"context_line":"                       \u0027meta\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def print_dev_f(dev, balance_per_dev\u003d0.00, flags\u003d\u0027\u0027):"},{"line_number":419,"context_line":"        def get_formated_ip(key):"},{"line_number":420,"context_line":"            value \u003d dev[key]"},{"line_number":421,"context_line":"            if \u0027:\u0027 in value:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_717ffe14","line":418,"updated":"2016-07-21 21:36:19.000000000","message":"i really don\u0027t know if balance and flags should be params instead of derived values or additional closures?","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"}],"test/unit/cli/test.unit.cli.test_ringbuilder.TestCommands.test_ipv6_output.stub":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b79e776e38f184fed490257eec91f749a4bfe5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"            0      0    0 [2001:db8:85a3::8a2e:370:7334]:6200  [2001:db8:85a3::8a2e:370:7334]:6200   sda1 100.00          0 -100.00       some meta data"},{"line_number":8,"context_line":"            1      1    1                      127.0.0.1:66201                      127.0.0.1:66201  sda2 100.00          0 -100.00"},{"line_number":9,"context_line":"            2      2    2 [2001:db8:85a3::8a2e:370:7336]:6202                    127.0.10.127:7070   sdc3 100.00          0 -100.00"},{"line_number":10,"context_line":"            3      3    3 [2001:db8:85a3::8a2e:370:7337]:6203  [7001:db8:85a3::8a2e:370:7337]:11664  sdd4 100.00          0 -100.00"},{"line_number":11,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dada55a8_34ad6fe9","line":10,"updated":"2016-07-22 01:18:15.000000000","message":"I *think* this plaintext does an ok job of showing that the output here looks \"good\" for some measure...","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"}],"test/unit/cli/test_ringbuilder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b79e776e38f184fed490257eec91f749a4bfe5c","unresolved":false,"context_lines":[{"line_number":1736,"context_line":"            \"          0 -100.00       \\n\" \\"},{"line_number":1737,"context_line":"            \"            3      3    3  127.0.0.4:6203 \" \\"},{"line_number":1738,"context_line":"            \"     127.0.0.4:6203  sdd4   0.00\" \\"},{"line_number":1739,"context_line":"            \"          0    0.00       \\n\" % (self.tmpfile, self.tmpfile)"},{"line_number":1740,"context_line":"        self.assertEqual(expected, mock_stdout.getvalue())"},{"line_number":1741,"context_line":""},{"line_number":1742,"context_line":"    def test_default_ringfile_check(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_745c0719","line":1739,"updated":"2016-07-22 01:18:15.000000000","message":"If there\u0027s anything to take away from this its just that the stub files might be easier to review than a mess of pep8\u0027d crap like this.\n\nIs this output \"correct\"?  Does it look good?  idk...","commit_id":"d8bd579939b65eeb12a8de66d0688d02bda931ad"}]}