)]}'
{"swift/common/db.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b69c5f5d3eabd3f4c0762ed529d62001b9ca8b1b","unresolved":false,"context_lines":[{"line_number":798,"context_line":"            if validate_metadata:"},{"line_number":799,"context_line":"                DatabaseBroker.validate_metadata(md)"},{"line_number":800,"context_line":"            conn.execute(\u0027UPDATE %s_stat SET metadata \u003d ?\u0027 % self.db_type,"},{"line_number":801,"context_line":"                         (json.dumps({str(k): v for k, v in md.items()}),))"},{"line_number":802,"context_line":"            conn.commit()"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    def reclaim(self, age_timestamp, sync_timestamp):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c7000d37","line":801,"updated":"2016-07-26 09:37:59.000000000","message":"What is the type of k? If it\u0027s a byte string, str(k) is wrong. Did you try to run the test using python -bb to enable BytesWarning?","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"e28b260939ac51fa9420cacebc09723e67092adf","unresolved":false,"context_lines":[{"line_number":798,"context_line":"            if validate_metadata:"},{"line_number":799,"context_line":"                DatabaseBroker.validate_metadata(md)"},{"line_number":800,"context_line":"            conn.execute(\u0027UPDATE %s_stat SET metadata \u003d ?\u0027 % self.db_type,"},{"line_number":801,"context_line":"                         (json.dumps({str(k): v for k, v in md.items()}),))"},{"line_number":802,"context_line":"            conn.commit()"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    def reclaim(self, age_timestamp, sync_timestamp):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_14c87954","line":801,"in_reply_to":"dada55a8_c7000d37","updated":"2016-07-26 16:39:08.000000000","message":"one of the key was byte other one was string. So was getting typeError. it is getting added at utf8encodekeys method.","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"}],"test/unit/common/test_db.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b69c5f5d3eabd3f4c0762ed529d62001b9ca8b1b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from six.moves import range"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from oslo_serialization import base64"},{"line_number":37,"context_line":"from oslo_serialization.base64 import encode_as_bytes"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"import swift.common.db"},{"line_number":40,"context_line":"from swift.common.constraints import \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_471edd70","line":37,"updated":"2016-07-26 09:37:59.000000000","message":"Why not using the base64 module to get base64.encode_as_bytes()?","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"e28b260939ac51fa9420cacebc09723e67092adf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from six.moves import range"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from oslo_serialization import base64"},{"line_number":37,"context_line":"from oslo_serialization.base64 import encode_as_bytes"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"import swift.common.db"},{"line_number":40,"context_line":"from swift.common.constraints import \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_347dbd1c","line":37,"in_reply_to":"dada55a8_471edd70","updated":"2016-07-26 16:39:08.000000000","message":"Done","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b69c5f5d3eabd3f4c0762ed529d62001b9ca8b1b","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        def stub(*args, **kwargs):"},{"line_number":640,"context_line":"            for key in list(stub_dict):"},{"line_number":641,"context_line":"                del stub_dict[key]"},{"line_number":642,"context_line":"            stub_dict[\u0027args\u0027] \u003d args"},{"line_number":643,"context_line":"            for key, value in kwargs.items():"},{"line_number":644,"context_line":"                stub_dict[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_a76a39eb","line":641,"updated":"2016-07-26 09:37:59.000000000","message":"Hey, what is this code? It removes all keys of a dictionary?\n\nWhy not just: stub_dict.clear()?","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"},{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"e28b260939ac51fa9420cacebc09723e67092adf","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        def stub(*args, **kwargs):"},{"line_number":640,"context_line":"            for key in list(stub_dict):"},{"line_number":641,"context_line":"                del stub_dict[key]"},{"line_number":642,"context_line":"            stub_dict[\u0027args\u0027] \u003d args"},{"line_number":643,"context_line":"            for key, value in kwargs.items():"},{"line_number":644,"context_line":"                stub_dict[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_f47e8519","line":641,"in_reply_to":"dada55a8_a76a39eb","updated":"2016-07-26 16:39:08.000000000","message":"Done","commit_id":"83864fe0aca3a363cf6210de0b2dc518bb7c2167"}]}