)]}'
{"swift/common/utils.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"04c77a8a0cf74930c9dfe6fc7b630140f1f4d799","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"        pass"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"def audit_location_generator(devices, datadir, include_suffix,"},{"line_number":1510,"context_line":"                             mount_check\u003dTrue, logger\u003dNone):"},{"line_number":1511,"context_line":"    \u0027\u0027\u0027"},{"line_number":1512,"context_line":"    Given a devices path and a data directory, yield (path, device,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgL4%3D","line":1509,"updated":"2013-06-28 23:46:31.000000000","message":"Minor stuff, but I\u0027d just call this \"suffix\" or something, since \"include_suffix\" sounds like a boolean to me, and I\u0027d also default it to empty string.","commit_id":"f1de3d2eba3b5860537fe4e3d25b14050a028fd6"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"f56f3265d08f0b11661233ed6ba6ecb76a65d252","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"        pass"},{"line_number":1507,"context_line":""},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"def audit_location_generator(devices, datadir, include_suffix,"},{"line_number":1510,"context_line":"                             mount_check\u003dTrue, logger\u003dNone):"},{"line_number":1511,"context_line":"    \u0027\u0027\u0027"},{"line_number":1512,"context_line":"    Given a devices path and a data directory, yield (path, device,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fdzk%3D","line":1509,"in_reply_to":"AAAAPn%2F%2FgL4%3D","updated":"2013-07-01 12:03:15.000000000","message":"Done","commit_id":"f1de3d2eba3b5860537fe4e3d25b14050a028fd6"}],"swift/obj/auditor.py":[{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"04c77a8a0cf74930c9dfe6fc7b630140f1f4d799","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        :param partition: the partition the path is on"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            assert isinstance(path, basestring)"},{"line_number":138,"context_line":"            try:"},{"line_number":139,"context_line":"                name \u003d object_server.read_metadata(path)[\u0027name\u0027]"},{"line_number":140,"context_line":"            except (Exception, Timeout) as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgLc%3D","line":137,"updated":"2013-06-28 23:46:31.000000000","message":"This confuses me. Is there a case where path wasn\u0027t a basestring?","commit_id":"f1de3d2eba3b5860537fe4e3d25b14050a028fd6"},{"author":{"_account_id":6198,"name":"Peter Portante","email":"peter.a.portante@gmail.com","username":"peter-a-portante"},"change_message_id":"f56f3265d08f0b11661233ed6ba6ecb76a65d252","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        :param partition: the partition the path is on"},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            assert isinstance(path, basestring)"},{"line_number":138,"context_line":"            try:"},{"line_number":139,"context_line":"                name \u003d object_server.read_metadata(path)[\u0027name\u0027]"},{"line_number":140,"context_line":"            except (Exception, Timeout) as exc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fdy0%3D","line":137,"in_reply_to":"AAAAPn%2F%2FgLc%3D","updated":"2013-07-01 12:03:15.000000000","message":"Yes!  Unfortunately, the unit tests pass an integer, 5, to verify bad argument handling. :(  I was not going to change that, and so just put an assert here to do bad argument handling. See https://github.com/openstack/swift/blob/4a90414fc777252d073fc96d4477303bd2cf3a9d/test/unit/obj/test_auditor.py#L146.\n\nDo you think it is worth changing this? Or is a comment sufficient?","commit_id":"f1de3d2eba3b5860537fe4e3d25b14050a028fd6"}]}