)]}'
{"swift/common/middleware/recon.py":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"a8d0e4edac87cf21bffcf49e1cc5e773569d278c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                              \u0027drive.recon\u0027)"},{"line_number":62,"context_line":"        self.account_ring_path \u003d os.path.join(swift_dir, \u0027account.ring.gz\u0027)"},{"line_number":63,"context_line":"        self.container_ring_path \u003d os.path.join(swift_dir, \u0027container.ring.gz\u0027)"},{"line_number":64,"context_line":"        self.object_ring_pathes \u003d []"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for policy in POLICIES:"},{"line_number":67,"context_line":"            self.object_ring_pathes.append(os.path.join(swift_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d919267b","line":64,"updated":"2016-07-29 18:18:52.000000000","message":"nit: s/pathes/paths","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":18015,"name":"Peter Lisák","email":"peter.lisak@gmail.com","username":"peter.lisak"},"change_message_id":"4f11707dabff359abb9f67ebc115bf1205d4c6c1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                                              \u0027drive.recon\u0027)"},{"line_number":62,"context_line":"        self.account_ring_path \u003d os.path.join(swift_dir, \u0027account.ring.gz\u0027)"},{"line_number":63,"context_line":"        self.container_ring_path \u003d os.path.join(swift_dir, \u0027container.ring.gz\u0027)"},{"line_number":64,"context_line":"        self.object_ring_pathes \u003d []"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        for policy in POLICIES:"},{"line_number":67,"context_line":"            self.object_ring_pathes.append(os.path.join(swift_dir,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_415b7953","line":64,"in_reply_to":"bacf61ea_d919267b","updated":"2017-08-24 14:29:14.000000000","message":"fixed","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"c9064a035eb9f1991a90a3eaf73532f45e436058","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        elif rcheck \u003d\u003d \"mounted\":"},{"line_number":397,"context_line":"            content \u003d self.get_mounted()"},{"line_number":398,"context_line":"        elif rcheck \u003d\u003d \"unmounted\" and (rtype is None or rtype in all_rtypes):"},{"line_number":399,"context_line":"            # handle both old and new style unmounted devices"},{"line_number":400,"context_line":"            content \u003d self.get_unmounted(rtype)"},{"line_number":401,"context_line":"        elif rcheck \u003d\u003d \"diskusage\" and (rtype is None or rtype in all_rtypes):"},{"line_number":402,"context_line":"            # handle both old and new style disk usage of devices"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5f2e368c","line":399,"updated":"2016-08-02 11:33:32.000000000","message":"The old style shouldn\u0027t be a problem anymore I think? Since you\u0027ve made changes in cli/recon.py","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"}],"test/unit/common/middleware/test_recon.py":[{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"a8d0e4edac87cf21bffcf49e1cc5e773569d278c","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"    def test_get_diskusage_ring_devs(self):"},{"line_number":1078,"context_line":"        ring_devs_calls \u003d []"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        def fake__ring_devs(*args, **kwargs):"},{"line_number":1081,"context_line":"            ring_devs_calls.append((args, kwargs))"},{"line_number":1082,"context_line":"            return []"},{"line_number":1083,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_747d9f6d","line":1080,"updated":"2016-07-29 18:18:52.000000000","message":"nit: s/fake__ring_devs/fake_ring_devs/","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"a8d0e4edac87cf21bffcf49e1cc5e773569d278c","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        du_resp \u003d []"},{"line_number":1085,"context_line":"        self.mockos.ls_output \u003d [\u0027canhazdrive1\u0027]"},{"line_number":1086,"context_line":"        self.mockos.isdir_output \u003d True"},{"line_number":1087,"context_line":"        self.app._ring_devs \u003d fake__ring_devs"},{"line_number":1088,"context_line":"        rv \u003d self.app.get_diskusage(\"object\")"},{"line_number":1089,"context_line":"        self.assertEqual(self.mockos.listdir_calls, [((\u0027/srv/node\u0027,), {})])"},{"line_number":1090,"context_line":"        self.assertEqual(self.mockos.isdir_calls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3f513837","line":1087,"updated":"2016-07-29 18:18:52.000000000","message":"Could you add a unit test that where rtype is not none, and real self._ring_devs(rtype) is called so that the new method (lines 96-112) would be covered by the unit tests?","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":18015,"name":"Peter Lisák","email":"peter.lisak@gmail.com","username":"peter.lisak"},"change_message_id":"4f11707dabff359abb9f67ebc115bf1205d4c6c1","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        du_resp \u003d []"},{"line_number":1085,"context_line":"        self.mockos.ls_output \u003d [\u0027canhazdrive1\u0027]"},{"line_number":1086,"context_line":"        self.mockos.isdir_output \u003d True"},{"line_number":1087,"context_line":"        self.app._ring_devs \u003d fake__ring_devs"},{"line_number":1088,"context_line":"        rv \u003d self.app.get_diskusage(\"object\")"},{"line_number":1089,"context_line":"        self.assertEqual(self.mockos.listdir_calls, [((\u0027/srv/node\u0027,), {})])"},{"line_number":1090,"context_line":"        self.assertEqual(self.mockos.isdir_calls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_129f0160","line":1087,"in_reply_to":"bacf61ea_2b2afee7","updated":"2017-08-24 14:29:14.000000000","message":"unittest added","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"c9064a035eb9f1991a90a3eaf73532f45e436058","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        du_resp \u003d []"},{"line_number":1085,"context_line":"        self.mockos.ls_output \u003d [\u0027canhazdrive1\u0027]"},{"line_number":1086,"context_line":"        self.mockos.isdir_output \u003d True"},{"line_number":1087,"context_line":"        self.app._ring_devs \u003d fake__ring_devs"},{"line_number":1088,"context_line":"        rv \u003d self.app.get_diskusage(\"object\")"},{"line_number":1089,"context_line":"        self.assertEqual(self.mockos.listdir_calls, [((\u0027/srv/node\u0027,), {})])"},{"line_number":1090,"context_line":"        self.assertEqual(self.mockos.isdir_calls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5fe11629","line":1087,"in_reply_to":"bacf61ea_3f513837","updated":"2016-08-02 11:33:32.000000000","message":"Below line (1088) tests the rtype as not none, by passing the value to get_diskusage which in turn calls self._ring_devs(rtype). This is also done for get_unmounted (1014)","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"},{"author":{"_account_id":12279,"name":"Janie Richling","email":"jrichli@us.ibm.com","username":"jrichli"},"change_message_id":"68b8dc58a65217d1d982f3c4a2cc63a5c87fa538","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"        du_resp \u003d []"},{"line_number":1085,"context_line":"        self.mockos.ls_output \u003d [\u0027canhazdrive1\u0027]"},{"line_number":1086,"context_line":"        self.mockos.isdir_output \u003d True"},{"line_number":1087,"context_line":"        self.app._ring_devs \u003d fake__ring_devs"},{"line_number":1088,"context_line":"        rv \u003d self.app.get_diskusage(\"object\")"},{"line_number":1089,"context_line":"        self.assertEqual(self.mockos.listdir_calls, [((\u0027/srv/node\u0027,), {})])"},{"line_number":1090,"context_line":"        self.assertEqual(self.mockos.isdir_calls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2b2afee7","line":1087,"in_reply_to":"bacf61ea_5fe11629","updated":"2016-08-03 03:12:58.000000000","message":"yes, self.ring_dev(rtype) is called from this test, but that method is \"fake__ring_devs\" in this test.\n\nIn the resulting call from line 1014, the rtype is none, IIRC.  I tested the lines were not covered by placing a break point while running the unit tests.  The lines also show in the report for lines not covered.","commit_id":"fc6c1f50cf3740a9e056b3f7b72799e0bb377232"}]}