)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"e945fca4e6c86c083403fc840e4463be1f0173a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add a try block in __init__.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Try block ensures that the section has not duplicated."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iac38674099957b3dfe46d38581a02cac559af3f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_63b28e95","line":10,"updated":"2016-08-08 06:03:11.000000000","message":"This commit message needs more detail. From the commit message alone, I have no idea what the change is about, or whats going on. I.e which __init__.py, section in what? After reading the review it makes sense. The commit message should tell the reviewer what is happening in the change. So we need more detail, maybe something like:\n\n  Detect duplicate storage policy 0 sections in func tests\n\n  This change will ensure that only 1 storage policy 0 section is defined in in-process func tests.","commit_id":"bdec3e14db30eb0266eff5de10fba533feec6591"},{"author":{"_account_id":20508,"name":"Mohit Motiani","email":"mohit.motiani@intel.com","username":"mohit.motiani"},"change_message_id":"37c52d29ec8c45b8abd0e8b0c00712ea6328f449","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add a try block in __init__.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Try block ensures that the section has not duplicated."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iac38674099957b3dfe46d38581a02cac559af3f8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_adc45740","line":10,"in_reply_to":"bacf61ea_63b28e95","updated":"2016-08-08 14:41:43.000000000","message":"Done","commit_id":"bdec3e14db30eb0266eff5de10fba533feec6591"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"0192c1b0006f27f2f3f4c47c31fa93e476891f10","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Detect duplicate storage policy 0 section in func tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change will ensure that only 1 storage policy 0 section is"},{"line_number":10,"context_line":"defined in in-process func tests. In case of duplicacy, an exception"},{"line_number":11,"context_line":"will be raised."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_c69f8e4e","line":9,"updated":"2016-08-10 04:26:47.000000000","message":"nit: change 1 to one. It will help differentiating an index.","commit_id":"1ec76c65d4b0c871a0b20f6e96ee92f376cfdfab"}],"test/functional/__init__.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"38b7c05ccb7f512aa33e2b9acf13125b3e8d6552","unresolved":false,"context_lines":[{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    # clear all policies from test swift.conf before adding test policy back"},{"line_number":217,"context_line":"    for policy in policies:"},{"line_number":218,"context_line":"        conf.remove_section(sp_prefix + str(policy.idx))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    if policy_specified:"},{"line_number":221,"context_line":"        policy_to_test \u003d policies.get_by_name(policy_specified)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_6cf5c555","line":218,"updated":"2016-08-10 14:38:39.000000000","message":"here we remove all policy sections","commit_id":"c3e5157aadf7ccbc53d2ab31ae3cb3d2671f9700"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"38b7c05ccb7f512aa33e2b9acf13125b3e8d6552","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    # make policy_to_test be policy index 0 and default for the test config"},{"line_number":231,"context_line":"    sp_zero_section \u003d sp_prefix + \u00270\u0027"},{"line_number":232,"context_line":"    try:"},{"line_number":233,"context_line":"        conf.add_section(sp_zero_section)"},{"line_number":234,"context_line":"    except DuplicateSectionError:"},{"line_number":235,"context_line":"        msg \u003d \"Duplicate section found: %s\" % sp_zero_section"},{"line_number":236,"context_line":"        raise InProcessException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_4ca9e123","line":233,"updated":"2016-08-10 14:38:39.000000000","message":"here we add one section - how would we end up with more than one section with that name? is there a flaw with the clearing of sections at line 217-218?","commit_id":"c3e5157aadf7ccbc53d2ab31ae3cb3d2671f9700"},{"author":{"_account_id":12261,"name":"Mahati","email":"mahati.chamarthy@gmail.com","username":"Mahati"},"change_message_id":"113f3235a46957bcf7228875b537475d76848e5e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    # make policy_to_test be policy index 0 and default for the test config"},{"line_number":231,"context_line":"    sp_zero_section \u003d sp_prefix + \u00270\u0027"},{"line_number":232,"context_line":"    try:"},{"line_number":233,"context_line":"        conf.add_section(sp_zero_section)"},{"line_number":234,"context_line":"    except DuplicateSectionError:"},{"line_number":235,"context_line":"        msg \u003d \"Duplicate section found: %s\" % sp_zero_section"},{"line_number":236,"context_line":"        raise InProcessException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_d9e6fbe6","line":233,"in_reply_to":"9ad45d7e_4ca9e123","updated":"2016-08-11 12:11:01.000000000","message":"hmm that\u0027s a good question. The change itself looks ok, but not sure if this has ever been an actual issue.","commit_id":"c3e5157aadf7ccbc53d2ab31ae3cb3d2671f9700"}]}