)]}'
{"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e06b81d8a18e3ff61f8e06925730f45873cedb6d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# we do not use -W here because we are doing some slightly tricky"},{"line_number":75,"context_line":"# things to build a single page document, and as such, we are ok"},{"line_number":76,"context_line":"# ignoring the duplicate stanzas warning."},{"line_number":77,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} -U --force-reinstall {opts} {packages}"},{"line_number":78,"context_line":"commands \u003d"},{"line_number":79,"context_line":"  rm -rf api-ref/build"},{"line_number":80,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_3f18c0d2","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":181},"updated":"2016-08-11 18:14:21.000000000","message":"remove the install_command completely - you should only need the one on the top","commit_id":"46b9c008a6735600881b4a84689363c8288548d9"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"ef02e3e2fe7a6372224b0c5cb61dbfd0e675b121","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# we do not use -W here because we are doing some slightly tricky"},{"line_number":75,"context_line":"# things to build a single page document, and as such, we are ok"},{"line_number":76,"context_line":"# ignoring the duplicate stanzas warning."},{"line_number":77,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} -U --force-reinstall {opts} {packages}"},{"line_number":78,"context_line":"commands \u003d"},{"line_number":79,"context_line":"  rm -rf api-ref/build"},{"line_number":80,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_7bdb6b7c","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":181},"in_reply_to":"9ad45d7e_3f18c0d2","updated":"2016-08-11 18:23:02.000000000","message":"Done","commit_id":"46b9c008a6735600881b4a84689363c8288548d9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e06b81d8a18e3ff61f8e06925730f45873cedb6d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"[testenv:install-guide]"},{"line_number":83,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} -U --force-reinstall {opts} {packages}"},{"line_number":84,"context_line":"commands \u003d sphinx-build -a -E -W -d install-guide/build/doctrees -b html install-guide/source install-guide/build/html"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"[testenv:bandit]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_5f7c94eb","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":181},"updated":"2016-08-11 18:14:21.000000000","message":"remove it and thus use the default","commit_id":"46b9c008a6735600881b4a84689363c8288548d9"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"ef02e3e2fe7a6372224b0c5cb61dbfd0e675b121","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  sphinx-build -W -b html -d api-ref/build/doctrees api-ref/source api-ref/build/html"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"[testenv:install-guide]"},{"line_number":83,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} -U --force-reinstall {opts} {packages}"},{"line_number":84,"context_line":"commands \u003d sphinx-build -a -E -W -d install-guide/build/doctrees -b html install-guide/source install-guide/build/html"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"[testenv:bandit]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9ad45d7e_bbe1632c","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":181},"in_reply_to":"9ad45d7e_5f7c94eb","updated":"2016-08-11 18:23:02.000000000","message":"Done","commit_id":"46b9c008a6735600881b4a84689363c8288548d9"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a24ba311e60e7fb8e8477000af51e4e2907ac01d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}  --allow-insecure netifaces -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         NOSE_WITH_COVERAGE\u003d1"},{"line_number":11,"context_line":"         NOSE_COVER_BRANCHES\u003d1"}],"source_content_type":"text/x-properties","patch_set":3,"id":"9a629dbe_1ebf92aa","line":8,"updated":"2016-11-11 12:45:48.000000000","message":"The -c addition makes sense, but -c option was added in pip 7.0.1 [1] and openstack global requirements has pip\u003e\u003d6.0 [2] https://github.com/openstack/requirements/blob/master/global-requirements.txt\n\nWhere do we bootstrap a requirement for pip version? I was on 7.0.1 so this patch worked but when I roll pip back to 6.0 I get:\n\n  $ pip install -chttps://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt -U -e /home/swift/swift\n\nUsage:   \n  pip install [options] \u003crequirement specifier\u003e [package-index-options] ...\n  pip install [options] -r \u003crequirements file\u003e [package-index-options] ...\n  pip install [options] [-e] \u003cvcs project url\u003e ...\n  pip install [options] [-e] \u003clocal project path\u003e ...\n  pip install [options] \u003carchive url/path\u003e ...\n\nno such option: -c\n\nBut tox -e venv -r works ok because tox or virtualenv is pulling in pip 9.0.1. But is that dependent on a version of tox or virtual env? where do we specify the tox and virtualenv versions required?\n\n\nALSO...\n\nWe lost --allow-external netifaces that was added here [3]\n\npip8.0.0 has \"Deprecate and no-op the --allow-external, --allow-all-external, and --allow-unverified functionality that was added as part of PEP 438. With changes made to the repository protocol made in PEP 470, these options are no longer functional.\"\n\n--allow-insecure was replaced by allow-unverified in pip1.5\n\n\n\n\n\n[1] https://pip.pypa.io/en/stable/user_guide/#constraints-files\n[3] Change-Id: I587b516f3f77c930475ca2eaae5ff73c5d2ab576","commit_id":"91ce1bb1147ceca1b3ea63afc54ad3e0d34fdec6"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"71b69bfb9d3e1f99aa5f1af79d37c9493cb1825b","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}  --allow-insecure netifaces -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         NOSE_WITH_COVERAGE\u003d1"},{"line_number":11,"context_line":"         NOSE_COVER_BRANCHES\u003d1"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5a74a57a_46bac06f","line":8,"in_reply_to":"5a74a57a_3beed622","updated":"2016-11-24 04:59:20.000000000","message":"I\u0027ve proposed the g-r fix in I45eee626713438af5fc676f2b5f636d7ec23f7be","commit_id":"91ce1bb1147ceca1b3ea63afc54ad3e0d34fdec6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"10de174fabf73500adda8b72c586780f1b2743a4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}  --allow-insecure netifaces -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         NOSE_WITH_COVERAGE\u003d1"},{"line_number":11,"context_line":"         NOSE_COVER_BRANCHES\u003d1"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5a74a57a_1b5e7ae9","line":8,"in_reply_to":"9a629dbe_1ebf92aa","updated":"2016-11-23 17:19:13.000000000","message":"I forgot to explain the tox virtualenv pip relationship. Tox depends on virtualenv, virtualenv bundles setuptools and pip. The version of pip and setuptools bundled in virtualenv is dependent on the version of virtualenv. Releases to setuptools, pip, or virtualenv typically implies releases of the other two project as well.\n\nSo it may be worthwhile calling out the min version of virtualenv that corresponds to the min version of pip if we don\u0027t do that already.","commit_id":"91ce1bb1147ceca1b3ea63afc54ad3e0d34fdec6"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4e4a0d473799fb09392a717bb823e8e29955a76d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt}  --allow-insecure netifaces -U {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         NOSE_WITH_COVERAGE\u003d1"},{"line_number":11,"context_line":"         NOSE_COVER_BRANCHES\u003d1"}],"source_content_type":"text/x-properties","patch_set":3,"id":"5a74a57a_3beed622","line":8,"in_reply_to":"9a629dbe_1ebf92aa","updated":"2016-11-23 17:16:54.000000000","message":"re pip\u003e\u003d6.0 I think that just means we need to update the boundary to reflect reality. Anyone can propose this change.\n\nA quick local test installing netifaces shows that you no longer need to whitelist it for external hosting/security reasons. You can also see that at https://pypi.python.org/pypi/netifaces/ there are sdists and wheels hosted on pypi proper. I would drop the --allow-insecure netifaces as a result.","commit_id":"91ce1bb1147ceca1b3ea63afc54ad3e0d34fdec6"}]}